@netlify/plugin-nextjs 4.29.3-appdir.0 → 4.29.3

package/lib/helpers/edge.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.writeEdgeFunctions = exports.writeDevEdgeFunction = exports.cleanupEdgeFunctions = exports.loadAppPathRoutesManifest = exports.loadMiddlewareManifest = void 0;
+exports.writeEdgeFunctions = exports.writeDevEdgeFunction = exports.cleanupEdgeFunctions = exports.loadMiddlewareManifest = void 0;
 /* eslint-disable max-lines */
 const fs_1 = require("fs");
 const path_1 = require("path");
@@ -13,15 +13,14 @@ const fs_extra_1 = require("fs-extra");
 const outdent_1 = require("outdent");
 const config_1 = require("./config");
 const matchers_1 = require("./matchers");
-const maybeLoadJson = (path) => {
-    if ((0, fs_1.existsSync)(path)) {
-        return (0, fs_extra_1.readJson)(path);
+const loadMiddlewareManifest = (netlifyConfig) => {
+    const middlewarePath = (0, path_1.resolve)(netlifyConfig.build.publish, 'server', 'middleware-manifest.json');
+    if (!(0, fs_1.existsSync)(middlewarePath)) {
+        return null;
     }
+    return (0, fs_extra_1.readJson)(middlewarePath);
 };
-const loadMiddlewareManifest = (netlifyConfig) => maybeLoadJson((0, path_1.resolve)(netlifyConfig.build.publish, 'server', 'middleware-manifest.json'));
 exports.loadMiddlewareManifest = loadMiddlewareManifest;
-const loadAppPathRoutesManifest = (netlifyConfig) => maybeLoadJson((0, path_1.resolve)(netlifyConfig.build.publish, 'app-path-routes-manifest.json'));
-exports.loadAppPathRoutesManifest = loadAppPathRoutesManifest;
 /**
  * Convert the Next middleware name into a valid Edge Function name
  */
@@ -36,9 +35,6 @@ import {
 // Deno defines "window", but naughty libraries think this means it's a browser
 delete globalThis.window
 globalThis.process = { env: {...Deno.env.toObject(), NEXT_RUNTIME: 'edge', 'NEXT_PRIVATE_MINIMAL_MODE': '1' } }
-globalThis.EdgeRuntime = "netlify-edge"
-// Next uses "self" as a function-scoped global-like object
-const self = {}
 let _ENTRIES = {}
 
 // Next.js uses this extension to the Headers API implemented by Cloudflare workerd
@@ -70,6 +66,10 @@ const fetch = async (url, init) => {
   }
 }
 
+// Next edge runtime uses "self" as a function-scoped global-like object, but some of the older polyfills expect it to equal globalThis
+// See https://nextjs.org/docs/basic-features/supported-browsers-features#polyfills
+const self = { ...globalThis, fetch }
+
 `;
 // Slightly different spacing in different versions!
 const IMPORT_UNSUPPORTED = [
@@ -109,7 +109,7 @@ const getMiddlewareBundle = async ({ edgeFunctionDefinition, netlifyConfig, }) =
 };
 const getEdgeTemplatePath = (file) => (0, path_1.join)(__dirname, '..', '..', 'src', 'templates', 'edge', file);
 const copyEdgeSourceFile = ({ file, target, edgeFunctionDir, }) => fs_1.promises.copyFile(getEdgeTemplatePath(file), (0, path_1.join)(edgeFunctionDir, target !== null && target !== void 0 ? target : file));
-const writeEdgeFunction = async ({ edgeFunctionDefinition, edgeFunctionRoot, netlifyConfig, pageRegexMap, appPathRoutesManifest = {}, nextConfig, cache, }) => {
+const writeEdgeFunction = async ({ edgeFunctionDefinition, edgeFunctionRoot, netlifyConfig, nextConfig, }) => {
     const name = sanitizeName(edgeFunctionDefinition.name);
     const edgeFunctionDir = (0, path_1.join)(edgeFunctionRoot, name);
     const bundle = await getMiddlewareBundle({
@@ -137,19 +137,11 @@ const writeEdgeFunction = async ({ edgeFunctionDefinition, edgeFunctionRoot, net
     else {
         matchers.push(...edgeFunctionDefinition.matchers);
     }
-    // If the EF matches a page, it's an app dir page so needs a matcher too
-    // The object will be empty if appDir isn't enabled in the Next config
-    if (pageRegexMap && edgeFunctionDefinition.page in appPathRoutesManifest) {
-        const regexp = pageRegexMap.get(appPathRoutesManifest[edgeFunctionDefinition.page]);
-        if (regexp) {
-            matchers.push({ regexp });
-        }
-    }
     await (0, fs_extra_1.writeJson)((0, path_1.join)(edgeFunctionDir, 'matchers.json'), matchers);
     // We add a defintion for each matching path
     return matchers.map((matcher) => {
         const pattern = (0, matchers_1.stripLookahead)(matcher.regexp);
-        return { function: name, pattern, name: edgeFunctionDefinition.name, cache };
+        return { function: name, pattern, name: edgeFunctionDefinition.name };
     });
 };
 const cleanupEdgeFunctions = ({ INTERNAL_EDGE_FUNCTIONS_SRC = '.netlify/edge-functions', }) => (0, fs_extra_1.emptyDir)(INTERNAL_EDGE_FUNCTIONS_SRC);
@@ -177,7 +169,7 @@ exports.writeDevEdgeFunction = writeDevEdgeFunction;
 /**
  * Writes Edge Functions for the Next middleware
  */
-const writeEdgeFunctions = async ({ netlifyConfig, routesManifest, }) => {
+const writeEdgeFunctions = async (netlifyConfig) => {
     const manifest = {
         functions: [],
         version: 1,
@@ -224,22 +216,13 @@ const writeEdgeFunctions = async ({ netlifyConfig, routesManifest, }) => {
         // Older versions of the manifest format don't have the functions field
         // No, the version field was not incremented
         if (typeof middlewareManifest.functions === 'object') {
-            // When using the app dir, we also need to check if the EF matches a page
-            const appPathRoutesManifest = await (0, exports.loadAppPathRoutesManifest)(netlifyConfig);
-            const pageRegexMap = new Map([...(routesManifest.dynamicRoutes || []), ...(routesManifest.staticRoutes || [])].map((route) => [
-                route.page,
-                route.regex,
-            ]));
             for (const edgeFunctionDefinition of Object.values(middlewareManifest.functions)) {
                 usesEdge = true;
                 const functionDefinitions = await writeEdgeFunction({
                     edgeFunctionDefinition,
                     edgeFunctionRoot,
                     netlifyConfig,
-                    pageRegexMap,
-                    appPathRoutesManifest,
                     nextConfig,
-                    cache: 'manual',
                 });
                 manifest.functions.push(...functionDefinitions);
             }

package/lib/helpers/files.js

@@ -70,6 +70,7 @@ exports.getMiddleware = getMiddleware;
 const moveStaticPages = async ({ netlifyConfig, target, i18n, basePath, }) => {
     console.log('Moving static page files to serve from CDN...');
     const outputDir = (0, pathe_1.join)(netlifyConfig.build.publish, target === 'server' ? 'server' : 'serverless');
+    const root = (0, pathe_1.join)(outputDir, 'pages');
     const buildId = (0, fs_extra_1.readFileSync)((0, pathe_1.join)(netlifyConfig.build.publish, 'BUILD_ID'), 'utf8').trim();
     const dataDir = (0, pathe_1.join)('_next', 'data', buildId);
     await (0, fs_extra_1.ensureDir)((0, pathe_1.join)(netlifyConfig.build.publish, dataDir));
@@ -91,17 +92,14 @@ const moveStaticPages = async ({ netlifyConfig, target, i18n, basePath, }) => {
             }
         }
     });
-    let fileCount = 0;
+    const files = [];
     const filesManifest = {};
     const moveFile = async (file) => {
-        // Strip the initial 'app' or 'pages' directory from the output path
-        const pathname = file.split('/').slice(1).join('/');
-        // .rsc data files go next to the html file
         const isData = file.endsWith('.json');
-        const source = (0, pathe_1.join)(outputDir, file);
-        const targetFile = isData ? (0, pathe_1.join)(dataDir, pathname) : pathname;
+        const source = (0, pathe_1.join)(root, file);
+        const targetFile = isData ? (0, pathe_1.join)(dataDir, file) : file;
         const targetPath = basePath ? (0, pathe_1.join)(basePath, targetFile) : targetFile;
-        fileCount += 1;
+        files.push(file);
         filesManifest[file] = targetPath;
         const dest = (0, pathe_1.join)(netlifyConfig.build.publish, targetPath);
         try {
@@ -112,8 +110,8 @@ const moveStaticPages = async ({ netlifyConfig, target, i18n, basePath, }) => {
         }
     };
     // Move all static files, except error documents and nft manifests
-    const pages = await (0, globby_1.default)(['{app,pages}/**/*.{html,json,rsc}', '!**/(500|404|*.js.nft).{html,json}'], {
-        cwd: outputDir,
+    const pages = await (0, globby_1.default)(['**/*.{html,json}', '!**/(500|404|*.js.nft).{html,json}'], {
+        cwd: root,
         dot: true,
     });
     const matchingMiddleware = new Set();
@@ -151,7 +149,7 @@ const moveStaticPages = async ({ netlifyConfig, target, i18n, basePath, }) => {
         return limit(moveFile, filePath);
     });
     await Promise.all(promises);
-    console.log(`Moved ${fileCount} files`);
+    console.log(`Moved ${files.length} files`);
     if (matchedPages.size !== 0) {
         console.log((0, chalk_1.yellowBright)((0, outdent_1.outdent) `
         Skipped moving ${matchedPages.size} ${matchedPages.size === 1 ? 'file because it matches' : 'files because they match'} middleware, so cannot be deployed to the CDN and will be served from the origin instead.
@@ -276,11 +274,13 @@ const getServerFile = (root, includeBase = true) => {
 /**
  * Find the source file for a given page route
  */
-const getSourceFileForPage = (page, root) => {
-    for (const extension of SOURCE_FILE_EXTENSIONS) {
-        const file = (0, pathe_1.join)(root, `${page}.${extension}`);
-        if ((0, fs_extra_1.existsSync)(file)) {
-            return file;
+const getSourceFileForPage = (page, roots) => {
+    for (const root of roots) {
+        for (const extension of SOURCE_FILE_EXTENSIONS) {
+            const file = (0, pathe_1.join)(root, `${page}.${extension}`);
+            if ((0, fs_extra_1.existsSync)(file)) {
+                return file;
+            }
         }
     }
     console.log('Could not find source file for page', page);

package/lib/helpers/functions.js

@@ -20,13 +20,10 @@ const utils_1 = require("./utils");
 const generateFunctions = async ({ FUNCTIONS_SRC = constants_1.DEFAULT_FUNCTIONS_SRC, INTERNAL_FUNCTIONS_SRC, PUBLISH_DIR }, appDir, apiRoutes) => {
     const publish = (0, pathe_1.resolve)(PUBLISH_DIR);
     const functionsDir = (0, pathe_1.resolve)(INTERNAL_FUNCTIONS_SRC || FUNCTIONS_SRC);
+    console.log({ functionsDir });
     const functionDir = (0, pathe_1.join)(functionsDir, constants_1.HANDLER_FUNCTION_NAME);
     const publishDir = (0, pathe_1.relative)(functionDir, publish);
     for (const { route, config, compiled } of apiRoutes) {
-        // Don't write a lambda if the runtime is edge
-        if (config.runtime === 'experimental-edge') {
-            continue;
-        }
         const apiHandlerSource = await (0, getApiHandler_1.getApiHandler)({
             page: route,
             config,
@@ -126,9 +123,12 @@ exports.setupImageFunction = setupImageFunction;
 const getApiRouteConfigs = async (publish, baseDir) => {
     const pages = await (0, fs_extra_1.readJSON)((0, pathe_1.join)(publish, 'server', 'pages-manifest.json'));
     const apiRoutes = Object.keys(pages).filter((page) => page.startsWith('/api/'));
+    // two possible places
+    // Ref: https://nextjs.org/docs/advanced-features/src-directory
     const pagesDir = (0, pathe_1.join)(baseDir, 'pages');
+    const srcPagesDir = (0, pathe_1.join)(baseDir, 'src', 'pages');
     return await Promise.all(apiRoutes.map(async (apiRoute) => {
-        const filePath = (0, files_1.getSourceFileForPage)(apiRoute, pagesDir);
+        const filePath = (0, files_1.getSourceFileForPage)(apiRoute, [pagesDir, srcPagesDir]);
         return { route: apiRoute, config: await (0, analysis_1.extractConfigFromFile)(filePath), compiled: pages[apiRoute] };
     }));
 };

package/lib/index.js

@@ -44,7 +44,7 @@ const plugin = {
         }
         const { publish } = netlifyConfig.build;
         (0, verification_1.checkNextSiteHasBuilt)({ publish, failBuild });
-        const { appDir, basePath, i18n, images, target, ignore, trailingSlash, outdir, experimental, routesManifest } = await (0, config_1.getNextConfig)({
+        const { appDir, basePath, i18n, images, target, ignore, trailingSlash, outdir, experimental } = await (0, config_1.getNextConfig)({
             publish,
             failBuild,
         });
@@ -118,7 +118,7 @@ const plugin = {
             buildId,
             apiRoutes,
         });
-        await (0, edge_1.writeEdgeFunctions)({ netlifyConfig, routesManifest });
+        await (0, edge_1.writeEdgeFunctions)(netlifyConfig);
     },
     async onPostBuild({ netlifyConfig: { build: { publish }, redirects, headers, }, utils: { status, cache, functions, build: { failBuild }, }, constants: { FUNCTIONS_DIST }, }) {
         await (0, cache_1.saveCache)({ cache, publish });
@@ -134,14 +134,11 @@ const plugin = {
         await (0, verification_1.checkForOldFunctions)({ functions });
         await (0, verification_1.checkZipSize)((0, path_1.join)(FUNCTIONS_DIST, `${constants_1.ODB_FUNCTION_NAME}.zip`));
         const nextConfig = await (0, config_1.getNextConfig)({ publish, failBuild });
-        const { basePath, appDir, experimental } = nextConfig;
+        const { basePath, appDir } = nextConfig;
         (0, config_1.generateCustomHeaders)(nextConfig, headers);
         (0, verification_1.warnForProblematicUserRewrites)({ basePath, redirects });
         (0, verification_1.warnForRootRedirects)({ appDir });
         await (0, functions_1.warnOnApiRoutes)({ FUNCTIONS_DIST });
-        if (experimental === null || experimental === void 0 ? void 0 : experimental.appDir) {
-            console.log('🧪 Thank you for testing "appDir" support on Netlify. For known issues and to give feedback, visit https://ntl.fyi/next-13-feedback');
-        }
     },
 };
 // The types haven't been updated yet

package/lib/templates/getApiHandler.js

@@ -105,7 +105,7 @@ const getApiHandler = ({ page, config, publishDir = '../../../.next', appDir = '
   const { config }  = require("${publishDir}/required-server-files.json")
   let staticManifest
   const path = require("path");
-  const pageRoot = path.resolve(path.join(__dirname, "${publishDir}", "server"));
+  const pageRoot = path.resolve(path.join(__dirname, "${publishDir}", "serverless", "pages"));
   const handler = (${makeHandler.toString()})(config, "${appDir}", pageRoot, ${JSON.stringify(page)})
   exports.handler = ${config.type === "experimental-scheduled" /* ApiRouteType.SCHEDULED */ ? `schedule(${JSON.stringify(config.schedule)}, handler);` : 'handler'}
 `;

package/lib/templates/getHandler.js

@@ -37,7 +37,9 @@ const makeHandler = (conf, app, pageRoot, staticManifest = [], mode = 'ssr') =>
     for (const [key, value] of Object.entries(conf.env)) {
         process.env[key] = String(value);
     }
-    augmentFsModule({ promises, staticManifest, pageRoot });
+    // Set during the request as it needs the host header. Hoisted so we can define the function once
+    let base;
+    augmentFsModule({ promises, staticManifest, pageRoot, getBase: () => base });
     // We memoize this because it can be shared between requests, but don't instantiate it until
     // the first request because we need the host and port.
     let bridge;
@@ -47,6 +49,9 @@ const makeHandler = (conf, app, pageRoot, staticManifest = [], mode = 'ssr') =>
         }
         const url = new URL(event.rawUrl);
         const port = Number.parseInt(url.port) || 80;
+        const { host } = event.headers;
+        const protocol = event.headers['x-forwarded-proto'] || 'http';
+        base = `${protocol}://${host}`;
         const NextServer = getNextServer();
         const nextServer = new NextServer({
             conf,
@@ -144,7 +149,7 @@ const getHandler = ({ isODB = false, publishDir = '../../../.next', appDir = '..
     staticManifest = require("${publishDir}/static-manifest.json")
   } catch {}
   const path = require("path");
-  const pageRoot = path.resolve(path.join(__dirname, "${publishDir}", "server"));
+  const pageRoot = path.resolve(path.join(__dirname, "${publishDir}", config.target === "server" ? "server" : "serverless", "pages"));
   exports.handler = ${isODB
     ? `builder((${makeHandler.toString()})(config, "${appDir}", pageRoot, staticManifest, 'odb'));`
     : `(${makeHandler.toString()})(config, "${appDir}", pageRoot, staticManifest, 'ssr');`}

package/lib/templates/handlerUtils.js

@@ -75,7 +75,7 @@ exports.getMultiValueHeaders = getMultiValueHeaders;
 /**
  * Monkey-patch the fs module to download missing files from the CDN
  */
-const augmentFsModule = ({ promises, staticManifest, pageRoot, }) => {
+const augmentFsModule = ({ promises, staticManifest, pageRoot, getBase, }) => {
     // Only do this if we have some static files moved to the CDN
     if (staticManifest.length === 0) {
         return;
@@ -93,23 +93,22 @@ const augmentFsModule = ({ promises, staticManifest, pageRoot, }) => {
     const statsOrig = promises.stat;
     // ...then money-patch it to see if it's requesting a CDN file
     promises.readFile = (async (file, options) => {
-        // In production use the public URL (e.g. https://example.com). Otherwise use the deploy URL, e.g. https://deploy-preview-123--example.netlify.app
-        const baseUrl = process.env.CONTEXT === 'production' ? process.env.URL : process.env.DEPLOY_PRIME_URL;
+        const base = getBase();
         // We only care about page files
         if (file.startsWith(pageRoot)) {
-            // We only want the part after `.next/server/`
+            // We only want the part after `pages/`
             const filePath = file.slice(pageRoot.length + 1);
             // Is it in the CDN and not local?
             if (staticFiles.has(filePath) && !(0, fs_1.existsSync)(file)) {
                 // This name is safe to use, because it's one that was already created by Next
                 const cacheFile = path_1.default.join(cacheDir, filePath);
-                const url = `${baseUrl}/${staticFiles.get(filePath)}`;
+                const url = `${base}/${staticFiles.get(filePath)}`;
                 // If it's already downloading we can wait for it to finish
                 if (downloadPromises.has(url)) {
                     await downloadPromises.get(url);
                 }
                 // Have we already cached it? We download every time if running locally to avoid staleness
-                if ((!(0, fs_1.existsSync)(cacheFile) || process.env.NETLIFY_DEV) && baseUrl) {
+                if ((!(0, fs_1.existsSync)(cacheFile) || process.env.NETLIFY_DEV) && base) {
                     await promises.mkdir(path_1.default.dirname(cacheFile), { recursive: true });
                     try {
                         // Append the path to our host and we can load it like a regular page
@@ -130,7 +129,7 @@ const augmentFsModule = ({ promises, staticManifest, pageRoot, }) => {
     promises.stat = ((file, options) => {
         // We only care about page files
         if (file.startsWith(pageRoot)) {
-            // We only want the part after `.next/server`
+            // We only want the part after `pages/`
             const cacheFile = path_1.default.join(cacheDir, file.slice(pageRoot.length + 1));
             if ((0, fs_1.existsSync)(cacheFile)) {
                 return statsOrig(cacheFile, options);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/plugin-nextjs",
-  "version": "4.29.3-appdir.0",
+  "version": "4.29.3",
   "description": "Run Next.js seamlessly on Netlify",
   "main": "index.js",
   "files": [
@@ -36,7 +36,7 @@
   },
   "devDependencies": {
     "@delucis/if-env": "^1.1.2",
-    "@netlify/build": "^28.4.4",
+    "@netlify/build": "^28.4.5",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",
     "@types/merge-stream": "^1.1.2",

package/src/templates/edge/next-dev.js

@@ -6,6 +6,17 @@ import { buildResponse } from '../edge-shared/utils.ts'
 globalThis.NFRequestContextMap ||= new Map()
 globalThis.__dirname = fromFileUrl(new URL('./', import.meta.url)).slice(0, -1)
 
+// Next.js uses this extension to the Headers API implemented by Cloudflare workerd
+if (!('getAll' in Headers.prototype)) {
+  Headers.prototype.getAll = function getAll(name) {
+    name = name.toLowerCase()
+    if (name !== 'set-cookie') {
+      throw new Error('Headers.getAll is only supported for Set-Cookie')
+    }
+    return [...this.entries()].filter(([key]) => key === name).map(([, value]) => value)
+  }
+}
+
 // Check if a file exists, given a relative path
 const exists = async (relativePath) => {
   const path = fromFileUrl(new URL(relativePath, import.meta.url))

package/src/templates/edge/runtime.ts

@@ -13,12 +13,6 @@ export interface FetchEventResult {
   waitUntil: Promise<any>
 }
 
-export interface I18NConfig {
-  defaultLocale: string
-  localeDetection?: false
-  locales: string[]
-}
-
 export interface RequestData {
   geo?: {
     city?: string
@@ -33,7 +27,7 @@ export interface RequestData {
   method: string
   nextConfig?: {
     basePath?: string
-    i18n?: I18NConfig | null
+    i18n?: Record<string, unknown>
     trailingSlash?: boolean
   }
   page?: {