@netlify/edge-bundler 14.7.0 → 14.7.2

package/deno/vendor/deno.land/x/eszip@v0.55.2/eszip.ts

@@ -81,6 +81,7 @@ class V2 {
     const imports: Record<string, string> = {};
 
     for (const specifier of this.specifiers) {
+      if (new URL(specifier).protocol !== "file:") continue
       const module = await this.parser.getModuleSource(specifier);
       await write(join(dest, "source", url2path(specifier)), module);
       // Track import
@@ -107,11 +108,8 @@ export async function loadESZIP(filename: string): Promise<ESZIP> {
   return await V1.load(bytes);
 }
 
-function url2path(urlString: string) {
-  const url = new URL(urlString);
-  const tail = url.pathname.split("/").filter(Boolean);
-  const relativePath = tail.length === 0 ? [".root"] : tail;
-  return join(url.hostname, ...relativePath);
+function url2path(url: string) {
+  return join(...(new URL(url).pathname.split("/").filter(Boolean)));
 }
 
 async function write(path: string, content: string) {

package/dist/node/bridge.d.ts

@@ -40,7 +40,13 @@ export declare class DenoBridge {
     versionRange: string;
     constructor(options: DenoOptions);
     private downloadBinary;
-    getBinaryVersion(binaryPath: string): Promise<string | undefined>;
+    getBinaryVersion(binaryPath: string): Promise<{
+        version: string;
+        error?: undefined;
+    } | {
+        version?: undefined;
+        error: Error;
+    }>;
     private getCachedBinary;
     private getGlobalBinary;
     private getRemoteBinary;

package/dist/node/bridge.js

@@ -40,17 +40,27 @@ export class DenoBridge {
         await this.ensureCacheDirectory();
         this.logger.system(`Downloading Deno CLI to ${this.cacheDirectory}`);
         const binaryPath = await download(this.cacheDirectory, this.versionRange, this.logger);
-        const downloadedVersion = await this.getBinaryVersion(binaryPath);
-        // We should never get here, because it means that `DENO_VERSION_RANGE` is
-        // a malformed semver range. If this does happen, let's throw an error so
-        // that the tests catch it.
-        if (downloadedVersion === undefined) {
-            const error = new Error('There was a problem setting up the Edge Functions environment. To try a manual installation, visit https://ntl.fyi/install-deno.');
+        const result = await this.getBinaryVersion(binaryPath);
+        // If we can't execute the downloaded binary, provide actionable info to diagnose and self-heal if possible
+        if (result.error) {
+            const error = new Error(`Failed to set up Deno for Edge Functions.
+Error: ${result.error.message}
+Downloaded to: ${binaryPath}
+Platform: ${process.platform}/${process.arch}
+
+This may be caused by permissions, antivirus software, or platform incompatibility.
+
+Try clearing the Deno cache directory and retrying:
+  ${this.cacheDirectory}
+
+Supported Deno versions: ${this.versionRange}
+
+To install Deno manually: https://ntl.fyi/install-deno`);
             await this.onAfterDownload?.(error);
             this.logger.system('Could not run downloaded Deno CLI', error);
             throw error;
         }
-        await this.writeVersionFile(downloadedVersion);
+        await this.writeVersionFile(result.version);
         await this.onAfterDownload?.();
         return binaryPath;
     }
@@ -60,12 +70,13 @@ export class DenoBridge {
             const version = stdout.match(/^deno ([\d.]+)/);
             if (!version) {
                 this.logger.system(`getBinaryVersion no version found. binaryPath ${binaryPath}`);
-                return;
+                return { error: new Error('Could not parse Deno version from output') };
             }
-            return version[1];
+            return { version: version[1] };
         }
         catch (error) {
             this.logger.system('getBinaryVersion failed', error);
+            return { error: error instanceof Error ? error : new Error(String(error)) };
         }
     }
     async getCachedBinary() {
@@ -90,9 +101,9 @@ export class DenoBridge {
             return;
         }
         const globalBinaryName = 'deno';
-        const globalVersion = await this.getBinaryVersion(globalBinaryName);
-        if (globalVersion === undefined || !semver.satisfies(globalVersion, this.versionRange)) {
-            this.logger.system(`No globalVersion or semver not satisfied. globalVersion: ${globalVersion}, versionRange: ${this.versionRange}`);
+        const result = await this.getBinaryVersion(globalBinaryName);
+        if (result.error || !semver.satisfies(result.version, this.versionRange)) {
+            this.logger.system(`No globalVersion or semver not satisfied. globalVersion: ${result.version}, versionRange: ${this.versionRange}`);
             return;
         }
         return globalBinaryName;

package/dist/node/bridge.test.js

@@ -101,3 +101,41 @@ test('Does inherit environment variables if `extendEnv` is not set', async () =>
     expect(environmentVariables).toEqual(['LULU=LALA', 'TADA=TUDU']);
     await rm(tmpDir.path, { force: true, recursive: true, maxRetries: 10 });
 });
+test('Provides actionable error message when downloaded binary cannot be executed', async () => {
+    const tmpDir = await tmp.dir();
+    const latestVersion = semver.minVersion(DENO_VERSION_RANGE)?.version ?? '';
+    const data = new PassThrough();
+    const archive = archiver('zip', { zlib: { level: 9 } });
+    archive.pipe(data);
+    // Create a binary that will fail to execute (invalid content)
+    archive.append(Buffer.from('invalid binary content'), {
+        name: platform === 'win32' ? 'deno.exe' : 'deno',
+    });
+    archive.finalize();
+    const target = getPlatformTarget();
+    nock('https://dl.deno.land').get('/release-latest.txt').reply(200, `v${latestVersion}`);
+    nock('https://dl.deno.land')
+        .get(`/release/v${latestVersion}/deno-${target}.zip`)
+        .reply(200, () => data);
+    const deno = new DenoBridge({
+        cacheDirectory: tmpDir.path,
+        useGlobal: false,
+    });
+    try {
+        await deno.getBinaryPath();
+        expect.fail('Should have thrown an error');
+    }
+    catch (error) {
+        expect(error).toBeInstanceOf(Error);
+        const errorMessage = error.message;
+        expect(errorMessage).toContain('Failed to set up Deno for Edge Functions');
+        expect(errorMessage).toMatch(/Error:/);
+        expect(errorMessage).toMatch(/Downloaded to: .+deno(\.exe)?/);
+        expect(errorMessage).toContain(tmpDir.path);
+        expect(errorMessage).toMatch(/Platform: (darwin|linux|win32)\/(x64|arm64|ia32)/);
+        expect(errorMessage).toContain('This may be caused by permissions, antivirus software, or platform incompatibility');
+        expect(errorMessage).toContain('Try clearing the Deno cache directory and retrying');
+        expect(errorMessage).toContain('https://ntl.fyi/install-deno');
+    }
+    await rm(tmpDir.path, { force: true, recursive: true, maxRetries: 10 });
+});

package/dist/node/bundler.js

@@ -17,6 +17,7 @@ import { writeManifest } from './manifest.js';
 import { vendorNPMSpecifiers } from './npm_dependencies.js';
 import { ensureLatestTypes } from './types.js';
 import { nonNullable } from './utils/non_nullable.js';
+import { BundleError } from './bundle_error.js';
 export const bundle = async (sourceDirectories, distDirectory, tomlDeclarations = [], { basePath: inputBasePath, cacheDirectory, configPath, debug, distImportMapPath, featureFlags: inputFeatureFlags, importMapPaths = [], internalSrcFolder, onAfterDownload, onBeforeDownload, rootPath, userLogger, systemLogger, vendorDirectory, } = {}) => {
     const logger = getLogger(systemLogger, userLogger, debug);
     const featureFlags = getFlags(inputFeatureFlags);
@@ -144,22 +145,27 @@ const getFunctionConfigs = async ({ basePath, deno, eszipPath, featureFlags, imp
         if (!(err instanceof Error && err.cause === 'IMPORT_ASSERT') || !eszipPath || !featureFlags?.edge_bundler_deno_v2) {
             throw err;
         }
-        // We failed to extract the configuration because there is an import assert
-        // in the function code, a deprecated feature that we used to support with
-        // Deno 1.x. To avoid a breaking change, we treat this error as a special
-        // case, using the generated ESZIP to extract the configuration. This works
-        // because import asserts are transpiled to import attributes.
-        const extractedESZIP = await extractESZIP(deno, eszipPath);
-        const configs = await Promise.all([...internalFunctions, ...userFunctions].map(async (func) => {
-            const relativePath = relative(basePath, func.path);
-            const functionPath = join(extractedESZIP.path, relativePath);
-            return [func.name, await getFunctionConfig({ functionPath, importMap, deno, log })];
-        }));
-        await extractedESZIP.cleanup();
-        return {
-            internalFunctions: Object.fromEntries(configs.slice(0, internalFunctions.length)),
-            userFunctions: Object.fromEntries(configs.slice(internalFunctions.length)),
-        };
+        try {
+            // We failed to extract the configuration because there is an import assert
+            // in the function code, a deprecated feature that we used to support with
+            // Deno 1.x. To avoid a breaking change, we treat this error as a special
+            // case, using the generated ESZIP to extract the configuration. This works
+            // because import asserts are transpiled to import attributes.
+            const extractedESZIP = await extractESZIP(deno, eszipPath);
+            const configs = await Promise.all([...internalFunctions, ...userFunctions].map(async (func) => {
+                const relativePath = relative(basePath, func.path);
+                const functionPath = join(extractedESZIP.path, relativePath);
+                return [func.name, await getFunctionConfig({ functionPath, importMap, deno, log })];
+            }));
+            await extractedESZIP.cleanup();
+            return {
+                internalFunctions: Object.fromEntries(configs.slice(0, internalFunctions.length)),
+                userFunctions: Object.fromEntries(configs.slice(internalFunctions.length)),
+            };
+        }
+        catch (err) {
+            throw new BundleError(new Error('An error occurred while building an edge function that uses an import assertion. Refer to https://ntl.fyi/import-assert for more information.'), { cause: err });
+        }
     }
 };
 const createFinalBundles = async (bundles, distDirectory, buildID) => {

package/dist/node/config.js

@@ -38,7 +38,8 @@ export const getFunctionConfig = async ({ deno, functionPath, importMap, log, })
     // with the extractor.
     const collector = await tmp.file();
     // Retrieving the version of Deno.
-    const version = new SemVer((await deno.getBinaryVersion((await deno.getBinaryPath({ silent: true })).path)) || '');
+    const result = await deno.getBinaryVersion((await deno.getBinaryPath({ silent: true })).path);
+    const version = new SemVer(result.version || '');
     // The extractor will use its exit code to signal different error scenarios,
     // based on the list of exit codes we send as an argument. We then capture
     // the exit code to know exactly what happened and guide people accordingly.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/edge-bundler",
-  "version": "14.7.0",
+  "version": "14.7.2",
   "description": "Intelligently prepare Netlify Edge Functions for deployment",
   "type": "module",
   "main": "./dist/node/index.js",
@@ -80,5 +80,5 @@
     "urlpattern-polyfill": "8.0.2",
     "uuid": "^11.0.0"
   },
-  "gitHead": "ff114da3f2bcb5bea83bb4a3747201192aecfec0"
+  "gitHead": "1cf876ef6b79ef8332044a3e32db846652be9f23"
 }