@netlify/edge-bundler 11.0.0 → 11.2.0

package/dist/node/bridge.d.ts

@@ -1,4 +1,6 @@
 /// <reference types="node" />
+/// <reference types="node" />
+import { type WriteStream } from 'fs';
 import { ExecaChildProcess } from 'execa';
 import { Logger } from './logger.js';
 declare const DENO_VERSION_RANGE = "^1.37.0";
@@ -18,9 +20,11 @@ interface ProcessRef {
     ps?: ExecaChildProcess<string>;
 }
 interface RunOptions {
-    pipeOutput?: boolean;
     env?: NodeJS.ProcessEnv;
     extendEnv?: boolean;
+    pipeOutput?: boolean;
+    stderr?: WriteStream;
+    stdout?: WriteStream;
     rejectOnExitCode?: boolean;
 }
 declare class DenoBridge {
@@ -47,8 +51,8 @@ declare class DenoBridge {
         path: string;
     }>;
     getEnvironmentVariables(inputEnv?: NodeJS.ProcessEnv): NodeJS.ProcessEnv;
-    run(args: string[], { pipeOutput, env: inputEnv, extendEnv, rejectOnExitCode }?: RunOptions): Promise<import("execa").ExecaReturnValue<string>>;
-    runInBackground(args: string[], ref?: ProcessRef, { pipeOutput, env: inputEnv, extendEnv }?: RunOptions): Promise<void>;
+    run(args: string[], { env: inputEnv, extendEnv, rejectOnExitCode, stderr, stdout }?: RunOptions): Promise<import("execa").ExecaReturnValue<string>>;
+    runInBackground(args: string[], ref?: ProcessRef, { env: inputEnv, extendEnv, stderr, stdout }?: RunOptions): Promise<void>;
 }
 export { DENO_VERSION_RANGE, DenoBridge };
 export type { DenoOptions, OnAfterDownloadHook, OnBeforeDownloadHook, ProcessRef };

package/dist/node/bridge.js

@@ -93,13 +93,21 @@ class DenoBridge {
         }
         return this.currentDownload;
     }
-    static runWithBinary(binaryPath, args, options, pipeOutput) {
-        var _a, _b;
+    static runWithBinary(binaryPath, args, { options, pipeOutput, stderr, stdout, }) {
+        var _a, _b, _c, _d;
         const runDeno = execa(binaryPath, args, options);
-        if (pipeOutput) {
-            (_a = runDeno.stdout) === null || _a === void 0 ? void 0 : _a.pipe(process.stdout);
+        if (stderr) {
+            (_a = runDeno.stderr) === null || _a === void 0 ? void 0 : _a.pipe(stderr);
+        }
+        else if (pipeOutput) {
             (_b = runDeno.stderr) === null || _b === void 0 ? void 0 : _b.pipe(process.stderr);
         }
+        if (stdout) {
+            (_c = runDeno.stdout) === null || _c === void 0 ? void 0 : _c.pipe(stdout);
+        }
+        else if (pipeOutput) {
+            (_d = runDeno.stdout) === null || _d === void 0 ? void 0 : _d.pipe(process.stdout);
+        }
         return runDeno;
     }
     async writeVersionFile(version) {
@@ -135,19 +143,19 @@ class DenoBridge {
     }
     // Runs the Deno CLI in the background and returns a reference to the child
     // process, awaiting its execution.
-    async run(args, { pipeOutput, env: inputEnv, extendEnv = true, rejectOnExitCode = true } = {}) {
+    async run(args, { env: inputEnv, extendEnv = true, rejectOnExitCode = true, stderr, stdout } = {}) {
         const { path: binaryPath } = await this.getBinaryPath();
         const env = this.getEnvironmentVariables(inputEnv);
         const options = { env, extendEnv, reject: rejectOnExitCode };
-        return DenoBridge.runWithBinary(binaryPath, args, options, pipeOutput);
+        return DenoBridge.runWithBinary(binaryPath, args, { options, stderr, stdout });
     }
     // Runs the Deno CLI in the background, assigning a reference of the child
     // process to a `ps` property in the `ref` argument, if one is supplied.
-    async runInBackground(args, ref, { pipeOutput, env: inputEnv, extendEnv = true } = {}) {
+    async runInBackground(args, ref, { env: inputEnv, extendEnv = true, stderr, stdout } = {}) {
         const { path: binaryPath } = await this.getBinaryPath();
         const env = this.getEnvironmentVariables(inputEnv);
         const options = { env, extendEnv };
-        const ps = DenoBridge.runWithBinary(binaryPath, args, options, pipeOutput);
+        const ps = DenoBridge.runWithBinary(binaryPath, args, { options, stderr, stdout });
         if (ref !== undefined) {
             // eslint-disable-next-line no-param-reassign
             ref.ps = ps;

package/dist/node/feature_flags.d.ts

@@ -1,6 +1,10 @@
-declare const defaultFlags: {};
+declare const defaultFlags: {
+    edge_bundler_pcre_regexp: boolean;
+};
 type FeatureFlag = keyof typeof defaultFlags;
 type FeatureFlags = Partial<Record<FeatureFlag, boolean>>;
-declare const getFlags: (input?: Record<string, boolean>, flags?: {}) => FeatureFlags;
+declare const getFlags: (input?: Record<string, boolean>, flags?: {
+    edge_bundler_pcre_regexp: boolean;
+}) => FeatureFlags;
 export { defaultFlags, getFlags };
 export type { FeatureFlag, FeatureFlags };

package/dist/node/feature_flags.js

@@ -1,4 +1,6 @@
-const defaultFlags = {};
+const defaultFlags = {
+    edge_bundler_pcre_regexp: false,
+};
 const getFlags = (input = {}, flags = defaultFlags) => Object.entries(flags).reduce((result, [key, defaultValue]) => ({
     ...result,
     [key]: input[key] === undefined ? defaultValue : input[key],

package/dist/node/manifest.d.ts

@@ -42,7 +42,7 @@ interface GenerateManifestOptions {
     layers?: Layer[];
     userFunctionConfig?: Record<string, FunctionConfig>;
 }
-declare const generateManifest: ({ bundles, declarations, functions, userFunctionConfig, internalFunctionConfig, importMap, layers, }: GenerateManifestOptions) => {
+declare const generateManifest: ({ bundles, declarations, featureFlags, functions, userFunctionConfig, internalFunctionConfig, importMap, layers, }: GenerateManifestOptions) => {
     declarationsWithoutFunction: string[];
     manifest: Manifest;
     unroutedFunctions: string[];

package/dist/node/manifest.js

@@ -46,7 +46,7 @@ const normalizeMethods = (method, name) => {
         return method.toUpperCase();
     });
 };
-const generateManifest = ({ bundles = [], declarations = [], functions, userFunctionConfig = {}, internalFunctionConfig = {}, importMap, layers = [], }) => {
+const generateManifest = ({ bundles = [], declarations = [], featureFlags, functions, userFunctionConfig = {}, internalFunctionConfig = {}, importMap, layers = [], }) => {
     const preCacheRoutes = [];
     const postCacheRoutes = [];
     const manifestFunctionConfig = Object.fromEntries(functions.map(({ name }) => [name, { excluded_patterns: [] }]));
@@ -74,14 +74,14 @@ const generateManifest = ({ bundles = [], declarations = [], functions, userFunc
             declarationsWithoutFunction.add(declaration.function);
             return;
         }
-        const pattern = getRegularExpression(declaration);
+        const pattern = getRegularExpression(declaration, Boolean(featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.edge_bundler_pcre_regexp));
         // If there is no `pattern`, the declaration will never be triggered, so we
         // can discard it.
         if (!pattern) {
             return;
         }
         routedFunctions.add(declaration.function);
-        const excludedPattern = getExcludedRegularExpressions(declaration);
+        const excludedPattern = getExcludedRegularExpressions(declaration, Boolean(featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.edge_bundler_pcre_regexp));
         const route = {
             function: func.name,
             pattern: serializePattern(pattern),
@@ -135,8 +135,11 @@ const pathToRegularExpression = (path) => {
         throw wrapBundleError(error);
     }
 };
-const getRegularExpression = (declaration) => {
+const getRegularExpression = (declaration, pcreRegexpEngine) => {
     if ('pattern' in declaration) {
+        if (pcreRegexpEngine) {
+            return declaration.pattern;
+        }
         try {
             return parsePattern(declaration.pattern);
         }
@@ -146,11 +149,14 @@ const getRegularExpression = (declaration) => {
     }
     return pathToRegularExpression(declaration.path);
 };
-const getExcludedRegularExpressions = (declaration) => {
+const getExcludedRegularExpressions = (declaration, pcreRegexpEngine) => {
     if ('excludedPattern' in declaration && declaration.excludedPattern) {
         const excludedPatterns = Array.isArray(declaration.excludedPattern)
             ? declaration.excludedPattern
             : [declaration.excludedPattern];
+        if (pcreRegexpEngine) {
+            return excludedPatterns;
+        }
         return excludedPatterns.map((excludedPattern) => {
             try {
                 return parsePattern(excludedPattern);

package/dist/node/manifest.test.js

@@ -386,15 +386,29 @@ test('Generates a manifest with layers', () => {
     expect(manifest2.routes).toEqual(expectedRoutes);
     expect(manifest2.layers).toEqual(layers);
 });
-test('Throws an error if the regular expression contains a negative lookahead', () => {
+test('Throws an error if the regular expression contains a negative lookahead and support for the PCRE engine is disabled', () => {
     const functions = [{ name: 'func-1', path: '/path/to/func-1.ts' }];
-    const declarations = [{ function: 'func-1', pattern: '^/\\w+(?=\\d)$' }];
+    const declarations = [{ function: 'func-1', pattern: '^\\/((?!api|_next\\/static|_next\\/image|favicon.ico).*)$' }];
     expect(() => generateManifest({
         bundles: [],
         declarations,
         functions,
     })).toThrowError(/^Could not parse path declaration of function 'func-1': Regular expressions with lookaheads are not supported$/);
 });
+test('Accepts regular expressions with lookaheads if support for the PCRE engine is enabled', () => {
+    const functions = [{ name: 'func-1', path: '/path/to/func-1.ts' }];
+    const declarations = [{ function: 'func-1', pattern: '^\\/((?!api|_next\\/static|_next\\/image|favicon.ico).*)$' }];
+    const { manifest } = generateManifest({
+        bundles: [],
+        declarations,
+        featureFlags: { edge_bundler_pcre_regexp: true },
+        functions,
+    });
+    const [route] = manifest.routes;
+    const regexp = new RegExp(route.pattern);
+    expect(regexp.test('/foo')).toBeTruthy();
+    expect(regexp.test('/_next/static/foo')).toBeFalsy();
+});
 test('Converts named capture groups to unnamed capture groups in regular expressions', () => {
     const functions = [{ name: 'func-1', path: '/path/to/func-1.ts' }];
     const declarations = [{ function: 'func-1', pattern: '^/(?<name>\\w+)$' }];

package/dist/node/server/server.d.ts

@@ -3,6 +3,8 @@
 /// <reference types="node" />
 /// <reference types="node" />
 /// <reference types="node" />
+/// <reference types="node" />
+import type { WriteStream } from 'fs';
 import { OnAfterDownloadHook, OnBeforeDownloadHook } from '../bridge.js';
 import { FunctionConfig } from '../config.js';
 import type { EdgeFunction } from '../edge_function.js';
@@ -34,10 +36,12 @@ interface ServeOptions {
     port: number;
     rootPath?: string;
     servePath: string;
+    stderr?: WriteStream;
+    stdout?: WriteStream;
     userLogger?: LogFunction;
     systemLogger?: LogFunction;
 }
-export declare const serve: ({ basePath, bootstrapURL, certificatePath, debug, distImportMapPath, inspectSettings, featureFlags, formatExportTypeError, formatImportError, onAfterDownload, onBeforeDownload, port, rootPath, servePath, userLogger, systemLogger, }: ServeOptions) => Promise<(functions: EdgeFunction[], env?: NodeJS.ProcessEnv, options?: StartServerOptions) => Promise<{
+export declare const serve: ({ basePath, bootstrapURL, certificatePath, debug, distImportMapPath, inspectSettings, featureFlags, formatExportTypeError, formatImportError, onAfterDownload, onBeforeDownload, port, rootPath, servePath, stderr, stdout, userLogger, systemLogger, }: ServeOptions) => Promise<(functions: EdgeFunction[], env?: NodeJS.ProcessEnv, options?: StartServerOptions) => Promise<{
     features: Record<string, boolean>;
     functionsConfig: FunctionConfig[];
     graph: ModuleGraphJson;

package/dist/node/server/server.js

@@ -18,7 +18,7 @@ const cleanDirectory = async (directory, except) => {
     const toBeDeleted = files.filter((file) => !except.includes(join(directory, file)));
     await Promise.all(toBeDeleted.map((file) => unlink(join(directory, file))));
 };
-const prepareServer = ({ basePath, bootstrapURL, deno, distDirectory, distImportMapPath, flags: denoFlags, formatExportTypeError, formatImportError, logger, port, rootPath, }) => {
+const prepareServer = ({ basePath, bootstrapURL, deno, distDirectory, distImportMapPath, flags: denoFlags, formatExportTypeError, formatImportError, logger, port, rootPath, stderr, stdout, }) => {
     const processRef = {};
     const startServer = async (functions, env = {}, options = {}) => {
         var _a;
@@ -77,9 +77,11 @@ const prepareServer = ({ basePath, bootstrapURL, deno, distDirectory, distImport
         // with variables from the user's system, since those will not be available
         // in the production environment.
         await deno.runInBackground(['run', ...denoFlags, ...extraDenoFlags, stage2Path, ...applicationFlags], processRef, {
-            pipeOutput: true,
             env,
             extendEnv: false,
+            pipeOutput: true,
+            stderr,
+            stdout,
         });
         let functionsConfig = [];
         if (options.getFunctionsConfig) {
@@ -165,6 +167,16 @@ rootPath,
  * operate.
  */
 servePath, 
+/**
+ * Writable stream to receive the stderr of the server process. If not set,
+ * the stderr of the parent process will be used.
+ */
+stderr, 
+/**
+ * Writable stream to receive the stdout of the server process. If not set,
+ * the stdout of the parent process will be used.
+ */
+stdout, 
 /**
  * Custom logging function to be used for user-facing messages. Defaults to
  * `console.log`.
@@ -214,6 +226,8 @@ systemLogger, }) => {
         formatExportTypeError,
         formatImportError,
         logger,
+        stderr,
+        stdout,
         port,
         rootPath,
     });

package/dist/node/server/server.test.js

@@ -1,8 +1,10 @@
+import { createWriteStream } from 'fs';
 import { readFile } from 'fs/promises';
 import { join } from 'path';
 import process from 'process';
 import getPort from 'get-port';
 import fetch from 'node-fetch';
+import tmp from 'tmp-promise';
 import { v4 as uuidv4 } from 'uuid';
 import { test, expect } from 'vitest';
 import { fixturesDir } from '../../test/util.js';
@@ -86,6 +88,8 @@ test('Starts a server and serves requests for edge functions', async () => {
     expect(identidadeBarrelFile).toContain(`/// <reference types="${join('..', '..', 'node_modules', '@types', 'pt-committee__identidade', 'index.d.ts')}" />`);
 });
 test('Serves edge functions in a monorepo setup', async () => {
+    const tmpFile = await tmp.file();
+    const stderr = createWriteStream(tmpFile.path);
     const rootPath = join(fixturesDir, 'monorepo_npm_module');
     const basePath = join(rootPath, 'packages', 'frontend');
     const paths = {
@@ -100,6 +104,7 @@ test('Serves edge functions in a monorepo setup', async () => {
         port,
         rootPath,
         servePath,
+        stderr,
     });
     const functions = [
         {
@@ -131,4 +136,6 @@ test('Serves edge functions in a monorepo setup', async () => {
     });
     expect(response1.status).toBe(200);
     expect(await response1.text()).toBe(`<parent-1><child-1>JavaScript</child-1></parent-1>, <parent-2><child-2><grandchild-1>APIs<cwd>${process.cwd()}</cwd></grandchild-1></child-2></parent-2>, <parent-3><child-2><grandchild-1>Markup<cwd>${process.cwd()}</cwd></grandchild-1></child-2></parent-3>`);
+    expect(await readFile(tmpFile.path, 'utf8')).toContain('[func1] Something is on fire');
+    await tmpFile.cleanup();
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/edge-bundler",
-  "version": "11.0.0",
+  "version": "11.2.0",
   "description": "Intelligently prepare Netlify Edge Functions for deployment",
   "type": "module",
   "main": "./dist/node/index.js",
@@ -75,13 +75,13 @@
   },
   "dependencies": {
     "@import-maps/resolve": "^1.0.1",
-    "@vercel/nft": "^0.24.3",
+    "@vercel/nft": "^0.26.0",
     "ajv": "^8.11.2",
     "ajv-errors": "^3.0.0",
     "better-ajv-errors": "^1.2.0",
     "common-path-prefix": "^3.0.0",
     "env-paths": "^3.0.0",
-    "esbuild": "0.19.9",
+    "esbuild": "0.19.11",
     "execa": "^6.0.0",
     "find-up": "^6.3.0",
     "get-package-name": "^2.2.0",