@netlify/build 29.5.4 → 29.5.5

package/lib/error/handle.js

@@ -1,13 +1,12 @@
 import { cwd as getCwd } from 'process';
 import { pathExists } from 'path-exists';
 import { logBuildError } from '../log/messages/core.js';
-import { logOldCliVersionError } from '../log/old_version.js';
 import { removeErrorColors } from './colors.js';
 import { getErrorInfo } from './info.js';
 import { reportBuildError } from './monitor/report.js';
 import { parseErrorInfo } from './parse/parse.js';
 // Logs and reports a build failure
-export const handleBuildError = async function (error, { errorMonitor, netlifyConfig, childEnv, mode, logs, debug, testOpts }) {
+export const handleBuildError = async function (error, { errorMonitor, netlifyConfig, childEnv, logs, debug, testOpts }) {
     const basicErrorInfo = parseErrorInfo(error);
     if (await isCancelCrash(error)) {
         return basicErrorInfo;
@@ -15,9 +14,8 @@ export const handleBuildError = async function (error, { errorMonitor, netlifyCo
     removeErrorColors(error);
     // Some errors, such as telemetry ones, should not be logged
     if (basicErrorInfo.showInBuildLog) {
-        logBuildError({ error, netlifyConfig, mode, logs, debug, testOpts });
+        logBuildError({ error, netlifyConfig, logs, debug });
     }
-    logOldCliVersionError({ mode, testOpts });
     await reportBuildError({ error, errorMonitor, childEnv, logs, testOpts });
     return basicErrorInfo;
 };

package/lib/log/messages/compatibility.js

@@ -29,7 +29,7 @@ const isNotCorePlugin = function ({ origin }) {
     return origin !== 'core';
 };
 const getPluginDescription = function ({ packageName, pluginPackageJson: { version }, loadedFrom, origin, pinnedVersion, latestVersion, expectedVersion, compatibleVersion, }, debug) {
-    const versionedPackage = getVersionedPackage(packageName, version);
+    const versionedPackage = getVersionedPackage(version);
     const pluginOrigin = getPluginOrigin(loadedFrom, origin);
     const description = `${THEME.highlightWords(packageName)}${versionedPackage} ${pluginOrigin}`;
     if (!debug) {
@@ -68,7 +68,7 @@ const hasOutdatedVersion = function ({ pluginPackageJson: { version }, latestVer
     return version !== undefined && latestVersion !== undefined && semver.lt(version, latestVersion);
 };
 const getOutdatedPlugin = function ({ packageName, pluginPackageJson: { version }, latestVersion, migrationGuide, loadedFrom, origin, }) {
-    const versionedPackage = getVersionedPackage(packageName, version);
+    const versionedPackage = getVersionedPackage(version);
     const outdatedDescription = getOutdatedDescription({ latestVersion, migrationGuide, loadedFrom, origin });
     return `${THEME.warningHighlightWords(packageName)}${versionedPackage}: ${outdatedDescription}`;
 };
@@ -110,11 +110,11 @@ const hasIncompatibleVersion = function ({ pluginPackageJson: { version }, compa
         isPreviousMajor(compatibleVersion, version));
 };
 const getIncompatiblePlugin = function ({ packageName, pluginPackageJson: { version }, compatibleVersion, compatWarning, }) {
-    const versionedPackage = getVersionedPackage(packageName, version);
+    const versionedPackage = getVersionedPackage(version);
     return `${THEME.warningHighlightWords(packageName)}${versionedPackage}: version ${compatibleVersion} is the most recent version compatible with ${compatWarning}`;
 };
 // Make sure we handle `package.json` with `version` being either `undefined`
 // or an empty string
-const getVersionedPackage = function (packageName, version = '') {
+const getVersionedPackage = function (version = '') {
     return version === '' ? '' : `@${version}`;
 };

package/lib/log/messages/core.js

@@ -6,7 +6,6 @@ import { roundTimerToMillisecs } from '../../time/measure.js';
 import { ROOT_PACKAGE_JSON } from '../../utils/json.js';
 import { getLogHeaderFunc } from '../header_func.js';
 import { log, logMessage, logWarning, logHeader, logSubHeader, logWarningArray } from '../logger.js';
-import { logOldCliVersionError } from '../old_version.js';
 import { THEME } from '../theme.js';
 import { logConfigOnError } from './config.js';
 export const logBuildStart = function (logs) {
@@ -14,7 +13,7 @@ export const logBuildStart = function (logs) {
     logSubHeader(logs, 'Version');
     logMessage(logs, `${ROOT_PACKAGE_JSON.name} ${ROOT_PACKAGE_JSON.version}`);
 };
-export const logBuildError = function ({ error, netlifyConfig, mode, logs, debug, testOpts }) {
+export const logBuildError = function ({ error, netlifyConfig, logs, debug }) {
     const fullErrorInfo = getFullErrorInfo({ error, colors: true, debug });
     const { severity } = fullErrorInfo;
     const { title, body } = serializeLogError({ fullErrorInfo });
@@ -22,7 +21,6 @@ export const logBuildError = function ({ error, netlifyConfig, mode, logs, debug
     logHeaderFunc(logs, title);
     logMessage(logs, `\n${body}\n`);
     logConfigOnError({ logs, netlifyConfig, severity });
-    logOldCliVersionError({ mode, testOpts });
 };
 export const logBuildSuccess = function (logs) {
     logHeader(logs, 'Netlify Build Complete');

package/lib/plugins/options.js

@@ -46,7 +46,7 @@ const loadPluginFiles = async function ({ pluginOptions, pluginOptions: { plugin
 // Core plugins can only be included once.
 // For example, when testing core plugins, they might be included as local plugins,
 // in which case they should not be included twice.
-const isNotRedundantCorePlugin = function (pluginOptionsA, index, pluginsOptions) {
+const isNotRedundantCorePlugin = function (pluginOptionsA, _index, pluginsOptions) {
     return (pluginOptionsA.loadedFrom !== 'core' ||
         pluginsOptions.every((pluginOptionsB) => pluginOptionsA.manifest.name !== pluginOptionsB.manifest.name || pluginOptionsA === pluginOptionsB));
 };

package/lib/utils/json.js

@@ -1,15 +1,10 @@
-import { promises as fs, readFileSync } from 'fs';
+import { readFile } from 'fs/promises';
 import { fileURLToPath } from 'url';
 const ROOT_PACKAGE_JSON_PATH = fileURLToPath(new URL('../../package.json', import.meta.url));
 // TODO: Replace with dynamic `import()` once it is supported without
 // experimental flags
 export const importJsonFile = async function (filePath) {
-    const fileContents = await fs.readFile(filePath, 'utf-8');
+    const fileContents = await readFile(filePath, 'utf-8');
     return JSON.parse(fileContents);
 };
-const importJsonFileSync = function (filePath) {
-    // Use sync I/O so it is easier to migrate to `import()` later on
-    const fileContents = readFileSync(filePath, 'utf-8');
-    return JSON.parse(fileContents);
-};
-export const ROOT_PACKAGE_JSON = importJsonFileSync(ROOT_PACKAGE_JSON_PATH);
+export const ROOT_PACKAGE_JSON = (await importJsonFile(ROOT_PACKAGE_JSON_PATH));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "29.5.4",
+  "version": "29.5.5",
   "description": "Netlify build module",
   "type": "module",
   "exports": "./lib/core/main.js",
@@ -64,12 +64,12 @@
   "license": "MIT",
   "dependencies": {
     "@bugsnag/js": "^7.0.0",
-    "@netlify/cache-utils": "^5.1.1",
-    "@netlify/config": "^20.3.2",
+    "@netlify/cache-utils": "^5.1.2",
+    "@netlify/config": "^20.3.3",
     "@netlify/edge-bundler": "8.4.0",
-    "@netlify/functions-utils": "^5.1.6",
+    "@netlify/functions-utils": "^5.1.7",
     "@netlify/git-utils": "^5.1.0",
-    "@netlify/plugins-list": "^6.61.0",
+    "@netlify/plugins-list": "^6.65.0",
     "@netlify/run-utils": "^5.1.0",
     "@netlify/zip-it-and-ship-it": "^8.5.0",
     "@sindresorhus/slugify": "^2.0.0",
@@ -113,12 +113,11 @@
     "tmp-promise": "^3.0.2",
     "ts-node": "^10.6.0",
     "typescript": "^4.8.4",
-    "update-notifier": "^5.0.0",
     "uuid": "^8.0.0",
     "yargs": "^17.6.0"
   },
   "devDependencies": {
-    "@netlify/nock-udp": "^3.1.1",
+    "@netlify/nock-udp": "^3.1.2",
     "@types/node": "^14.18.31",
     "atob": "^2.1.2",
     "ava": "^4.0.0",
@@ -132,7 +131,6 @@
     "get-port": "^6.0.0",
     "get-stream": "^6.0.0",
     "has-ansi": "^5.0.0",
-    "is-ci": "^3.0.0",
     "moize": "^6.0.0",
     "path-key": "^4.0.0",
     "process-exists": "^5.0.0",
@@ -148,5 +146,5 @@
       "module": "commonjs"
     }
   },
-  "gitHead": "356667c6173362b294f9037efdb7b5ef1c726d48"
+  "gitHead": "d78a65c209ed987d3475cd1f37cf357693b99e3c"
 }

package/lib/log/old_version.js

@@ -1,32 +0,0 @@
-import { stdout } from 'process';
-import UpdateNotifier from 'update-notifier';
-import { ROOT_PACKAGE_JSON } from '../utils/json.js';
-// Many build errors happen in local builds that do not use the latest version
-// of `@netlify/build`. We print a warning message on those.
-// We only print this when Netlify CLI has been used. Programmatic usage might
-// come from a deep dependency calling `@netlify/build` and user might not be
-// able to take any upgrade action, making the message noisy.
-export const logOldCliVersionError = function ({ mode, testOpts }) {
-    if (mode !== 'cli') {
-        return;
-    }
-    const corePackageJson = getCorePackageJson(testOpts);
-    UpdateNotifier({ pkg: corePackageJson, updateCheckInterval: 1 }).notify({
-        message: OLD_VERSION_MESSAGE,
-        shouldNotifyInNpmScript: true,
-    });
-};
-const getCorePackageJson = function (testOpts) {
-    // TODO: Find a way to test this without injecting code in the `src/`
-    if (testOpts.oldCliLogs) {
-        // `update-notifier` does not do anything if not in a TTY.
-        // In tests, we need to monkey patch this
-        // Mutation is required due to how `stdout.isTTY` works
-        stdout.isTTY = true;
-        return { ...ROOT_PACKAGE_JSON, version: '0.0.1' };
-    }
-    return ROOT_PACKAGE_JSON;
-};
-const OLD_VERSION_MESSAGE = `Please update netlify-cli to its latest version.
-If netlify-cli is already the latest version,
-please update your dependencies lock file instead.`;