@netlify/build 29.33.4 → 29.33.5

package/lib/core/build.js

@@ -274,6 +274,7 @@ const initAndRunBuild = async function ({ pluginsOptions, netlifyConfig, configO
         featureFlags,
         integrations,
         context,
+        systemLog,
     });
     errorParams.pluginsOptions = pluginsOptionsA;
     const { childProcesses, timers: timersB } = await startPlugins({

package/lib/plugins/node_version.d.ts

@@ -14,10 +14,11 @@ export type PluginsOptions = {
  * usually the system's Node.js version.
  * If the user Node version does not satisfy our supported engine range use our own system Node version
  */
-export declare const addPluginsNodeVersion: ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs }: {
+export declare const addPluginsNodeVersion: ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs, systemLog, }: {
     featureFlags: any;
     pluginsOptions: any;
     nodePath: any;
     userNodeVersion: any;
     logs: any;
-}) => any;
+    systemLog: any;
+}) => Promise<any[]>;

package/lib/plugins/node_version.js

@@ -1,7 +1,9 @@
+import { dirname } from 'path';
 import { execPath, version as currentVersion } from 'process';
 import semver from 'semver';
 import link from 'terminal-link';
 import { logWarning, logWarningSubHeader } from '../log/logger.js';
+import { getPackageJson } from '../utils/package.js';
 /**
  * This node version is minimum required to run the plugins code.
  * If the users preferred Node.js version is below that we have to fall back to the system node version
@@ -15,11 +17,19 @@ const UPCOMING_MINIMUM_REQUIRED_NODE_VERSION = '>=18.14.0';
  * usually the system's Node.js version.
  * If the user Node version does not satisfy our supported engine range use our own system Node version
  */
-export const addPluginsNodeVersion = function ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs }) {
+export const addPluginsNodeVersion = function ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs, systemLog, }) {
     const currentNodeVersion = semver.clean(currentVersion);
-    return pluginsOptions.map((pluginOptions) => addPluginNodeVersion({ featureFlags, pluginOptions, currentNodeVersion, userNodeVersion, nodePath, logs }));
+    return Promise.all(pluginsOptions.map((pluginOptions) => addPluginNodeVersion({
+        featureFlags,
+        pluginOptions,
+        currentNodeVersion,
+        userNodeVersion,
+        nodePath,
+        logs,
+        systemLog,
+    })));
 };
-const addPluginNodeVersion = function ({ featureFlags, pluginOptions, pluginOptions: { loadedFrom, packageName }, currentNodeVersion, userNodeVersion, nodePath, logs, }) {
+const addPluginNodeVersion = async function ({ featureFlags, pluginOptions, pluginOptions: { loadedFrom, packageName, pluginPath }, currentNodeVersion, userNodeVersion, nodePath, logs, systemLog, }) {
     const systemNode = { ...pluginOptions, nodePath: execPath, nodeVersion: currentNodeVersion };
     const userNode = { ...pluginOptions, nodePath, nodeVersion: userNodeVersion };
     const isLocalPlugin = loadedFrom === 'local' || loadedFrom === 'package.json';
@@ -35,6 +45,25 @@ const addPluginNodeVersion = function ({ featureFlags, pluginOptions, pluginOpti
   Please make sure your plugin supports being run on Node.js 20.
   
   Read more about our minimum required version in our ${link('forums announcement', 'https://answers.netlify.com/t/build-plugin-update-system-node-js-version-upgrade-to-20/108633')}`);
+        if (pluginPath) {
+            const pluginDir = dirname(pluginPath);
+            const { packageJson: pluginPackageJson } = await getPackageJson(pluginDir);
+            // Ensure Node.js version is compatible with plugin's `engines.node`
+            const pluginNodeVersionRange = pluginPackageJson?.engines?.node;
+            if (!pluginNodeVersionRange) {
+                systemLog(`plugin "${packageName}" might be affected by node.js 20 change`);
+            }
+            else if (semver.satisfies('20.0.0', pluginNodeVersionRange)) {
+                systemLog(`plugin "${packageName}" probably not affected by node.js 20 change`);
+            }
+            else {
+                logWarning(logs, `In its package.json, the plugin says it's incompatible with Node.js 20 (version range: "${pluginNodeVersionRange}"). Please upgrade the plugin, so it can be used with Node.js 20.`);
+                systemLog(`plugin "${packageName}" will be affected by node.js 20 change`);
+            }
+        }
+        else {
+            systemLog(`plugin "${packageName}" might be affected by node.js 20 change, pluginPath not available to determine its compatibility`);
+        }
     }
     if (semver.satisfies(userNodeVersion, MINIMUM_REQUIRED_NODE_VERSION)) {
         return userNode;

package/lib/plugins/options.js

@@ -8,7 +8,7 @@ import { getPackageJson } from '../utils/package.js';
 import { useManifest } from './manifest/main.js';
 import { resolvePluginsPath } from './resolve.js';
 // Load core plugins and user plugins
-const tGetPluginsOptions = async function ({ pluginsOptions, netlifyConfig: { plugins }, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, }) {
+const tGetPluginsOptions = async function ({ pluginsOptions, netlifyConfig: { plugins }, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, systemLog, }) {
     const pluginsOptionsA = await resolvePluginsPath({
         pluginsOptions,
         siteInfo,
@@ -26,6 +26,7 @@ const tGetPluginsOptions = async function ({ pluginsOptions, netlifyConfig: { pl
         featureFlags,
         integrations,
         context,
+        systemLog,
     });
     const pluginsOptionsB = await Promise.all(pluginsOptionsA.map((pluginOptions) => loadPluginFiles({ pluginOptions, debug })));
     const pluginsOptionsC = pluginsOptionsB.filter(isNotRedundantCorePlugin);

package/lib/plugins/resolve.d.ts

@@ -1,4 +1,4 @@
-export function resolvePluginsPath({ pluginsOptions, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, }: {
+export function resolvePluginsPath({ pluginsOptions, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, systemLog, }: {
     pluginsOptions: any;
     siteInfo: any;
     buildDir: any;
@@ -15,4 +15,5 @@ export function resolvePluginsPath({ pluginsOptions, siteInfo, buildDir, package
     featureFlags: any;
     integrations: any;
     context: any;
+    systemLog: any;
 }): Promise<any[]>;

package/lib/plugins/resolve.js

@@ -11,15 +11,16 @@ const AUTO_PLUGINS_DIR = '.netlify/plugins/';
 //  - local plugin
 //  - external plugin already installed in `node_modules`, most likely through `package.json`
 //  - automatically installed by us, to `.netlify/plugins/`
-export const resolvePluginsPath = async function ({ pluginsOptions, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, }) {
+export const resolvePluginsPath = async function ({ pluginsOptions, siteInfo, buildDir, packagePath, nodePath, packageJson, userNodeVersion, mode, api, logs, debug, sendStatus, testOpts, featureFlags, integrations, context, systemLog, }) {
     const autoPluginsDir = getAutoPluginsDir(buildDir, packagePath);
     const pluginsOptionsA = await Promise.all(pluginsOptions.map((pluginOptions) => resolvePluginPath({ pluginOptions, buildDir, autoPluginsDir })));
-    const pluginsOptionsB = addPluginsNodeVersion({
+    const pluginsOptionsB = await addPluginsNodeVersion({
         featureFlags,
         pluginsOptions: pluginsOptionsA,
         nodePath,
         userNodeVersion,
         logs,
+        systemLog,
     });
     const pluginsOptionsC = await addPinnedVersions({ pluginsOptions: pluginsOptionsB, api, siteInfo, sendStatus });
     const pluginsOptionsD = await addExpectedVersions({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "29.33.4",
+  "version": "29.33.5",
   "description": "Netlify build module",
   "type": "module",
   "exports": "./lib/index.js",
@@ -70,7 +70,7 @@
     "@bugsnag/js": "^7.0.0",
     "@netlify/blobs": "^6.4.2",
     "@netlify/cache-utils": "^5.1.5",
-    "@netlify/config": "^20.10.3",
+    "@netlify/config": "^20.11.0",
     "@netlify/edge-bundler": "11.2.2",
     "@netlify/framework-info": "^9.8.10",
     "@netlify/functions-utils": "^5.2.49",
@@ -163,5 +163,5 @@
   "engines": {
     "node": "^14.16.0 || >=16.0.0"
   },
-  "gitHead": "d541d710120351fba5559f6f68a7ca5990e13291"
+  "gitHead": "96d48f78b912d9d7491ca110480efa247a1ecfca"
 }