@netlify/build 29.31.2 → 29.31.3

package/lib/plugins/expected_version.js

@@ -12,15 +12,15 @@ export const addExpectedVersions = async function ({ pluginsOptions, autoPlugins
         return pluginsOptions;
     }
     const pluginsList = await getPluginsList({ debug, logs, testOpts });
-    return await Promise.all(pluginsOptions.map((pluginOptions) => addExpectedVersion({ pluginsList, autoPluginsDir, packageJson, pluginOptions, buildDir, featureFlags })));
+    return await Promise.all(pluginsOptions.map((pluginOptions) => addExpectedVersion({ pluginsList, autoPluginsDir, packageJson, pluginOptions, buildDir, featureFlags, testOpts })));
 };
 // Any `pluginOptions` with `expectedVersion` set will be automatically installed
-const addExpectedVersion = async function ({ pluginsList, autoPluginsDir, packageJson, pluginOptions, pluginOptions: { packageName, pluginPath, loadedFrom, nodeVersion, pinnedVersion }, buildDir, featureFlags, }) {
+const addExpectedVersion = async function ({ pluginsList, autoPluginsDir, packageJson, pluginOptions, pluginOptions: { packageName, pluginPath, loadedFrom, nodeVersion, pinnedVersion }, buildDir, featureFlags, testOpts, }) {
     if (!needsExpectedVersion(pluginOptions)) {
         return pluginOptions;
     }
     if (pluginsList[packageName] === undefined) {
-        validateUnlistedPlugin(packageName, loadedFrom);
+        validateUnlistedPlugin(packageName, loadedFrom, testOpts);
         return pluginOptions;
     }
     const unfilteredVersions = pluginsList[packageName];
@@ -70,7 +70,10 @@ const needsExpectedVersion = function ({ loadedFrom }) {
 // Plugins that are not in our official list can only be specified in
 // `netlify.toml` providing they are also installed in the site's package.json.
 // Otherwise, the build should fail.
-const validateUnlistedPlugin = function (packageName, loadedFrom) {
+const validateUnlistedPlugin = function (packageName, loadedFrom, testOpts) {
+    if (testOpts.skipPluginList) {
+        return;
+    }
     if (loadedFrom === 'package.json') {
         return;
     }

package/lib/plugins/node_version.d.ts

@@ -14,8 +14,7 @@ export type PluginsOptions = {
  * usually the system's Node.js version.
  * If the user Node version does not satisfy our supported engine range use our own system Node version
  */
-export declare const addPluginsNodeVersion: ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs }: {
-    featureFlags: any;
+export declare const addPluginsNodeVersion: ({ pluginsOptions, nodePath, userNodeVersion, logs }: {
     pluginsOptions: any;
     nodePath: any;
     userNodeVersion: any;

package/lib/plugins/node_version.js

@@ -7,7 +7,6 @@ import { logWarning, logWarningSubHeader } from '../log/logger.js';
  * If the users preferred Node.js version is below that we have to fall back to the system node version
  */
 const MINIMUM_REQUIRED_NODE_VERSION = '^14.14.0 || >=16.0.0';
-const UPCOMING_MINIMUM_REQUIRED_NODE_VERSION = '>=18.14.0';
 /**
  * Local plugins and `package.json`-installed plugins use user's preferred Node.js version if higher than our minimum
  * supported version. Else default to the system Node version.
@@ -15,30 +14,22 @@ const UPCOMING_MINIMUM_REQUIRED_NODE_VERSION = '>=18.14.0';
  * usually the system's Node.js version.
  * If the user Node version does not satisfy our supported engine range use our own system Node version
  */
-export const addPluginsNodeVersion = function ({ featureFlags, pluginsOptions, nodePath, userNodeVersion, logs }) {
+export const addPluginsNodeVersion = function ({ pluginsOptions, nodePath, userNodeVersion, logs }) {
     const currentNodeVersion = semver.clean(currentVersion);
-    return pluginsOptions.map((pluginOptions) => addPluginNodeVersion({ featureFlags, pluginOptions, currentNodeVersion, userNodeVersion, nodePath, logs }));
+    return pluginsOptions.map((pluginOptions) => addPluginNodeVersion({ pluginOptions, currentNodeVersion, userNodeVersion, nodePath, logs }));
 };
-const addPluginNodeVersion = function ({ featureFlags, pluginOptions, pluginOptions: { loadedFrom, packageName }, currentNodeVersion, userNodeVersion, nodePath, logs, }) {
+const addPluginNodeVersion = function ({ pluginOptions, pluginOptions: { loadedFrom, packageName }, currentNodeVersion, userNodeVersion, nodePath, logs, }) {
     // if the plugin is a local one and the users node version does not satisfy
     // our minimum required node version log a warning as we will default to the system node version
-    if (loadedFrom === 'local' || loadedFrom === 'package.json') {
-        if (!semver.satisfies(userNodeVersion, MINIMUM_REQUIRED_NODE_VERSION)) {
-            logWarningSubHeader(logs, `Warning: ${packageName} will be executed with Node.js version ${currentNodeVersion}`);
-            logWarning(logs, `  The plugin cannot be executed with your defined Node.js version ${userNodeVersion}
-  
+    if ((loadedFrom === 'local' || loadedFrom === 'package.json') &&
+        !semver.satisfies(userNodeVersion, MINIMUM_REQUIRED_NODE_VERSION)) {
+        logWarningSubHeader(logs, `Warning: ${packageName} will be executed with Node.js version ${currentNodeVersion}`);
+        logWarning(logs, `  The plugin cannot be executed with your defined Node.js version ${userNodeVersion}
+
   Read more about our minimum required version in our ${link('forums announcement', 'https://answers.netlify.com/t/build-plugins-dropping-support-for-node-js-12/79421')}`);
-            return { ...pluginOptions, nodePath: execPath, nodeVersion: currentNodeVersion };
-        }
-        if (featureFlags.build_warn_upcoming_system_version_change &&
-            !semver.satisfies(userNodeVersion, UPCOMING_MINIMUM_REQUIRED_NODE_VERSION)) {
-            logWarningSubHeader(logs, `Warning: Starting January 30, 2024 plugin "${packageName}" will be executed with Node.js version 20.`);
-            logWarning(logs, `  We're upgrading our system node version on that day, which means the plugin cannot be executed with your defined Node.js version ${userNodeVersion}.
-        
-  Please make sure your plugin supports being run on Node.js 20.
-  
-  Read more about our minimum required version in our ${link('forums announcement', 'https://answers.netlify.com/t/build-plugin-update-system-node-js-version-upgrade-to-20/108633')}`);
-        }
     }
-    return { ...pluginOptions, nodePath, nodeVersion: userNodeVersion };
+    return (loadedFrom === 'local' || loadedFrom === 'package.json') &&
+        semver.satisfies(userNodeVersion, MINIMUM_REQUIRED_NODE_VERSION)
+        ? { ...pluginOptions, nodePath, nodeVersion: userNodeVersion }
+        : { ...pluginOptions, nodePath: execPath, nodeVersion: currentNodeVersion };
 };

package/lib/plugins/resolve.js

@@ -15,7 +15,6 @@ export const resolvePluginsPath = async function ({ pluginsOptions, siteInfo, bu
     const autoPluginsDir = getAutoPluginsDir(buildDir, packagePath);
     const pluginsOptionsA = await Promise.all(pluginsOptions.map((pluginOptions) => resolvePluginPath({ pluginOptions, buildDir, autoPluginsDir })));
     const pluginsOptionsB = addPluginsNodeVersion({
-        featureFlags,
         pluginsOptions: pluginsOptionsA,
         nodePath,
         userNodeVersion,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "29.31.2",
+  "version": "29.31.3",
   "description": "Netlify build module",
   "type": "module",
   "exports": "./lib/index.js",
@@ -157,5 +157,5 @@
   "engines": {
     "node": "^14.16.0 || >=16.0.0"
   },
-  "gitHead": "48233ae2f82661d3b5f877b9bf62869e6bfb3939"
+  "gitHead": "a623ef20d9da0c1ce753e5c97db1de8dd987c857"
 }