@netlify/build 28.4.1 → 28.4.3

package/lib/core/normalize_flags.js

@@ -2,7 +2,12 @@ import { env, execPath } from 'process';
 import { logFlags } from '../log/messages/config.js';
 import { removeFalsy } from '../utils/remove_falsy.js';
 import { DEFAULT_FEATURE_FLAGS } from './feature_flags.js';
-// Normalize CLI flags
+const REQUIRE_MODE = 'require';
+const DEFAULT_EDGE_FUNCTIONS_DIST = '.netlify/edge-functions-dist/';
+const DEFAULT_FUNCTIONS_DIST = '.netlify/functions/';
+const DEFAULT_CACHE_DIR = '.netlify/cache/';
+const DEFAULT_STATSD_PORT = 8125;
+/** Normalize CLI flags  */
 export const normalizeFlags = function (flags, logs) {
     const rawFlags = removeFalsy(flags);
     // Combine the flags object env with the process.env
@@ -52,8 +57,3 @@ const getDefaultFlags = function ({ env: envOpt = {} }, combinedEnv) {
 const computeTelemetry = function (flags, envOpts) {
     return envOpts.BUILD_TELEMETRY_DISABLED ? { telemetry: false } : { telemetry: flags.telemetry };
 };
-const REQUIRE_MODE = 'require';
-const DEFAULT_EDGE_FUNCTIONS_DIST = '.netlify/edge-functions-dist/';
-const DEFAULT_FUNCTIONS_DIST = '.netlify/functions/';
-const DEFAULT_CACHE_DIR = '.netlify/cache/';
-const DEFAULT_STATSD_PORT = 8125;

package/lib/log/logger.js

@@ -2,7 +2,7 @@ import { createWriteStream } from 'fs';
 import figures from 'figures';
 import indentString from 'indent-string';
 import { getHeader } from './header.js';
-import { serializeObject, serializeArray } from './serialize.js';
+import { serializeArray, serializeObject } from './serialize.js';
 import { THEME } from './theme.js';
 const INDENT_SIZE = 2;
 /**
@@ -132,7 +132,7 @@ systemLogFile) {
     }
     // Return a function that writes to the file descriptor configured for system
     // logs.
-    const fileDescriptor = createWriteStream(null, { fd: systemLogFile });
+    const fileDescriptor = createWriteStream('', { fd: systemLogFile });
     fileDescriptor.on('error', () => {
         logError(logs, 'Could not write to system log file');
     });

package/lib/plugins/options.js

@@ -54,10 +54,15 @@ const isNotRedundantCorePlugin = function (pluginOptionsA, index, pluginsOptions
  * Retrieve information about @netlify/build when an error happens there and not
  * in a plugin
  */
-export const getSpawnInfo = () => ({
-    plugin: { packageName: ROOT_PACKAGE_JSON.name, pluginPackageJson: ROOT_PACKAGE_JSON },
-    location: { event: 'load', packageName: ROOT_PACKAGE_JSON.name, loadedFrom: 'core', origin: 'core' },
-});
+export const getSpawnInfo = () => {
+    // we know that this package.json has a name as it's ours
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const packageName = ROOT_PACKAGE_JSON.name;
+    return {
+        plugin: { packageName, pluginPackageJson: ROOT_PACKAGE_JSON },
+        location: { event: 'load', packageName, loadedFrom: 'core', origin: 'core' },
+    };
+};
 const throwUserError = function (message) {
     const error = new Error(message);
     addErrorInfo(error, { type: 'resolveConfig' });

package/lib/plugins/spawn.js

@@ -17,12 +17,12 @@ const tStartPlugins = async function ({ pluginsOptions, buildDir, childEnv, logs
     logLoadingPlugins(logs, pluginsOptions, debug);
     logOutdatedPlugins(logs, pluginsOptions, featureFlags);
     logIncompatiblePlugins(logs, pluginsOptions);
-    const childProcesses = await Promise.all(pluginsOptions.map(({ pluginDir, nodePath }) => startPlugin({ pluginDir, nodePath, buildDir, childEnv })));
+    const childProcesses = await Promise.all(pluginsOptions.map(({ pluginDir, nodePath }) => startPlugin({ pluginDir, nodePath, buildDir, childEnv, featureFlags })));
     return { childProcesses };
 };
 export const startPlugins = measureDuration(tStartPlugins, 'start_plugins');
-const startPlugin = async function ({ pluginDir, nodePath, buildDir, childEnv }) {
-    const childProcess = execaNode(CHILD_MAIN_FILE, {
+const startPlugin = async function ({ pluginDir, nodePath, buildDir, childEnv, featureFlags }) {
+    const childProcess = execaNode(CHILD_MAIN_FILE, [], {
         cwd: buildDir,
         preferLocal: true,
         localDir: pluginDir,
@@ -30,7 +30,11 @@ const startPlugin = async function ({ pluginDir, nodePath, buildDir, childEnv })
         execPath: nodePath,
         env: childEnv,
         extendEnv: false,
-        serialization: 'advanced',
+        // Feature flag: https://app.launchdarkly.com/default/production/features/netlify_build_use_json_serialization_for_plugin_ipc/targeting
+        // TODO: remove feature flag once fully rolled out
+        ...(!featureFlags.netlify_build_use_json_serialization_for_plugin_ipc && {
+            serialization: 'advanced',
+        }),
     });
     try {
         await getEventFromChild(childProcess, 'ready');

package/lib/steps/run_core_steps.js

@@ -1,12 +1,10 @@
+import { startBuild } from '../core/build.js';
 import { getConfigOpts, loadConfig } from '../core/config.js';
 import { getConstants } from '../core/constants.js';
-import { normalizeFlags } from '../core/normalize_flags.js';
 import { getSeverity } from '../core/severity.js';
 import { handleBuildError } from '../error/handle.js';
 import { getErrorInfo } from '../error/info.js';
-import { startErrorMonitor } from '../error/monitor/start.js';
-import { getBufferLogs, getSystemLogger } from '../log/logger.js';
-import { logBuildStart } from '../log/messages/core.js';
+import { getSystemLogger } from '../log/logger.js';
 import { reportStatuses } from '../status/report.js';
 import { getSteps } from './get.js';
 import { runSteps } from './run_steps.js';
@@ -37,13 +35,6 @@ export const runCoreSteps = async (buildSteps, flags = {}) => {
         return { success, severityCode, logs };
     }
 };
-const startBuild = function (flags) {
-    const logs = getBufferLogs(flags);
-    logBuildStart(logs);
-    const { bugsnagKey, ...flagsA } = normalizeFlags(flags, logs);
-    const errorMonitor = startErrorMonitor({ flags: flagsA, logs, bugsnagKey });
-    return { ...flagsA, errorMonitor, logs };
-};
 const getBuildSteps = function (buildSteps) {
     const allSteps = getSteps([]).steps.filter(({ coreStepId }) => buildSteps.includes(coreStepId));
     return allSteps;

package/lib/utils/package.js

@@ -8,12 +8,14 @@ export const getPackageJson = async function (cwd, options = {}) {
         packageJson: {},
     };
     try {
-        const { path, packageJson } = await readPackageUp({
+        const readResult = await readPackageUp({
             cwd,
             ...Object.assign({ normalize: true }, options),
         });
-        result.packageJson = packageJson;
-        result.packageDir = dirname(path);
+        if (readResult) {
+            result.packageJson = readResult.packageJson;
+            result.packageDir = dirname(readResult.path);
+        }
     }
     catch {
         // continue regardless error

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "28.4.1",
+  "version": "28.4.3",
   "description": "Netlify build module",
   "type": "module",
   "exports": "./lib/core/main.js",
@@ -66,7 +66,7 @@
     "@bugsnag/js": "^7.0.0",
     "@netlify/cache-utils": "^5.0.2",
     "@netlify/config": "^20.0.2",
-    "@netlify/edge-bundler": "4.4.1",
+    "@netlify/edge-bundler": "4.4.2",
     "@netlify/functions-utils": "^5.0.4",
     "@netlify/git-utils": "^5.0.2",
     "@netlify/plugins-list": "^6.54.0",
@@ -149,5 +149,5 @@
       "module": "commonjs"
     }
   },
-  "gitHead": "3e80c5e33030d37eec733ecb927c54eceebd2fd5"
+  "gitHead": "e201ff43d3dfc93b712b1644eae1729ba1c014c2"
 }