@netlify/build 28.0.0-rc → 28.0.0

package/lib/plugins_core/deploy/buildbot_client.js

@@ -0,0 +1,87 @@
+import net from 'net';
+import { normalize, resolve, relative } from 'path';
+import { promisify } from 'util';
+import { pEvent } from 'p-event';
+import { addErrorInfo } from '../../error/info.js';
+import { runsAfterDeploy } from '../../plugins/events.js';
+import { addAsyncErrorMessage } from '../../utils/errors.js';
+export const createBuildbotClient = function (buildbotServerSocket) {
+    const connectionOpts = getConnectionOpts(buildbotServerSocket);
+    const client = net.createConnection(connectionOpts);
+    return client;
+};
+// Windows does not support Unix sockets well, so we also support `host:port`
+const getConnectionOpts = function (buildbotServerSocket) {
+    if (!buildbotServerSocket.includes(':')) {
+        return { path: buildbotServerSocket };
+    }
+    const [host, port] = buildbotServerSocket.split(':');
+    return { host, port };
+};
+const eConnectBuildbotClient = async function (client) {
+    await pEvent(client, 'connect');
+};
+export const connectBuildbotClient = addAsyncErrorMessage(eConnectBuildbotClient, 'Could not connect to buildbot');
+export const closeBuildbotClient = async function (client) {
+    if (client.destroyed) {
+        return;
+    }
+    await promisify(client.end.bind(client))();
+};
+const cWritePayload = async function (buildbotClient, payload) {
+    await promisify(buildbotClient.write.bind(buildbotClient))(JSON.stringify(payload));
+};
+const writePayload = addAsyncErrorMessage(cWritePayload, 'Could not send payload to buildbot');
+const cGetNextParsedResponsePromise = async function (buildbotClient) {
+    const data = await pEvent(buildbotClient, 'data');
+    return JSON.parse(data);
+};
+const getNextParsedResponsePromise = addAsyncErrorMessage(cGetNextParsedResponsePromise, 'Invalid response from buildbot');
+export const deploySiteWithBuildbotClient = async function ({ client, events, buildDir, repositoryRoot, constants }) {
+    const action = shouldWaitForPostProcessing(events) ? 'deploySiteAndAwaitLive' : 'deploySite';
+    const deployDir = getDeployDir({ buildDir, repositoryRoot, constants });
+    const payload = { action, deployDir };
+    const [{ succeeded, values: { error, error_type: errorType } = {} }] = await Promise.all([
+        getNextParsedResponsePromise(client),
+        writePayload(client, payload),
+    ]);
+    if (!succeeded) {
+        return handleDeployError(error, errorType);
+    }
+};
+// The file paths in the buildbot are relative to the repository root.
+// However, the file paths in Build plugins, including `constants.PUBLISH_DIR`
+// are relative to the build directory, which is different when there is a
+// base directory. This converts it.
+// We need to call `normalize()` in case the publish directory is the
+// repository root, so `deployDir` is "." not ""
+const getDeployDir = function ({ buildDir, repositoryRoot, constants: { PUBLISH_DIR } }) {
+    const absolutePublishDir = resolve(buildDir, PUBLISH_DIR);
+    const relativePublishDir = relative(repositoryRoot, absolutePublishDir);
+    const deployDir = normalize(relativePublishDir);
+    return deployDir;
+};
+// We distinguish between user errors and system errors during deploys
+const handleDeployError = function (error, errorType) {
+    const errorIs422 = error !== undefined && error.code === '422';
+    const errMsg = errorIs422
+        ? `
+    File upload failed because of mismatched SHAs.
+    This can happen when files are changed after the deployment process has started but before they are uploaded.
+
+    Error: ${error}
+    `
+        : `Deploy did not succeed: ${error}`;
+    const errorA = new Error(errMsg);
+    const errorInfo = errorType === 'user' ? { type: 'resolveConfig' } : { type: 'coreStep', location: { coreStepName: 'Deploy site' } };
+    addErrorInfo(errorA, errorInfo);
+    throw errorA;
+};
+// We only wait for post-processing (last stage before site deploy) if the build
+// has some plugins that do post-deploy logic
+const shouldWaitForPostProcessing = function (events) {
+    return events.some(hasPostDeployLogic);
+};
+const hasPostDeployLogic = function (event) {
+    return runsAfterDeploy(event);
+};

package/lib/plugins_core/deploy/index.js

@@ -0,0 +1,49 @@
+import { saveUpdatedConfig, restoreUpdatedConfig } from '../../core/config.js';
+import { logDeploySuccess } from '../../log/messages/plugins.js';
+import { createBuildbotClient, connectBuildbotClient, closeBuildbotClient, deploySiteWithBuildbotClient, } from './buildbot_client.js';
+const coreStep = async function ({ buildDir, configPath, repositoryRoot, constants, buildbotServerSocket, events, logs, featureFlags, context, branch, configMutations, headersPath, redirectsPath, debug, saveConfig, }) {
+    const client = createBuildbotClient(buildbotServerSocket);
+    try {
+        await connectBuildbotClient(client);
+        await saveUpdatedConfig({
+            configMutations,
+            buildDir,
+            repositoryRoot,
+            configPath,
+            headersPath,
+            redirectsPath,
+            logs,
+            featureFlags,
+            context,
+            branch,
+            debug,
+            saveConfig,
+        });
+        await deploySiteWithBuildbotClient({ client, events, buildDir, repositoryRoot, constants });
+        await restoreUpdatedConfig({
+            configMutations,
+            buildDir,
+            repositoryRoot,
+            configPath,
+            headersPath,
+            redirectsPath,
+            saveConfig,
+        });
+        logDeploySuccess(logs);
+        return {};
+    }
+    finally {
+        await closeBuildbotClient(client);
+    }
+};
+const shouldDeploy = function ({ buildbotServerSocket }) {
+    return buildbotServerSocket !== undefined;
+};
+export const deploySite = {
+    event: 'onPostBuild',
+    coreStep,
+    coreStepId: 'deploy_site',
+    coreStepName: 'Deploy site',
+    coreStepDescription: () => 'Deploy site',
+    condition: shouldDeploy,
+};

package/lib/plugins_core/edge_functions/index.js

@@ -0,0 +1,79 @@
+import { promises as fs } from 'fs';
+import { dirname, join, resolve } from 'path';
+import { bundle, find } from '@netlify/edge-bundler';
+import { pathExists } from 'path-exists';
+import { logFunctionsToBundle } from '../../log/messages/core_steps.js';
+import { tagBundlingError } from './lib/error.js';
+import { parseManifest } from './lib/internal_manifest.js';
+import { validateEdgeFunctionsManifest } from './validate_manifest/validate_edge_functions_manifest.js';
+// TODO: Replace this with a custom cache directory.
+const DENO_CLI_CACHE_DIRECTORY = '.netlify/plugins/deno-cli';
+const IMPORT_MAP_FILENAME = 'edge-functions-import-map.json';
+const coreStep = async function ({ buildDir, constants: { EDGE_FUNCTIONS_DIST: distDirectory, EDGE_FUNCTIONS_SRC: srcDirectory, INTERNAL_EDGE_FUNCTIONS_SRC: internalSrcDirectory, IS_LOCAL: isRunningLocally, }, debug, systemLog, featureFlags, logs, netlifyConfig, }) {
+    const { edge_functions: configDeclarations = [] } = netlifyConfig;
+    const distPath = resolve(buildDir, distDirectory);
+    const internalSrcPath = resolve(buildDir, internalSrcDirectory);
+    const distImportMapPath = join(dirname(internalSrcPath), IMPORT_MAP_FILENAME);
+    const srcPath = srcDirectory ? resolve(buildDir, srcDirectory) : undefined;
+    const sourcePaths = [internalSrcPath, srcPath].filter(Boolean);
+    logFunctions({ internalSrcDirectory, internalSrcPath, logs, srcDirectory, srcPath });
+    const { declarations: internalDeclarations, importMap } = await parseManifest(internalSrcPath, systemLog);
+    const declarations = [...configDeclarations, ...internalDeclarations];
+    // If we're running in buildbot and the feature flag is enabled, we set the
+    // Deno cache dir to a directory that is persisted between builds.
+    const cacheDirectory = !isRunningLocally && featureFlags.edge_functions_cache_cli ? resolve(buildDir, DENO_CLI_CACHE_DIRECTORY) : undefined;
+    // Edge Bundler expects the dist directory to exist.
+    await fs.mkdir(distPath, { recursive: true });
+    try {
+        const { manifest } = await bundle(sourcePaths, distPath, declarations, {
+            basePath: buildDir,
+            cacheDirectory,
+            debug,
+            distImportMapPath,
+            featureFlags,
+            importMaps: [importMap].filter(Boolean),
+            systemLogger: featureFlags.edge_functions_system_logger ? systemLog : undefined,
+        });
+        systemLog('Edge Functions manifest:', manifest);
+    }
+    catch (error) {
+        tagBundlingError(error);
+        throw error;
+    }
+    await validateEdgeFunctionsManifest({ buildDir, constants: { EDGE_FUNCTIONS_DIST: distDirectory } });
+    return {};
+};
+// We run this core step if at least one of the functions directories (the
+// one configured by the user or the internal one) exists. We use a dynamic
+// `condition` because the directories might be created by the build command
+// or plugins.
+const hasEdgeFunctionsDirectories = async function ({ buildDir, constants: { INTERNAL_EDGE_FUNCTIONS_SRC, EDGE_FUNCTIONS_SRC }, }) {
+    const hasFunctionsSrc = EDGE_FUNCTIONS_SRC !== undefined && EDGE_FUNCTIONS_SRC !== '';
+    if (hasFunctionsSrc) {
+        return true;
+    }
+    const internalFunctionsSrc = resolve(buildDir, INTERNAL_EDGE_FUNCTIONS_SRC);
+    return await pathExists(internalFunctionsSrc);
+};
+const logFunctions = async ({ internalSrcDirectory, internalSrcPath, logs, srcDirectory: userFunctionsSrc, srcPath, }) => {
+    const [userFunctions, internalFunctions] = await Promise.all([find([srcPath]), find([internalSrcPath])]);
+    const userFunctionsSrcExists = await pathExists(srcPath);
+    const internalFunctionsSrc = internalSrcDirectory;
+    logFunctionsToBundle({
+        logs,
+        userFunctions: userFunctions.map(({ name }) => name),
+        userFunctionsSrc,
+        userFunctionsSrcExists,
+        internalFunctions: internalFunctions.map(({ name }) => name),
+        internalFunctionsSrc,
+        type: 'Edge Functions',
+    });
+};
+export const bundleEdgeFunctions = {
+    event: 'onBuild',
+    coreStep,
+    coreStepId: 'edge_functions_bundling',
+    coreStepName: 'Edge Functions bundling',
+    coreStepDescription: () => 'Edge Functions bundling',
+    condition: hasEdgeFunctionsDirectories,
+};

package/{src → lib}/plugins_core/edge_functions/lib/error.js

@@ -1,21 +1,17 @@
-import { CUSTOM_ERROR_KEY, getErrorInfo, isBuildError } from '../../../error/info.js'
-
+import { CUSTOM_ERROR_KEY, getErrorInfo, isBuildError } from '../../../error/info.js';
 // If we have a custom error tagged with `functionsBundling` (which happens if
 // there is an issue with user code), we tag it as coming from an edge function
 // so that we can adjust the downstream error messages accordingly.
 export const tagBundlingError = (error) => {
-  if (!isBuildError(error)) {
-    return
-  }
-
-  const [errorInfo = {}] = getErrorInfo(error)
-
-  if (errorInfo.type !== 'functionsBundling') {
-    return
-  }
-
-  error[CUSTOM_ERROR_KEY].location = {
-    ...error[CUSTOM_ERROR_KEY].location,
-    functionType: 'edge',
-  }
-}
+    if (!isBuildError(error)) {
+        return;
+    }
+    const [errorInfo = {}] = getErrorInfo(error);
+    if (errorInfo.type !== 'functionsBundling') {
+        return;
+    }
+    error[CUSTOM_ERROR_KEY].location = {
+        ...error[CUSTOM_ERROR_KEY].location,
+        functionType: 'edge',
+    };
+};

package/lib/plugins_core/edge_functions/lib/internal_manifest.js

@@ -0,0 +1,50 @@
+import { promises as fs } from 'fs';
+import { dirname, join, resolve } from 'path';
+import { pathToFileURL } from 'url';
+const parseManifest = async (internalSourceDirectory, systemLog) => {
+    const manifestPath = join(internalSourceDirectory, 'manifest.json');
+    try {
+        const data = await fs.readFile(manifestPath);
+        const manifest = JSON.parse(data);
+        if (manifest.version !== 1) {
+            throw new Error('Unsupported manifest version');
+        }
+        const result = {
+            declarations: manifest.functions,
+        };
+        if (manifest.import_map) {
+            const importMapPath = resolve(dirname(manifestPath), manifest.import_map);
+            const importMap = await readImportMap(importMapPath);
+            return {
+                ...result,
+                importMap: {
+                    baseURL: pathToFileURL(importMapPath),
+                    ...importMap,
+                },
+            };
+        }
+        return result;
+    }
+    catch (error) {
+        if (error.code !== 'ENOENT') {
+            systemLog('Error while parsing internal edge functions manifest:', error);
+        }
+    }
+    return {
+        declarations: [],
+    };
+};
+const readImportMap = async (path) => {
+    try {
+        const data = await fs.readFile(path);
+        const importMap = JSON.parse(data);
+        return importMap;
+    }
+    catch {
+        // no-op
+    }
+    return {
+        imports: {},
+    };
+};
+export { parseManifest };

package/lib/plugins_core/edge_functions/validate_manifest/validate_edge_functions_manifest.js

@@ -0,0 +1,75 @@
+import { promises as fs } from 'fs';
+import { join, resolve } from 'path';
+import Ajv from 'ajv';
+import ajvErrors from 'ajv-errors';
+import { addErrorInfo } from '../../../error/info.js';
+const ajv = new Ajv({ allErrors: true });
+ajvErrors(ajv);
+// regex pattern for manifest route pattern
+// checks if the pattern string starts with ^ and ends with $
+// we define this format in edge-bundler:
+// https://github.com/netlify/edge-bundler/blob/main/src/manifest.ts#L66
+const normalizedPatternRegex = /^\^.*\$$/;
+ajv.addFormat('regexPattern', {
+    async: true,
+    validate: (data) => normalizedPatternRegex.test(data),
+});
+const bundlesSchema = {
+    $async: true,
+    type: 'object',
+    required: ['asset', 'format'],
+    properties: {
+        asset: { type: 'string' },
+        format: { type: 'string' },
+    },
+    additionalProperties: false,
+};
+const routesSchema = {
+    $async: true,
+    type: 'object',
+    required: ['function', 'pattern'],
+    properties: {
+        name: { type: 'string' },
+        function: { type: 'string' },
+        pattern: { type: 'string', format: 'regexPattern', errorMessage: `must match format ${normalizedPatternRegex}` },
+    },
+    additionalProperties: false,
+};
+const edgeManifestSchema = {
+    $async: true,
+    type: 'object',
+    required: ['bundles', 'routes', 'bundler_version'],
+    properties: {
+        bundles: {
+            type: 'array',
+            items: bundlesSchema,
+        },
+        routes: {
+            type: 'array',
+            items: routesSchema,
+        },
+        bundler_version: { type: 'string' },
+    },
+    additionalProperties: false,
+    errorMessage: "Couldn't validate Edge Functions manifest.json",
+};
+const validateManifest = async (manifestData) => {
+    const validate = ajv.compile(edgeManifestSchema);
+    await validate(manifestData);
+};
+export const validateEdgeFunctionsManifest = async function ({ buildDir, constants: { EDGE_FUNCTIONS_DIST: distDirectory }, }) {
+    try {
+        const edgeFunctionsDistPath = resolve(buildDir, distDirectory);
+        const manifestPath = join(edgeFunctionsDistPath, 'manifest.json');
+        const data = await fs.readFile(manifestPath);
+        const manifestData = JSON.parse(data);
+        await validateManifest(manifestData);
+    }
+    catch (error) {
+        const isValidationErr = error instanceof Ajv.ValidationError;
+        const parsedErr = isValidationErr ? error.errors : error;
+        addErrorInfo(parsedErr, { type: 'coreStep' });
+        throw new Error(isValidationErr ? JSON.stringify(parsedErr, null, 2) : parsedErr);
+    }
+    return {};
+};

package/lib/plugins_core/functions/error.js

@@ -0,0 +1,123 @@
+import readdirp from 'readdirp';
+import { addErrorInfo } from '../../error/info.js';
+const MODULE_NOT_FOUND_CODE = 'MODULE_NOT_FOUND';
+const MODULE_NOT_FOUND_ESBUILD_REGEXP = /^Could not resolve ['"]([^'"]+)/;
+const MODULE_NOT_FOUND_REGEXP = /Cannot find module ['"]([^'"]+)/;
+// Handle errors coming from zip-it-and-ship-it
+export const getZipError = async function (error, functionsSrc) {
+    const moduleNotFoundError = await getModuleNotFoundError(error, functionsSrc);
+    if (moduleNotFoundError) {
+        return moduleNotFoundError;
+    }
+    if (isPackageJsonError(error)) {
+        return getPackageJsonError(error);
+    }
+    return error;
+};
+const getModuleNotFoundError = async function (error, functionsSrc) {
+    const errorFromZisi = await getModuleNotFoundErrorFromZISI(error, functionsSrc);
+    if (errorFromZisi) {
+        return errorFromZisi;
+    }
+    const errorFromEsbuild = await getModuleNotFoundErrorFromEsbuild(error, functionsSrc);
+    if (errorFromEsbuild) {
+        return errorFromEsbuild;
+    }
+};
+const getModuleNotFoundErrorObject = async ({ error, functionsSrc, moduleNames }) => {
+    const message = await getModuleNotFoundMessage(functionsSrc, moduleNames);
+    error.message = `${message}\n\n${error.message}`;
+    addErrorInfo(error, { type: 'dependencies' });
+    return error;
+};
+const getModuleNotFoundMessage = async function (functionsSrc, moduleNames) {
+    if (moduleNames.length === 0 || !(await lacksNodeModules(functionsSrc))) {
+        return MODULE_NOT_FOUND_MESSAGE;
+    }
+    if (moduleNames.filter(Boolean).some(isLocalPath)) {
+        return PATH_NOT_FOUND_MESSAGE;
+    }
+    return getLocalInstallMessage(moduleNames);
+};
+const isLocalPath = function (moduleName) {
+    return moduleName.startsWith('.') || moduleName.startsWith('/');
+};
+const getModuleNotFoundErrorFromEsbuild = function (error, functionsSrc) {
+    const { errors = [] } = error;
+    const modulesNotFound = errors.reduce((modules, errorObject) => {
+        const match = errorObject.text.match(MODULE_NOT_FOUND_ESBUILD_REGEXP);
+        if (!match) {
+            return modules;
+        }
+        return [...modules, match[1]];
+    }, []);
+    if (modulesNotFound.length === 0) {
+        return;
+    }
+    return getModuleNotFoundErrorObject({ error, functionsSrc, moduleNames: modulesNotFound });
+};
+const getModuleNotFoundErrorFromZISI = function (error, functionsSrc) {
+    if (!(error instanceof Error && error.code === MODULE_NOT_FOUND_CODE)) {
+        return;
+    }
+    const moduleName = getModuleNameFromZISIError(error);
+    return getModuleNotFoundErrorObject({ error, functionsSrc, moduleNames: moduleName ? [moduleName] : [] });
+};
+// This error message always include the same words
+const getModuleNameFromZISIError = function (error) {
+    if (typeof error.message !== 'string') {
+        return;
+    }
+    const result = MODULE_NOT_FOUND_REGEXP.exec(error.message);
+    if (result === null) {
+        return;
+    }
+    return result[1];
+};
+// Netlify Functions has a `package.json` but no `node_modules`
+const lacksNodeModules = async function (functionsSrc) {
+    return (functionsSrc !== undefined &&
+        (await hasFunctionRootFile('package.json', functionsSrc)) &&
+        !(await hasFunctionRootFile('node_modules', functionsSrc)));
+};
+// Functions can be either files or directories, so we need to check on two
+// depth levels
+const hasFunctionRootFile = async function (filename, functionsSrc) {
+    const files = await readdirp.promise(functionsSrc, { depth: 1, fileFilter: filename });
+    return files.length !== 0;
+};
+const MODULE_NOT_FOUND_MESSAGE = `A Netlify Function failed to require one of its dependencies.
+Please make sure it is present in the site's top-level "package.json".`;
+const PATH_NOT_FOUND_MESSAGE = `A Netlify Function failed to require a local file.
+Please make sure the file exists and its path is correctly spelled.`;
+// A common mistake is to assume Netlify Functions dependencies are
+// automatically installed. This checks for this pattern.
+const getLocalInstallMessage = function (modules) {
+    const genericMessage = `
+
+By default, dependencies inside a Netlify Function's "package.json" are not automatically installed.
+There are several ways to fix this problem:
+  - Removing your Function's "package.json" and adding the dependencies to the project's top-level "package.json" instead. This is the fastest and safest solution.
+  - Running "npm install" or "yarn" inside your Netlify Function in your build command.
+  - Adding the following plugin to your "netlify.toml":
+
+[[plugins]]
+package = "@netlify/plugin-functions-install-core"
+  `;
+    if (modules.length === 1) {
+        return `A Netlify Function is using "${modules[0]}" but that dependency has not been installed yet.${genericMessage}`;
+    }
+    const moduleNames = modules.map((name) => `"${name}"`).join(', ');
+    return `A Netlify Function is using dependencies that have not been installed yet: ${moduleNames}${genericMessage}`;
+};
+// We need to load the site's `package.json` when bundling Functions. This is
+// because `optionalDependencies` can make `import()` fail, but we don't want
+// to error then. However, if the `package.json` is invalid, we fail the build.
+const isPackageJsonError = function (error) {
+    return PACKAGE_JSON_ORIGINAL_MESSAGES.some((msg) => error.message.includes(msg));
+};
+const PACKAGE_JSON_ORIGINAL_MESSAGES = ['is invalid JSON', 'in JSON at position'];
+const getPackageJsonError = function (error) {
+    addErrorInfo(error, { type: 'resolveConfig' });
+    return error;
+};

package/lib/plugins_core/functions/feature_flags.js

@@ -0,0 +1,6 @@
+export const getZisiFeatureFlags = (featureFlags) => ({
+    ...featureFlags,
+    defaultEsModulesToEsbuild: featureFlags.buildbot_es_modules_esbuild,
+    parseWithEsbuild: featureFlags.buildbot_zisi_esbuild_parser,
+    traceWithNft: featureFlags.buildbot_zisi_trace_nft,
+});

package/lib/plugins_core/functions/index.js

@@ -0,0 +1,114 @@
+import { resolve } from 'path';
+import { zipFunctions } from '@netlify/zip-it-and-ship-it';
+import { pathExists } from 'path-exists';
+import { log } from '../../log/logger.js';
+import { logBundleResults, logFunctionsNonExistingDir, logFunctionsToBundle } from '../../log/messages/core_steps.js';
+import { getZipError } from './error.js';
+import { getUserAndInternalFunctions, validateFunctionsSrc } from './utils.js';
+import { getZisiParameters } from './zisi.js';
+// Returns `true` if at least one of the functions has been configured to use
+// esbuild.
+const isUsingEsbuild = (functionsConfig = {}) => Object.values(functionsConfig).some((configObject) => configObject.node_bundler === 'esbuild');
+const zipFunctionsAndLogResults = async ({ buildDir, childEnv, featureFlags, functionsConfig, functionsDist, functionsSrc, internalFunctionsSrc, isRunningLocally, logs, repositoryRoot, }) => {
+    const zisiParameters = getZisiParameters({
+        buildDir,
+        childEnv,
+        featureFlags,
+        functionsConfig,
+        functionsDist,
+        internalFunctionsSrc,
+        isRunningLocally,
+        repositoryRoot,
+    });
+    const bundler = isUsingEsbuild(functionsConfig) ? 'esbuild' : 'zisi';
+    try {
+        // Printing an empty line before bundling output.
+        log(logs, '');
+        const sourceDirectories = [internalFunctionsSrc, functionsSrc].filter(Boolean);
+        const results = await zipItAndShipIt.zipFunctions(sourceDirectories, functionsDist, zisiParameters);
+        logBundleResults({ logs, results });
+        return { bundler };
+    }
+    catch (error) {
+        throw await getZipError(error, functionsSrc);
+    }
+};
+// Plugin to package Netlify functions with @netlify/zip-it-and-ship-it
+const coreStep = async function ({ childEnv, constants: { INTERNAL_FUNCTIONS_SRC: relativeInternalFunctionsSrc, IS_LOCAL: isRunningLocally, FUNCTIONS_SRC: relativeFunctionsSrc, FUNCTIONS_DIST: relativeFunctionsDist, }, buildDir, logs, netlifyConfig, featureFlags, repositoryRoot, }) {
+    const functionsSrc = relativeFunctionsSrc === undefined ? undefined : resolve(buildDir, relativeFunctionsSrc);
+    const functionsDist = resolve(buildDir, relativeFunctionsDist);
+    const internalFunctionsSrc = resolve(buildDir, relativeInternalFunctionsSrc);
+    const internalFunctionsSrcExists = await pathExists(internalFunctionsSrc);
+    const functionsSrcExists = await validateFunctionsSrc({ functionsSrc, logs, relativeFunctionsSrc });
+    const [userFunctions = [], internalFunctions = []] = await getUserAndInternalFunctions({
+        featureFlags,
+        functionsSrc,
+        functionsSrcExists,
+        internalFunctionsSrc,
+        internalFunctionsSrcExists,
+    });
+    if (functionsSrc && !functionsSrcExists) {
+        logFunctionsNonExistingDir(logs, relativeFunctionsSrc);
+        if (internalFunctions.length !== 0) {
+            log(logs, '');
+        }
+    }
+    logFunctionsToBundle({
+        logs,
+        userFunctions,
+        userFunctionsSrc: relativeFunctionsSrc,
+        userFunctionsSrcExists: functionsSrcExists,
+        internalFunctions,
+        internalFunctionsSrc: relativeInternalFunctionsSrc,
+    });
+    if (userFunctions.length === 0 && internalFunctions.length === 0) {
+        return {};
+    }
+    const { bundler } = await zipFunctionsAndLogResults({
+        buildDir,
+        childEnv,
+        featureFlags,
+        functionsConfig: netlifyConfig.functions,
+        functionsDist,
+        functionsSrc,
+        internalFunctionsSrc,
+        isRunningLocally,
+        logs,
+        repositoryRoot,
+    });
+    return {
+        tags: {
+            bundler,
+        },
+    };
+};
+// We run this core step if at least one of the functions directories (the
+// one configured by the user or the internal one) exists. We use a dynamic
+// `condition` because the directories might be created by the build command
+// or plugins.
+const hasFunctionsDirectories = async function ({ buildDir, constants: { INTERNAL_FUNCTIONS_SRC, FUNCTIONS_SRC } }) {
+    const hasFunctionsSrc = FUNCTIONS_SRC !== undefined && FUNCTIONS_SRC !== '';
+    if (hasFunctionsSrc) {
+        return true;
+    }
+    const internalFunctionsSrc = resolve(buildDir, INTERNAL_FUNCTIONS_SRC);
+    return await pathExists(internalFunctionsSrc);
+};
+export const bundleFunctions = {
+    event: 'onBuild',
+    coreStep,
+    coreStepId: 'functions_bundling',
+    coreStepName: 'Functions bundling',
+    coreStepDescription: () => 'Functions bundling',
+    condition: hasFunctionsDirectories,
+};
+// Named imports with ES modules cannot be mocked (unlike CommonJS) because
+// they are bound at load time.
+// However, some of our tests are asserting which arguments are passed to
+// `zip-it-and-ship-it` methods. Therefore, we need to use an intermediary
+// function and export them so tests can use it.
+export const zipItAndShipIt = {
+    async zipFunctions(...args) {
+        return await zipFunctions(...args);
+    },
+};

package/lib/plugins_core/functions/utils.js

@@ -0,0 +1,45 @@
+import { promises as fs } from 'fs';
+import { relative } from 'path';
+import { listFunctions } from '@netlify/zip-it-and-ship-it';
+import { addErrorInfo } from '../../error/info.js';
+import { getZisiFeatureFlags } from './feature_flags.js';
+// Returns the `mainFile` of each function found in `functionsSrc`, relative to
+// `functionsSrc`.
+const getRelativeFunctionMainFiles = async function ({ featureFlags, functionsSrc }) {
+    if (functionsSrc === undefined) {
+        return [];
+    }
+    const zisiFeatureFlags = getZisiFeatureFlags(featureFlags);
+    const functions = await listFunctions(functionsSrc, { featureFlags: zisiFeatureFlags });
+    return functions.map(({ mainFile }) => relative(functionsSrc, mainFile));
+};
+export const getUserAndInternalFunctions = ({ featureFlags, functionsSrc, functionsSrcExists, internalFunctionsSrc, internalFunctionsSrcExists, }) => {
+    const paths = [
+        functionsSrcExists ? functionsSrc : undefined,
+        internalFunctionsSrcExists ? internalFunctionsSrc : undefined,
+    ];
+    return Promise.all(paths.map((path) => path && getRelativeFunctionMainFiles({ featureFlags, functionsSrc: path })));
+};
+// Returns `true` if the functions directory exists and is valid. Returns
+// `false` if it doesn't exist. Throws an error if it's invalid or can't
+// be accessed.
+export const validateFunctionsSrc = async function ({ functionsSrc, relativeFunctionsSrc }) {
+    if (functionsSrc === undefined) {
+        return false;
+    }
+    try {
+        const stats = await fs.stat(functionsSrc);
+        if (stats.isDirectory()) {
+            return true;
+        }
+        const error = new Error(`The Netlify Functions setting should target a directory, not a regular file: ${relativeFunctionsSrc}`);
+        addErrorInfo(error, { type: 'resolveConfig' });
+        throw error;
+    }
+    catch (error) {
+        if (error.code === 'ENOENT') {
+            return false;
+        }
+        throw error;
+    }
+};