@netlify/build 27.8.0 → 28.0.0-rc

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "27.8.0",
+  "version": "28.0.0-rc",
   "description": "Netlify build module",
   "type": "module",
   "exports": "./src/core/main.js",

package/src/core/flags.js

@@ -145,6 +145,11 @@ Default: false`,
     describe: 'Print user-facing debugging information',
     hidden: true,
   },
+  systemLogFile: {
+    type: 'number',
+    describe: 'File descriptor to where system logs should be piped',
+    hidden: true,
+  },
   verbose: {
     boolean: true,
     describe: 'Print internal debugging information',

package/src/core/main.js

@@ -2,7 +2,7 @@
 import { handleBuildError } from '../error/handle.js'
 import { getErrorInfo } from '../error/info.js'
 import { startErrorMonitor } from '../error/monitor/start.js'
-import { getBufferLogs } from '../log/logger.js'
+import { getBufferLogs, getSystemLogger } from '../log/logger.js'
 import { logBuildStart, logTimer, logBuildSuccess } from '../log/messages/core.js'
 import { loadPlugins } from '../plugins/load.js'
 import { getPluginsOptions } from '../plugins/options.js'
@@ -57,6 +57,7 @@ export default async function buildSite(flags = {}) {
     mode,
     logs,
     debug,
+    systemLogFile,
     testOpts,
     statsdOpts,
     dry,
@@ -80,6 +81,7 @@ export default async function buildSite(flags = {}) {
     } = await execBuild({
       ...flagsA,
       buildId,
+      systemLogFile,
       deployId,
       dry,
       errorMonitor,
@@ -163,6 +165,7 @@ const tExecBuild = async function ({
   baseRelDir,
   env: envOpt,
   debug,
+  systemLogFile,
   verbose,
   nodePath,
   functionsDistDir,
@@ -241,6 +244,7 @@ const tExecBuild = async function ({
     mode,
     testOpts,
   })
+  const systemLog = getSystemLogger(logs, debug, systemLogFile)
   const pluginsOptions = addCorePlugins({ netlifyConfig, constants })
   // `errorParams` is purposely stateful
   // eslint-disable-next-line fp/no-mutating-assign
@@ -276,6 +280,7 @@ const tExecBuild = async function ({
     errorParams,
     logs,
     debug,
+    systemLog,
     verbose,
     timers: timersA,
     sendStatus,
@@ -325,6 +330,7 @@ const runAndReportBuild = async function ({
   errorParams,
   logs,
   debug,
+  systemLog,
   verbose,
   timers,
   sendStatus,
@@ -365,6 +371,7 @@ const runAndReportBuild = async function ({
       errorParams,
       logs,
       debug,
+      systemLog,
       verbose,
       timers,
       sendStatus,
@@ -457,6 +464,7 @@ const initAndRunBuild = async function ({
   errorParams,
   logs,
   debug,
+  systemLog,
   verbose,
   sendStatus,
   saveConfig,
@@ -528,6 +536,7 @@ const initAndRunBuild = async function ({
       errorParams,
       logs,
       debug,
+      systemLog,
       verbose,
       saveConfig,
       timers: timersB,
@@ -581,6 +590,7 @@ const runBuild = async function ({
   errorParams,
   logs,
   debug,
+  systemLog,
   verbose,
   saveConfig,
   timers,
@@ -634,6 +644,7 @@ const runBuild = async function ({
     configOpts,
     logs,
     debug,
+    systemLog,
     verbose,
     saveConfig,
     timers: timersA,

package/src/error/type.js

@@ -88,7 +88,7 @@ const TYPES = {
 
       return `Bundling of function "${functionName}" failed`
     },
-    group: ({ location: { functionType = 'serverless' } }) => `'Bundling of ${functionType} function failed`,
+    group: ({ location: { functionType = 'serverless' } }) => `Bundling of ${functionType} function failed`,
     stackType: 'none',
     locationType: 'functionsBundling',
     severity: 'info',

package/src/log/logger.js

@@ -1,3 +1,5 @@
+import { createWriteStream } from 'fs'
+
 import figures from 'figures'
 import indentString from 'indent-string'
 
@@ -105,3 +107,36 @@ export const logErrorSubHeader = function (logs, string, opts) {
 export const logWarningSubHeader = function (logs, string, opts) {
   logSubHeader(logs, string, { color: THEME.warningSubHeader, ...opts })
 }
+
+// Combines an array of elements into a single string, separated by a space,
+// and with basic serialization of non-string types
+const reduceLogLines = function (lines) {
+  return lines
+    .map((input) => {
+      if (typeof input === 'object') {
+        return JSON.stringify(input)
+      }
+
+      return input.toString()
+    })
+    .join(' ')
+}
+
+// Builds a function for logging data to the system logger (i.e. hidden from
+// the user-facing build logs)
+export const getSystemLogger = function (logs, debug, systemLogFile) {
+  // If there's not a file descriptor (or it's set to 0, matching stdout), we
+  // send debug lines to the normal logger. The same happens if the `debug`
+  // flag is used, since that means we want to print logs to stdout.
+  if (!systemLogFile || debug) {
+    return (...args) => log(logs, reduceLogLines(args))
+  }
+
+  const fileDescriptor = createWriteStream(null, { fd: systemLogFile })
+
+  fileDescriptor.on('error', () => {
+    logError(logs, 'Could not write to system log file')
+  })
+
+  return (...args) => fileDescriptor.write(reduceLogLines(args))
+}

package/src/plugins_core/edge_functions/index.js

@@ -5,7 +5,6 @@ import { bundle, find } from '@netlify/edge-bundler'
 import { pathExists } from 'path-exists'
 
 import { logFunctionsToBundle } from '../../log/messages/core_steps.js'
-import { logEdgeManifest } from '../../log/messages/edge_manifest.js'
 
 import { tagBundlingError } from './lib/error.js'
 import { parseManifest } from './lib/internal_manifest.js'
@@ -15,7 +14,7 @@ import { validateEdgeFunctionsManifest } from './validate_manifest/validate_edge
 const DENO_CLI_CACHE_DIRECTORY = '.netlify/plugins/deno-cli'
 const IMPORT_MAP_FILENAME = 'edge-functions-import-map.json'
 
-// eslint-disable-next-line complexity, max-statements
+// eslint-disable-next-line max-statements
 const coreStep = async function ({
   buildDir,
   constants: {
@@ -25,6 +24,7 @@ const coreStep = async function ({
     IS_LOCAL: isRunningLocally,
   },
   debug,
+  systemLog,
   featureFlags,
   logs,
   netlifyConfig,
@@ -59,9 +59,7 @@ const coreStep = async function ({
       importMaps: [importMap].filter(Boolean),
     })
 
-    if (debug) {
-      logEdgeManifest({ manifest, logs, debug })
-    }
+    systemLog('Edge Functions manifest:', manifest)
   } catch (error) {
     tagBundlingError(error)
 

package/src/steps/core_step.js

@@ -27,6 +27,7 @@ export const fireCoreStep = async function ({
   redirectsPath,
   featureFlags,
   debug,
+  systemLog,
   saveConfig,
 }) {
   try {
@@ -54,6 +55,7 @@ export const fireCoreStep = async function ({
       redirectsPath,
       featureFlags,
       debug,
+      systemLog,
       saveConfig,
     })
     const {

package/src/steps/run_step.js

@@ -48,6 +48,7 @@ export const runStep = async function ({
   redirectsPath,
   logs,
   debug,
+  systemLog,
   verbose,
   saveConfig,
   timers,
@@ -109,6 +110,7 @@ export const runStep = async function ({
     error,
     logs,
     debug,
+    systemLog,
     verbose,
     saveConfig,
     timers,
@@ -140,6 +142,7 @@ export const runStep = async function ({
     redirectsPath: redirectsPathA,
     logs,
     debug,
+    systemLog,
     timers: timersA,
     durationNs,
     testOpts,
@@ -237,6 +240,7 @@ const tFireStep = function ({
   error,
   logs,
   debug,
+  systemLog,
   verbose,
   saveConfig,
   errorParams,
@@ -271,6 +275,7 @@ const tFireStep = function ({
       redirectsPath,
       featureFlags,
       debug,
+      systemLog,
       saveConfig,
     })
   }
@@ -294,6 +299,7 @@ const tFireStep = function ({
     error,
     logs,
     debug,
+    systemLog,
     verbose,
   })
 }

package/src/steps/run_steps.js

@@ -34,6 +34,7 @@ export const runSteps = async function ({
   configOpts,
   logs,
   debug,
+  systemLog,
   verbose,
   saveConfig,
   timers,
@@ -127,6 +128,7 @@ export const runSteps = async function ({
         redirectsPath: redirectsPathA,
         logs,
         debug,
+        systemLog,
         verbose,
         saveConfig,
         timers: timersA,

package/src/log/messages/edge_manifest.js

@@ -1,7 +0,0 @@
-import { logMessage, logSubHeader } from '../logger.js'
-
-export const logEdgeManifest = ({ logs, manifest }) => {
-  logSubHeader(logs, 'Edge Functions Manifest')
-  logMessage(logs, JSON.stringify(manifest))
-  logMessage(logs, '')
-}