@netlify/build 27.20.4 → 27.20.5

package/lib/steps/run_step.js

@@ -1,154 +1,90 @@
-import { addMutableConstants } from '../core/constants.js'
-import { logStepStart } from '../log/messages/steps.js'
-import { runsAlsoOnBuildFailure, runsOnlyOnBuildFailure } from '../plugins/events.js'
-import { measureDuration, normalizeTimerName } from '../time/main.js'
-
-import { fireCoreStep } from './core_step.js'
-import { firePluginStep } from './plugin.js'
-import { getStepReturn } from './return.js'
-
+import { addMutableConstants } from '../core/constants.js';
+import { logStepStart } from '../log/messages/steps.js';
+import { runsAlsoOnBuildFailure, runsOnlyOnBuildFailure } from '../plugins/events.js';
+import { measureDuration, normalizeTimerName } from '../time/main.js';
+import { fireCoreStep } from './core_step.js';
+import { firePluginStep } from './plugin.js';
+import { getStepReturn } from './return.js';
 // Run a step (core, build command or plugin)
-export const runStep = async function ({
-  event,
-  childProcess,
-  packageName,
-  coreStep,
-  coreStepId,
-  coreStepName,
-  coreStepDescription,
-  pluginPackageJson,
-  loadedFrom,
-  origin,
-  condition,
-  configPath,
-  buildDir,
-  repositoryRoot,
-  nodePath,
-  index,
-  childEnv,
-  context,
-  branch,
-  envChanges,
-  constants,
-  steps,
-  buildbotServerSocket,
-  events,
-  mode,
-  api,
-  errorMonitor,
-  deployId,
-  errorParams,
-  error,
-  failedPlugins,
-  configOpts,
-  netlifyConfig,
-  configMutations,
-  headersPath,
-  redirectsPath,
-  logs,
-  debug,
-  systemLog,
-  verbose,
-  saveConfig,
-  timers,
-  testOpts,
-  featureFlags,
-}) {
-  const constantsA = await addMutableConstants({ constants, buildDir, netlifyConfig })
-
-  if (
-    !(await shouldRunStep({
-      event,
-      packageName,
-      error,
-      failedPlugins,
-      netlifyConfig,
-      condition,
-      constants: constantsA,
-      buildbotServerSocket,
-      buildDir,
-    }))
-  ) {
-    return {}
-  }
-
-  logStepStart({ logs, event, packageName, coreStepDescription, index, error, netlifyConfig })
-
-  const fireStep = getFireStep(packageName, coreStepId, event)
-  const {
-    newEnvChanges,
-    netlifyConfig: netlifyConfigA = netlifyConfig,
-    configMutations: configMutationsA = configMutations,
-    headersPath: headersPathA = headersPath,
-    redirectsPath: redirectsPathA = redirectsPath,
-    newError,
-    newStatus,
-    timers: timersA,
-    durationNs,
-  } = await fireStep({
-    event,
-    childProcess,
-    packageName,
-    pluginPackageJson,
-    loadedFrom,
-    origin,
-    coreStep,
-    coreStepName,
-    configPath,
-    buildDir,
-    repositoryRoot,
-    nodePath,
-    childEnv,
-    context,
-    branch,
-    envChanges,
-    constants: constantsA,
-    steps,
-    buildbotServerSocket,
-    events,
-    error,
-    logs,
-    debug,
-    systemLog,
-    verbose,
-    saveConfig,
-    timers,
-    errorParams,
-    configOpts,
-    netlifyConfig,
-    configMutations,
-    headersPath,
-    redirectsPath,
-    featureFlags,
-  })
-
-  const newValues = await getStepReturn({
-    event,
-    packageName,
-    newError,
-    newEnvChanges,
-    newStatus,
-    coreStep,
-    coreStepName,
-    childEnv,
-    mode,
-    api,
-    errorMonitor,
-    deployId,
-    netlifyConfig: netlifyConfigA,
-    configMutations: configMutationsA,
-    headersPath: headersPathA,
-    redirectsPath: redirectsPathA,
-    logs,
-    debug,
-    systemLog,
-    timers: timersA,
-    durationNs,
-    testOpts,
-  })
-  return { ...newValues, newIndex: index + 1 }
-}
-
+export const runStep = async function ({ event, childProcess, packageName, coreStep, coreStepId, coreStepName, coreStepDescription, pluginPackageJson, loadedFrom, origin, condition, configPath, buildDir, repositoryRoot, nodePath, index, childEnv, context, branch, envChanges, constants, steps, buildbotServerSocket, events, mode, api, errorMonitor, deployId, errorParams, error, failedPlugins, configOpts, netlifyConfig, configMutations, headersPath, redirectsPath, logs, debug, systemLog, verbose, saveConfig, timers, testOpts, featureFlags, }) {
+    const constantsA = await addMutableConstants({ constants, buildDir, netlifyConfig });
+    if (!(await shouldRunStep({
+        event,
+        packageName,
+        error,
+        failedPlugins,
+        netlifyConfig,
+        condition,
+        constants: constantsA,
+        buildbotServerSocket,
+        buildDir,
+    }))) {
+        return {};
+    }
+    logStepStart({ logs, event, packageName, coreStepDescription, index, error, netlifyConfig });
+    const fireStep = getFireStep(packageName, coreStepId, event);
+    const { newEnvChanges, netlifyConfig: netlifyConfigA = netlifyConfig, configMutations: configMutationsA = configMutations, headersPath: headersPathA = headersPath, redirectsPath: redirectsPathA = redirectsPath, newError, newStatus, timers: timersA, durationNs, } = await fireStep({
+        event,
+        childProcess,
+        packageName,
+        pluginPackageJson,
+        loadedFrom,
+        origin,
+        coreStep,
+        coreStepName,
+        configPath,
+        buildDir,
+        repositoryRoot,
+        nodePath,
+        childEnv,
+        context,
+        branch,
+        envChanges,
+        constants: constantsA,
+        steps,
+        buildbotServerSocket,
+        events,
+        error,
+        logs,
+        debug,
+        systemLog,
+        verbose,
+        saveConfig,
+        timers,
+        errorParams,
+        configOpts,
+        netlifyConfig,
+        configMutations,
+        headersPath,
+        redirectsPath,
+        featureFlags,
+    });
+    const newValues = await getStepReturn({
+        event,
+        packageName,
+        newError,
+        newEnvChanges,
+        newStatus,
+        coreStep,
+        coreStepName,
+        childEnv,
+        mode,
+        api,
+        errorMonitor,
+        deployId,
+        netlifyConfig: netlifyConfigA,
+        configMutations: configMutationsA,
+        headersPath: headersPathA,
+        redirectsPath: redirectsPathA,
+        logs,
+        debug,
+        systemLog,
+        timers: timersA,
+        durationNs,
+        testOpts,
+    });
+    return { ...newValues, newIndex: index + 1 };
+};
 // A plugin fails _without making the build fail_ when either:
 //   - using `utils.build.failPlugin()`
 //   - the failure happens after deploy. This means: inside any `onError`,
@@ -180,125 +116,73 @@ export const runStep = async function ({
 // or available. However, one might be created by a build plugin, in which case,
 // those core plugins should be triggered. We use a dynamic `condition()` to
 // model this behavior.
-const shouldRunStep = async function ({
-  event,
-  packageName,
-  error,
-  failedPlugins,
-  netlifyConfig,
-  condition,
-  constants,
-  buildbotServerSocket,
-  buildDir,
-}) {
-  if (
-    failedPlugins.includes(packageName) ||
-    (condition !== undefined && !(await condition({ buildDir, constants, buildbotServerSocket, netlifyConfig })))
-  ) {
-    return false
-  }
-
-  if (error !== undefined) {
-    return runsAlsoOnBuildFailure(event)
-  }
-
-  return !runsOnlyOnBuildFailure(event)
-}
-
+const shouldRunStep = async function ({ event, packageName, error, failedPlugins, netlifyConfig, condition, constants, buildbotServerSocket, buildDir, }) {
+    if (failedPlugins.includes(packageName) ||
+        (condition !== undefined && !(await condition({ buildDir, constants, buildbotServerSocket, netlifyConfig })))) {
+        return false;
+    }
+    if (error !== undefined) {
+        return runsAlsoOnBuildFailure(event);
+    }
+    return !runsOnlyOnBuildFailure(event);
+};
 // Wrap step function to measure its time
 const getFireStep = function (packageName, coreStepId, event) {
-  if (coreStepId !== undefined) {
-    return measureDuration(tFireStep, coreStepId)
-  }
-
-  const parentTag = normalizeTimerName(packageName)
-  return measureDuration(tFireStep, event, { parentTag, category: 'pluginEvent' })
-}
-
-const tFireStep = function ({
-  event,
-  childProcess,
-  packageName,
-  pluginPackageJson,
-  loadedFrom,
-  origin,
-  coreStep,
-  coreStepName,
-  configPath,
-  buildDir,
-  repositoryRoot,
-  nodePath,
-  childEnv,
-  context,
-  branch,
-  envChanges,
-  constants,
-  steps,
-  buildbotServerSocket,
-  events,
-  error,
-  logs,
-  debug,
-  systemLog,
-  verbose,
-  saveConfig,
-  errorParams,
-  configOpts,
-  netlifyConfig,
-  configMutations,
-  headersPath,
-  redirectsPath,
-  featureFlags,
-}) {
-  if (coreStep !== undefined) {
-    return fireCoreStep({
-      coreStep,
-      coreStepName,
-      configPath,
-      buildDir,
-      repositoryRoot,
-      constants,
-      buildbotServerSocket,
-      events,
-      logs,
-      nodePath,
-      childEnv,
-      context,
-      branch,
-      envChanges,
-      errorParams,
-      configOpts,
-      netlifyConfig,
-      configMutations,
-      headersPath,
-      redirectsPath,
-      featureFlags,
-      debug,
-      systemLog,
-      saveConfig,
-    })
-  }
-
-  return firePluginStep({
-    event,
-    childProcess,
-    packageName,
-    pluginPackageJson,
-    loadedFrom,
-    origin,
-    envChanges,
-    errorParams,
-    configOpts,
-    netlifyConfig,
-    configMutations,
-    headersPath,
-    redirectsPath,
-    constants,
-    steps,
-    error,
-    logs,
-    debug,
-    systemLog,
-    verbose,
-  })
-}
+    if (coreStepId !== undefined) {
+        return measureDuration(tFireStep, coreStepId);
+    }
+    const parentTag = normalizeTimerName(packageName);
+    return measureDuration(tFireStep, event, { parentTag, category: 'pluginEvent' });
+};
+const tFireStep = function ({ event, childProcess, packageName, pluginPackageJson, loadedFrom, origin, coreStep, coreStepName, configPath, buildDir, repositoryRoot, nodePath, childEnv, context, branch, envChanges, constants, steps, buildbotServerSocket, events, error, logs, debug, systemLog, verbose, saveConfig, errorParams, configOpts, netlifyConfig, configMutations, headersPath, redirectsPath, featureFlags, }) {
+    if (coreStep !== undefined) {
+        return fireCoreStep({
+            coreStep,
+            coreStepName,
+            configPath,
+            buildDir,
+            repositoryRoot,
+            constants,
+            buildbotServerSocket,
+            events,
+            logs,
+            nodePath,
+            childEnv,
+            context,
+            branch,
+            envChanges,
+            errorParams,
+            configOpts,
+            netlifyConfig,
+            configMutations,
+            headersPath,
+            redirectsPath,
+            featureFlags,
+            debug,
+            systemLog,
+            saveConfig,
+        });
+    }
+    return firePluginStep({
+        event,
+        childProcess,
+        packageName,
+        pluginPackageJson,
+        loadedFrom,
+        origin,
+        envChanges,
+        errorParams,
+        configOpts,
+        netlifyConfig,
+        configMutations,
+        headersPath,
+        redirectsPath,
+        constants,
+        steps,
+        error,
+        logs,
+        debug,
+        systemLog,
+        verbose,
+    });
+};