@netlify/build 19.0.5 → 19.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netlify/build",
-  "version": "19.0.5",
+  "version": "19.0.6",
   "description": "Netlify build module",
   "main": "src/core/main.js",
   "types": "types/index.d.ts",
@@ -36,8 +36,8 @@
     "ci",
     "plugins",
     "continuous-integration",
-    "continuous-delivery",
     "continuous-deployment",
+    "continuous-delivery",
     "continuous-testing",
     "netlify-plugin",
     "netlify"

package/src/error/build.js

@@ -5,7 +5,8 @@ const safeJsonStringify = require('safe-json-stringify')
 const { CUSTOM_ERROR_KEY } = require('./info')
 
 // Retrieve error information from child process and re-build it in current
-// process. We need this since errors are not JSON-serializable.
+// process. We need this since errors static properties are not kept by
+// `v8.serialize()`.
 const jsonToError = function ({ name, message, stack, ...errorProps }) {
   // eslint-disable-next-line unicorn/error-message
   const error = new Error('')
@@ -35,8 +36,6 @@ const assignErrorProp = function (error, name, value) {
 }
 
 // Inverse of `jsonToError()`.
-// IPC uses JSON for the payload. We ensure there are not circular references
-// as those would make the message sending fail.
 const errorToJson = function ({ name, message, stack, [CUSTOM_ERROR_KEY]: customError, ...errorProps }) {
   return {
     ...safeJsonStringify.ensureProperties(errorProps),

package/src/plugins/child/load.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const filterObj = require('filter-obj')
+
 const { getLogic } = require('./logic')
 const { registerTypeScript } = require('./typescript')
 const { validatePlugin } = require('./validate')
@@ -15,21 +17,16 @@ const load = function ({ pluginPath, inputs, packageJson }) {
 
   validatePlugin(logic)
 
-  const pluginSteps = getPluginSteps(logic)
+  const methods = filterObj(logic, isEventHandler)
+  const events = Object.keys(methods)
 
   // Context passed to every event handler
-  const context = { pluginSteps, inputs, packageJson }
-
-  return { pluginSteps, context }
-}
+  const context = { methods, inputs, packageJson }
 
-const getPluginSteps = function (logic) {
-  return Object.entries(logic)
-    .filter(isEventHandler)
-    .map(([event, method]) => ({ event, method }))
+  return { events, context }
 }
 
-const isEventHandler = function ([, value]) {
+const isEventHandler = function (event, value) {
   return typeof value === 'function'
 }
 

package/src/plugins/child/run.js

@@ -6,11 +6,8 @@ const { cloneNetlifyConfig, getConfigMutations } = require('./diff')
 const { getUtils } = require('./utils')
 
 // Run a specific plugin event handler
-const run = async function (
-  { event, error, constants, envChanges, netlifyConfig },
-  { pluginSteps, inputs, packageJson },
-) {
-  const { method } = pluginSteps.find((pluginStep) => pluginStep.event === event)
+const run = async function ({ event, error, constants, envChanges, netlifyConfig }, { methods, inputs, packageJson }) {
+  const method = methods[event]
   const runState = {}
   const utils = getUtils({ event, constants, runState })
   const netlifyConfigCopy = cloneNetlifyConfig(netlifyConfig)

package/src/plugins/ipc.js

@@ -113,10 +113,9 @@ const sendEventToParent = async function (callId, payload) {
   await promisify(process.send.bind(process))([callId, payload])
 }
 
-// Errors are not serializable through `child_process` `ipc` so we need to
-// convert from/to plain objects.
-// TODO: use `child_process.spawn()` `serialization: 'advanced'` option after
-// dropping support for Node.js <=12.6.0
+// Error static properties are not serializable through `child_process`
+// (which uses `v8.serialize()` under the hood) so we need to convert from/to
+// plain objects.
 const serializePayload = function ({ error = {}, error: { name } = {}, ...payload }) {
   if (name === undefined) {
     return payload

package/src/plugins/load.js

@@ -37,8 +37,8 @@ const loadPlugin = async function (
   const loadEvent = 'load'
 
   try {
-    const { pluginSteps } = await callChild(childProcess, 'load', { pluginPath, inputs, packageJson })
-    const pluginStepsA = pluginSteps.map(({ event }) => ({
+    const { events } = await callChild(childProcess, 'load', { pluginPath, inputs, packageJson })
+    const pluginSteps = events.map((event) => ({
       event,
       packageName,
       loadedFrom,
@@ -46,7 +46,7 @@ const loadPlugin = async function (
       pluginPackageJson,
       childProcess,
     }))
-    return pluginStepsA
+    return pluginSteps
   } catch (error) {
     addErrorInfo(error, {
       plugin: { packageName, pluginPackageJson },

package/src/plugins/spawn.js

@@ -39,6 +39,7 @@ const startPlugin = async function ({ pluginDir, nodePath, buildDir, childEnv })
     execPath: nodePath,
     env: childEnv,
     extendEnv: false,
+    serialization: 'advanced',
   })
 
   try {