@netless/window-manager 0.4.28 → 0.4.29

package/docs/api.md

@@ -218,9 +218,11 @@ manager.addPage({ scene: { name: "page2" } }) // 传入 page 信息
 <h3 id="removePage">removePage</h3>
 
 > 移除一页
+> 当只剩一页时, 最后一页不允许被删除
 
 ```ts
-const success = await manager.removePage(1)
+const success = await manager.removePage() // 默认删除当前页
+const success = await manager.removePage(1) // 可以删除指定 index
 ```
 
 <h3 id="refresh">refresh</h3>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netless/window-manager",
-  "version": "0.4.28",
+  "version": "0.4.29",
   "description": "",
   "main": "dist/index.cjs.js",
   "module": "dist/index.es.js",

package/src/App/AppContext.ts

@@ -231,13 +231,17 @@ export class AppContext<TAttributes = any, TMagixEventPayloads = any, TAppOption
         }
     };
 
-    public removePage = async (index: number): Promise<boolean> => {
-        if (index < 0 || index >= this.pageState.length) {
+    public removePage = async (index?: number): Promise<boolean> => {
+        const needRemoveIndex = index === undefined ? this.pageState.index : index;
+        if (this.pageState.length === 1) {
+            console.warn(`[WindowManager]: can not remove the last page`);
+            return false;
+        }
+        if (needRemoveIndex < 0 || needRemoveIndex >= this.pageState.length) {
             console.warn(`[WindowManager]: page index ${index} out of range`);
             return false;
         }
-        this.appProxy.removeSceneByIndex(index);
-        return true;
+        return this.appProxy.removeSceneByIndex(needRemoveIndex);;
     }
 
     public get pageState(): PageState {

package/src/App/AppProxy.ts

@@ -27,7 +27,8 @@ import type { SceneState, View, SceneDefinition } from "white-web-sdk";
 import type { AppManager } from "../AppManager";
 import type { NetlessApp } from "../typings";
 import type { ReadonlyTeleBox } from "@netless/telebox-insider";
-import { calculateNextIndex, PageRemoveService, PageState } from "../Page";
+import type { PageRemoveService, PageState } from "../Page";
+import { calculateNextIndex } from "../Page";
 
 export type AppEmitter = Emittery<AppEmitterEvent>;
 
@@ -415,10 +416,6 @@ export class AppProxy implements PageRemoveService {
     public async removeSceneByIndex(index: number) {
         const scenePath = this._pageState.getFullPath(index);
         if (scenePath) {
-            // 不能删除所有场景
-            if (this.pageState.length <= 1) {
-                return false;
-            }
             const nextIndex = calculateNextIndex(index, this.pageState);
             // 只修改 focus path 不修改 FullPath
             this.setSceneIndexWithoutSync(nextIndex);

package/src/index.ts

@@ -537,17 +537,23 @@ export class WindowManager extends InvisiblePlugin<WindowMangerAttributes> imple
         }
     }
 
-    public async removePage(index: number): Promise<boolean> {
+    /**
+     * 删除一页
+     * 默认删除当前页, 可以删除指定 index 页
+     * 最低保留一页
+     */
+    public async removePage(index?: number): Promise<boolean> {
         if (this.appManager) {
+            const needRemoveIndex = index === undefined ? this.pageState.index : index;
             if (this.pageState.length === 1) {
                 console.warn(`[WindowManager]: can not remove the last page`);
                 return false;
             }
-            if (index < 0 || index >= this.pageState.length) {
+            if (needRemoveIndex < 0 || needRemoveIndex >= this.pageState.length) {
                 console.warn(`[WindowManager]: index ${index} out of range`);
                 return false;
             }
-            return this.appManager.removeSceneByIndex(index);;
+            return this.appManager.removeSceneByIndex(needRemoveIndex);;
         } else {
             return false;
         }