@netless/app-presentation 0.1.9-beta.4 → 0.1.9-beta.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netless/app-presentation",
-  "version": "0.1.9-beta.4",
+  "version": "0.1.9-beta.5",
   "description": "Netless App for presentation slides (images)",
   "author": "netless",
   "license": "MIT",

package/src/scrollbar/index.ts

@@ -69,9 +69,8 @@ export class Scrollbar {
 
     setReadonly(bol: boolean){
         this.readonly = bol;
-        if (this.readonly) {
-            this.destroy()
-        } else {
+        this.destroy()
+        if (!this.readonly) {
             this.init();
         }
     }
@@ -219,15 +218,27 @@ export class Scrollbar {
 
     destroy() {
         this.view.callbacks.off('onCameraUpdated', this.onCameraUpdated);
-        this.scrollbarX?.remove();
-        this.scrollbarY?.remove();
-        this.scrollbarX = undefined;
-        this.scrollbarY = undefined;
-
-        this.draggableX?.destroy();
-        this.draggableY?.destroy();
-        this.draggableX = undefined;
-        this.draggableY = undefined;
+        if (this.scrollbarX && this.scrollbarContainerX) {
+            this.scrollbarContainerX.removeChild(this.scrollbarX);
+            this.scrollbarX.remove();
+            this.scrollbarContainerX.remove();
+            this.scrollbarX = undefined;
+        }
+        if (this.scrollbarY && this.scrollbarContainerY) {
+            this.scrollbarContainerY.removeChild(this.scrollbarY);
+            this.scrollbarY.remove();
+            this.scrollbarContainerY.remove();
+            this.scrollbarY = undefined;
+        }
+        if (this.draggableX) {
+            this.draggableX.destroy();
+            this.draggableX = undefined;
+        }
+        if (this.draggableY) {
+            this.draggableY.destroy();
+            this.draggableY = undefined;
+        }
+
     }
 
 }