@netflix/nerror 1.1.2 → 2.0.0-rc.0

package/lib/index.d.ts

@@ -11,7 +11,7 @@ export class VError extends Error {
     ): null | T | VError.MultiError;
     static errorForEach(err: Error, func: (err: Error) => void): void;
 
-    cause(): Error | undefined;
+    cause: Error | undefined;
     constructor(
         options: VError.Options | Error,
         message: string,

package/lib/verror.js

@@ -134,7 +134,10 @@ function parseConstructorArguments(args) {
 
     if (sprintf_args.length === 0) {
         shortmessage = '';
-    } else if (options.skipPrintf) {
+    } else if (
+        options.skipPrintf ||
+        (sprintf_args.length === 1 && typeof sprintf_args[0] === 'string')
+    ) {
         assert.equal(
             sprintf_args.length,
             1,
@@ -248,7 +251,12 @@ function VError(...args) {
     const cause = parsed.options.cause;
     if (cause) {
         VError._assertError(cause, '"cause" must be an Error');
-        this.jse_cause = cause;
+        Object.defineProperty(this, 'cause', {
+            enumerable: false,
+            configurable: true,
+            writable: true,
+            value: cause
+        });
 
         if (!parsed.options.skipCauseMessage) {
             message += ': ' + cause.message;
@@ -324,19 +332,6 @@ VError.prototype.toString = function ve_toString() {
     return str;
 };
 
-/**
- * This method is provided for compatibility.  New callers should use
- * VError.cause() instead.  That method also uses the saner `null` return value
- * when there is no cause.
- * @public
- * @memberof VError.prototype
- * @return {undefined|Error} Error cause if any
- */
-VError.prototype.cause = function ve_cause() {
-    const cause = VError.cause(this);
-    return cause === null ? undefined : cause;
-};
-
 /*
  * Static methods
  *
@@ -416,7 +411,7 @@ VError.assignInfo = function assignInfo(err, obj) {
  */
 VError.cause = function cause(err) {
     VError._assertError(err);
-    return _.isError(err.jse_cause) ? err.jse_cause : null;
+    return _.isError(err.cause) ? err.cause : null;
 };
 
 /**
@@ -786,25 +781,9 @@ WError.prototype.toString = function we_toString() {
     if (this.message) {
         str += ': ' + this.message;
     }
-    if (this.jse_cause && this.jse_cause.message) {
-        str += '; caused by ' + this.jse_cause.toString();
+    if (this.cause && this.cause.message) {
+        str += '; caused by ' + this.cause.toString();
     }
 
     return str;
 };
-
-/**
- * For purely historical reasons, WError's cause() function allows you to set
- * the cause.
- * @public
- * @memberof WError.prototype
- * @param {Error} c - cause
- * @return {undefined|Error} Error cause
- */
-WError.prototype.cause = function we_cause(c) {
-    if (_.isError(c)) {
-        this.jse_cause = c;
-    }
-
-    return this.jse_cause;
-};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@netflix/nerror",
-  "version": "1.1.2",
+  "version": "2.0.0-rc.0",
   "main": "lib/index.js",
   "description": "Rich errors",
   "homepage": "https://github.com/Netflix/nerror",
@@ -9,6 +9,9 @@
     "url": "https://github.com/Netflix/nerror"
   },
   "license": "MIT",
+  "engines": {
+    "node": ">=20"
+  },
   "files": [
     "lib",
     "lib/index.d.ts"
@@ -31,7 +34,7 @@
     "mocha": "^5.2.0",
     "nyc": "^12.0.2",
     "prettier": "^1.13.5",
-    "tsd": "^0.7.3",
+    "tsd": "^0.33.0",
     "unleash": "^2.0.1"
   },
   "dependencies": {

package/CHANGELOG.md

@@ -1,32 +0,0 @@
-<a name="1.1.2"></a>
-### 1.1.2 (2019-07-26)
-
-
-<a name="1.1.1"></a>
-### 1.1.1 (2019-07-09)
-
-
-<a name="1.1.0"></a>
-## 1.1.0 (2019-05-06)
-
-
-#### Features
-
-* **errorForEach:** make it MultiError support more general (#2) ([96cc8769](https://github.com/Netflix/nerror/commit/96cc8769))
-
-
-<a name="1.0.0"></a>
-## 1.0.0 (2019-05-02)
-
-
-#### Features
-
-* **nerror:** initial commit ([c959d4fc](https://github.com/Netflix/nerror/commit/c959d4fc))
-
-
-#### Breaking Changes
-
-* initial release
-
- ([6ae8bd30](https://github.com/Netflix/nerror/commit/6ae8bd30))
-