@net-mesh/browser 0.45.0 → 0.45.1

package/CHANGELOG.md

@@ -14,6 +14,26 @@ missing method at the call site rather than at install time. Unlike
 `@net-mesh/sdk`, this package never depends on `@net-mesh/core` — see
 the README on why it is a sibling package rather than a sub-path.
 
+## 0.45.1 — a closed stream keeps hearing its peer
+
+- **Closing a stream no longer silences its peer.** After `close()`, frames
+  the peer still sends on that label reach `node.onEvent` as `stream_data`,
+  exactly as for a stream the page never opened. Before, the node dropped
+  them (counted `drops.stream_closed`) until the page reopened the stream,
+  so closing a stream was worse than never opening it. `stream_closed` is
+  no longer counted and reads 0.
+- **A timed-out netcode player can rejoin.** `hostNetcode` closes a
+  player's stream when it times the player out, and only learns about a
+  player from its frames, so the change above was what locked a timed-out
+  player out for good. It is now re-admitted when heard again and carries
+  on from where it was applied.
+- **A player cut off from its host stays quiet.** `joinNetcode` keeps at
+  most the newest 64 unacknowledged inputs (older ones were never sent
+  again anyway), keeps every input frame under one event (8,000 bytes) so
+  it never rides as fragments, and while the host has said nothing for a
+  second repeats its inputs only at the ping rate instead of with every
+  input. A cut-off player used to upload about 700 kB/s.
+
 ## 0.44.0 — sharded matches, compact snapshots
 
 - **`joinShards` merges a match split across several hosts** (topology A:

package/dist/net_leaf.js

@@ -2740,6 +2740,9 @@ function __wbg_get_imports() {
             const ret = getObject(arg0).errorCode;
             return ret;
         },
+        __wbg_error_0b48a92af341cfbc: function(arg0, arg1) {
+            console.error(getStringFromWasm0(arg0, arg1));
+        },
         __wbg_error_3da0c81bd4184d52: function(arg0) {
             const ret = getObject(arg0).error;
             return isLikeNone(ret) ? 0 : addHeapObject(ret);
@@ -2748,9 +2751,6 @@ function __wbg_get_imports() {
             const ret = getObject(arg0).error;
             return isLikeNone(ret) ? 0 : addHeapObject(ret);
         }, arguments); },
-        __wbg_error_6bdb7b2cf1241109: function(arg0, arg1) {
-            console.error(getStringFromWasm0(arg0, arg1));
-        },
         __wbg_fetch_4178962c570137ca: function(arg0, arg1, arg2) {
             const ret = getObject(arg0).fetch(getStringFromWasm0(arg1, arg2));
             return addHeapObject(ret);

package/dist/netcode/client.js

@@ -34,6 +34,20 @@ export class NetcodeError extends Error {
  * ticks, and a host skips the gap the earlier frame would have filled.
  */
 const MAX_INPUT_BACKLOG = 64;
+/**
+ * Largest input frame, bytes. Under one event, as the host's snapshot
+ * default is, so an input frame never rides as fragments: on the lossy
+ * carrier one lost fragment loses the whole frame. A backlog that does not
+ * fit sends its newest inputs.
+ */
+const MAX_INPUT_FRAME_BYTES = 8000;
+/**
+ * How long the host may say nothing before input frames stop going out at
+ * the input rate, ms. While it is silent, unacknowledged inputs are repeated
+ * only on the ping timer: a player cut off from its host used to send its
+ * whole backlog, as fragments, with every input (~700 kB/s, net-fps report).
+ */
+const HOST_SILENT_MS = 1000;
 /** A fresh {@link InputSequencer}: `seq` 0, nothing pending. */
 export function createInputSequencer() {
     return { seq: 0, pending: [] };
@@ -121,11 +135,23 @@ export function joinNetcode(options) {
     let lastSnapshotAt = null;
     const inputEpoch = () => (options.epoch === undefined ? {} : { ep: options.epoch() });
     // The newest `redundancy` inputs — or, past that, the whole backlog up to
-    // MAX_INPUT_BACKLOG, in one frame.
+    // MAX_INPUT_BACKLOG, in one frame of at most MAX_INPUT_FRAME_BYTES. A
+    // backlog too big for one frame sends its newest inputs: a host skips
+    // whatever an earlier frame would have filled anyway.
     const sendInputs = () => {
-        const count = inputs.pending.length > redundancy ? MAX_INPUT_BACKLOG : redundancy;
-        send({ n: label, k: 'i', i: inputs.pending.slice(-count), ...inputEpoch() });
+        let count = Math.min(inputs.pending.length, inputs.pending.length > redundancy ? MAX_INPUT_BACKLOG : redundancy);
+        for (;;) {
+            const bytes = encodeFrame({ n: label, k: 'i', i: inputs.pending.slice(-count), ...inputEpoch() });
+            if (bytes.byteLength <= MAX_INPUT_FRAME_BYTES || count <= 1) {
+                sendBytes(bytes);
+                return;
+            }
+            count = Math.max(1, Math.min(count - 1, Math.floor((count * MAX_INPUT_FRAME_BYTES) / bytes.byteLength)));
+        }
     };
+    // When the host was last heard from: any frame of this label, or binary.
+    let hostHeardAt = now();
+    const hostSilent = () => now() - hostHeardAt > HOST_SILENT_MS;
     const offset = () => clock.estimate()?.offsetMs ?? null;
     const hostNow = () => {
         const o = offset();
@@ -191,7 +217,8 @@ export function joinNetcode(options) {
     // replaced (a reconnect, a relayed → direct upgrade) and a stream handle
     // is fenced to the session it was opened on. The protocol repeats what
     // was lost, so reopening is all recovery needs.
-    const send = (frame) => {
+    const send = (frame) => sendBytes(encodeFrame(frame));
+    const sendBytes = (payload) => {
         const current = stream;
         if (current === null) {
             void open();
@@ -211,7 +238,7 @@ export function joinNetcode(options) {
             }
         };
         try {
-            void Promise.resolve(current.send(encodeFrame(frame))).catch(retire);
+            void Promise.resolve(current.send(payload)).catch(retire);
         }
         catch (error) {
             retire(error);
@@ -223,12 +250,14 @@ export function joinNetcode(options) {
         if (eventPeer(event.peerNode) !== host)
             return;
         if (isBinaryFrame(event.payload)) {
+            hostHeardAt = now();
             onBinary(event.payload);
             return;
         }
         const frame = decodeFrame(event.payload, label);
         if (frame === null)
             return;
+        hostHeardAt = now();
         if (frame.k === 'q') {
             clock.add(frame.t0, frame.t1, frame.t2, now());
             return;
@@ -492,12 +521,18 @@ export function joinNetcode(options) {
             const seq = inputs.seq;
             const seen = (hostNow() ?? now()) - delay;
             inputs.pending.push({ seq, seen, data });
+            // Only the newest MAX_INPUT_BACKLOG are ever sent again, so older
+            // ones are dropped rather than held (and replayed) until an ack.
+            if (inputs.pending.length > MAX_INPUT_BACKLOG)
+                inputs.pending.splice(0, inputs.pending.length - MAX_INPUT_BACKLOG);
             if (options.local && predicted !== null) {
                 predicted = options.local.predict(predicted, data);
                 if (correcting !== null)
                     correcting = { ...correcting, from: options.local.predict(correcting.from, data) };
             }
-            sendInputs();
+            // A silent host gets the backlog from the ping timer, not per input.
+            if (!hostSilent())
+                sendInputs();
         },
         view() {
             const at = hostNow();

package/dist/stream.d.ts

@@ -179,7 +179,14 @@ export declare class LeafStream implements AsyncIterable<Uint8Array> {
     /** Listen for payloads. Returns a cancel handle. */
     onMessage(listener: (payload: Uint8Array) => void): () => void;
     [Symbol.asyncIterator](): AsyncIterableIterator<Uint8Array>;
-    /** Close the stream and end every consumer. */
+    /**
+     * Close the stream and end every consumer.
+     *
+     * Close is local: the peer's half is its own. Frames the peer still
+     * sends on this label reach `node.onEvent` as `stream_data`, exactly as
+     * for a stream this page never opened. Before 0.45.1 the node dropped
+     * them (`drops.stream_closed`) until the stream was reopened.
+     */
     close(): void;
     /**
      * One callback from the wasm boundary.

package/dist/stream.js

@@ -176,7 +176,14 @@ export class LeafStream {
         this.retiredBy = reason;
         this.close();
     }
-    /** Close the stream and end every consumer. */
+    /**
+     * Close the stream and end every consumer.
+     *
+     * Close is local: the peer's half is its own. Frames the peer still
+     * sends on this label reach `node.onEvent` as `stream_data`, exactly as
+     * for a stream this page never opened. Before 0.45.1 the node dropped
+     * them (`drops.stream_closed`) until the stream was reopened.
+     */
     close() {
         if (this.closed)
             return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@net-mesh/browser",
-  "version": "0.45.0",
+  "version": "0.45.1",
   "description": "Browser-native Net mesh leaf \u2014 idiomatic TypeScript over the net-mesh-leaf wasm node",
   "type": "module",
   "main": "dist/index.js",