@nestjs/core 11.1.5 → 11.1.6

package/injector/injector.js

@@ -11,11 +11,11 @@ const exceptions_1 = require("../errors/exceptions");
 const runtime_exception_1 = require("../errors/exceptions/runtime.exception");
 const undefined_dependency_exception_1 = require("../errors/exceptions/undefined-dependency.exception");
 const unknown_dependencies_exception_1 = require("../errors/exceptions/unknown-dependencies.exception");
+const barrier_1 = require("../helpers/barrier");
 const constants_2 = require("./constants");
 const inquirer_1 = require("./inquirer");
 const instance_wrapper_1 = require("./instance-wrapper");
 const settlement_signal_1 = require("./settlement-signal");
-const barrier_1 = require("../helpers/barrier");
 class Injector {
     constructor(options) {
         this.options = options;
@@ -111,7 +111,7 @@ class Injector {
         return settlementSignal;
     }
     async resolveConstructorParams(wrapper, moduleRef, inject, callback, contextId = constants_2.STATIC_CONTEXT, inquirer, parentInquirer) {
-        let inquirerId = this.getInquirerId(inquirer);
+        const inquirerId = this.getInquirerId(inquirer);
         const metadata = wrapper.getCtorMetadata();
         if (metadata && contextId !== constants_2.STATIC_CONTEXT) {
             const deps = await this.loadCtorMetadata(metadata, contextId, inquirer, parentInquirer);
@@ -133,8 +133,10 @@ class Injector {
                     return parentInquirer && parentInquirer.instance;
                 }
                 if (inquirer?.isTransient && parentInquirer) {
-                    inquirer = parentInquirer;
-                    inquirerId = this.getInquirerId(parentInquirer);
+                    // When `inquirer` is transient too, inherit the parent inquirer
+                    // This is required to ensure that transient providers are only resolved
+                    // when requested
+                    inquirer.attachRootInquirer(parentInquirer);
                 }
                 const paramWrapper = await this.resolveSingleParam(wrapper, param, { index, dependencies }, moduleRef, contextId, inquirer, index);
                 /*
@@ -315,8 +317,11 @@ class Injector {
             const inquirerId = this.getInquirerId(inquirer);
             const instanceHost = instanceWrapperRef.getInstanceByContextId(this.getContextId(contextId, instanceWrapperRef), inquirerId);
             if (!instanceHost.isResolved && !instanceWrapperRef.forwardRef) {
-                wrapper.settlementSignal?.insertRef(instanceWrapperRef.id);
-                await this.loadProvider(instanceWrapperRef, relatedModule, contextId, wrapper);
+                /*
+                 * Provider will be loaded shortly in resolveComponentHost() once we pass the current
+                 * Barrier. We cannot load it here because doing so could incorrectly evaluate the
+                 * staticity of the dependency tree and lead to undefined / null injection.
+                 */
                 break;
             }
         }

package/injector/instance-wrapper.d.ts

@@ -51,6 +51,11 @@ export declare class InstanceWrapper<T = any> {
     private transientMap?;
     private isTreeStatic;
     private isTreeDurable;
+    /**
+     * The root inquirer reference. Present only if child instance wrapper
+     * is transient and has a parent inquirer.
+     */
+    private rootInquirer;
     constructor(metadata?: Partial<InstanceWrapper<T>> & Partial<InstancePerContext<T>>);
     get id(): string;
     set instance(value: T);
@@ -80,6 +85,8 @@ export declare class InstanceWrapper<T = any> {
     isLazyTransient(contextId: ContextId, inquirer: InstanceWrapper | undefined): boolean;
     isExplicitlyRequested(contextId: ContextId, inquirer?: InstanceWrapper): boolean;
     isStatic(contextId: ContextId, inquirer: InstanceWrapper | undefined): boolean;
+    attachRootInquirer(inquirer: InstanceWrapper): void;
+    getRootInquirer(): InstanceWrapper | undefined;
     getStaticTransientInstances(): (InstancePerContext<T> | undefined)[];
     mergeWith(provider: Provider): void;
     private isNewable;

package/injector/instance-wrapper.js

@@ -242,10 +242,22 @@ class InstanceWrapper {
     isStatic(contextId, inquirer) {
         const isInquirerRequestScoped = inquirer && !inquirer.isDependencyTreeStatic();
         const isStaticTransient = this.isTransient && !isInquirerRequestScoped;
+        const rootInquirer = inquirer?.getRootInquirer();
         return (this.isDependencyTreeStatic() &&
             contextId === constants_1.STATIC_CONTEXT &&
             (!this.isTransient ||
-                (isStaticTransient && !!inquirer && !inquirer.isTransient)));
+                (isStaticTransient && !!inquirer && !inquirer.isTransient) ||
+                (isStaticTransient && !!rootInquirer && !rootInquirer.isTransient)));
+    }
+    attachRootInquirer(inquirer) {
+        if (!this.isTransient) {
+            // Only attach root inquirer if the instance wrapper is transient
+            return;
+        }
+        this.rootInquirer = inquirer.getRootInquirer() ?? inquirer;
+    }
+    getRootInquirer() {
+        return this.rootInquirer;
     }
     getStaticTransientInstances() {
         if (!this.transientMap) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nestjs/core",
-  "version": "11.1.5",
+  "version": "11.1.6",
   "description": "Nest - modern, fast, powerful node.js web framework (@core)",
   "author": "Kamil Mysliwiec",
   "license": "MIT",
@@ -39,7 +39,7 @@
     "uid": "2.0.2"
   },
   "devDependencies": {
-    "@nestjs/common": "11.1.5"
+    "@nestjs/common": "11.1.6"
   },
   "peerDependencies": {
     "@nestjs/common": "^11.0.0",