@nestjs/core 11.1.20 → 11.1.22

package/errors/exceptions/invalid-class-module.exception.d.ts

@@ -1,4 +1,4 @@
 import { RuntimeException } from './runtime.exception';
 export declare class InvalidClassModuleException extends RuntimeException {
-    constructor(metatypeUsedAsAModule: any, scope: any[]);
+    constructor(metatypeUsedAsAModule: any, scope: any[], classKind: 'provider' | 'controller' | 'filter');
 }

package/errors/exceptions/invalid-class-module.exception.js

@@ -4,8 +4,8 @@ exports.InvalidClassModuleException = void 0;
 const messages_1 = require("../messages");
 const runtime_exception_1 = require("./runtime.exception");
 class InvalidClassModuleException extends runtime_exception_1.RuntimeException {
-    constructor(metatypeUsedAsAModule, scope) {
-        super((0, messages_1.USING_INVALID_CLASS_AS_A_MODULE_MESSAGE)(metatypeUsedAsAModule, scope));
+    constructor(metatypeUsedAsAModule, scope, classKind) {
+        super((0, messages_1.USING_INVALID_CLASS_AS_A_MODULE_MESSAGE)(metatypeUsedAsAModule, scope, classKind));
     }
 }
 exports.InvalidClassModuleException = InvalidClassModuleException;

package/errors/exceptions/invalid-module.exception.d.ts

@@ -1,4 +1,4 @@
 import { RuntimeException } from './runtime.exception';
 export declare class InvalidModuleException extends RuntimeException {
-    constructor(parentModule: any, index: number, scope: any[]);
+    constructor(parentModule: any, index: number, scope: any[], receivedValue: unknown);
 }

package/errors/exceptions/invalid-module.exception.js

@@ -4,8 +4,8 @@ exports.InvalidModuleException = void 0;
 const messages_1 = require("../messages");
 const runtime_exception_1 = require("./runtime.exception");
 class InvalidModuleException extends runtime_exception_1.RuntimeException {
-    constructor(parentModule, index, scope) {
-        super((0, messages_1.INVALID_MODULE_MESSAGE)(parentModule, index, scope));
+    constructor(parentModule, index, scope, receivedValue) {
+        super((0, messages_1.INVALID_MODULE_MESSAGE)(parentModule, index, scope, receivedValue));
     }
 }
 exports.InvalidModuleException = InvalidModuleException;

package/errors/messages.d.ts

@@ -4,8 +4,8 @@ import { Module } from '../injector/module';
 export declare const UNKNOWN_DEPENDENCIES_MESSAGE: (type: string | symbol, unknownDependencyContext: InjectorDependencyContext, moduleRef: Module | undefined) => string;
 export declare const INVALID_MIDDLEWARE_MESSAGE: (text: TemplateStringsArray, name: string) => string;
 export declare const UNDEFINED_FORWARDREF_MESSAGE: (scope: Type<any>[]) => string;
-export declare const INVALID_MODULE_MESSAGE: (parentModule: any, index: number, scope: any[]) => string;
-export declare const USING_INVALID_CLASS_AS_A_MODULE_MESSAGE: (metatypeUsedAsAModule: Type | ForwardReference, scope: any[]) => string;
+export declare const INVALID_MODULE_MESSAGE: (parentModule: any, index: number, scope: any[], receivedValue: unknown) => string;
+export declare const USING_INVALID_CLASS_AS_A_MODULE_MESSAGE: (metatypeUsedAsAModule: Type | ForwardReference, scope: any[], classKind: "provider" | "controller" | "filter") => string;
 export declare const UNDEFINED_MODULE_MESSAGE: (parentModule: any, index: number, scope: any[]) => string;
 export declare const UNKNOWN_EXPORT_MESSAGE: (token: string | symbol | undefined, module: string) => string;
 export declare const INVALID_CLASS_MESSAGE: (text: TemplateStringsArray, value: any) => string;

package/errors/messages.js

@@ -117,18 +117,44 @@ const UNDEFINED_FORWARDREF_MESSAGE = (scope) => `Nest cannot create the module i
 Scope [${stringifyScope(scope)}]
 `;
 exports.UNDEFINED_FORWARDREF_MESSAGE = UNDEFINED_FORWARDREF_MESSAGE;
-const INVALID_MODULE_MESSAGE = (parentModule, index, scope) => {
+const INVALID_MODULE_MESSAGE = (parentModule, index, scope, receivedValue) => {
     const parentModuleName = parentModule?.name || 'module';
+    let formattedValue;
+    let receivedType;
+    if (receivedValue === null) {
+        formattedValue = 'null';
+        receivedType = 'null';
+    }
+    else if (typeof receivedValue === 'string') {
+        formattedValue = `"${receivedValue}"`;
+        receivedType = 'string';
+    }
+    else {
+        formattedValue = String(receivedValue);
+        receivedType = typeof receivedValue;
+    }
     return `Nest cannot create the ${parentModuleName} instance.
 Received an unexpected value at index [${index}] of the ${parentModuleName} "imports" array.
+The received value \`${formattedValue}\` is of type "${receivedType}".
 
 Scope [${stringifyScope(scope)}]`;
 };
 exports.INVALID_MODULE_MESSAGE = INVALID_MODULE_MESSAGE;
-const USING_INVALID_CLASS_AS_A_MODULE_MESSAGE = (metatypeUsedAsAModule, scope) => {
+const USING_INVALID_CLASS_AS_A_MODULE_MESSAGE = (metatypeUsedAsAModule, scope, classKind) => {
     const metatypeNameQuote = `"${getInstanceName(metatypeUsedAsAModule)}"`;
-    return `Classes annotated with @Injectable(), @Catch(), and @Controller() decorators must not appear in the "imports" array of a module.
-Please remove ${metatypeNameQuote} (including forwarded occurrences, if any) from all of the "imports" arrays.
+    let hint;
+    switch (classKind) {
+        case 'controller':
+            hint = `${metatypeNameQuote} is decorated with @Controller() and cannot appear in the "imports" array of a module. Please move ${metatypeNameQuote} to the "controllers" array of the importing module instead.`;
+            break;
+        case 'provider':
+            hint = `${metatypeNameQuote} is decorated with @Injectable() and cannot appear in the "imports" array of a module. Please move ${metatypeNameQuote} to the "providers" array of the importing module instead.`;
+            break;
+        case 'filter':
+            hint = `${metatypeNameQuote} is decorated with @Catch() and cannot appear in the "imports" array of a module. Please move ${metatypeNameQuote} to the "providers" array (using the APP_FILTER token to apply it globally) or apply it via @UseFilters() instead.`;
+            break;
+    }
+    return `${hint}
 
 Scope [${stringifyScope(scope)}]
 `;

package/injector/injector.d.ts

@@ -72,9 +72,9 @@ export declare class Injector {
     resolveConstructorParams<T>(wrapper: InstanceWrapper<T>, moduleRef: Module, inject: InjectorDependency[] | undefined, callback: (args: unknown[]) => void | Promise<void>, resolutionContext?: ResolutionContext, parentInquirer?: InstanceWrapper): Promise<void>;
     getClassDependencies<T>(wrapper: InstanceWrapper<T>): [InjectorDependency[], number[]];
     getFactoryProviderDependencies<T>(wrapper: InstanceWrapper<T>): [InjectorDependency[], number[]];
-    reflectConstructorParams<T>(type: Type<T>): any[];
-    reflectOptionalParams<T>(type: Type<T>): any[];
-    reflectSelfParams<T>(type: Type<T>): any[];
+    reflectConstructorParams(type: Type<unknown> | Function): any[];
+    reflectOptionalParams(type: Type<unknown> | Function): any[];
+    reflectSelfParams(type: Type<unknown> | Function): any[];
     resolveSingleParam<T>(wrapper: InstanceWrapper<T>, param: Type<any> | string | symbol, dependencyContext: InjectorDependencyContext, moduleRef: Module, resolutionContext?: ResolutionContext, keyOrIndex?: symbol | string | number): Promise<InstanceWrapper<any>>;
     resolveParamToken<T>(wrapper: InstanceWrapper<T>, param: Type<any> | string | symbol | ForwardReference): any;
     resolveComponentWrapper<T>(moduleRef: Module, token: InjectionToken, dependencyContext: InjectorDependencyContext, wrapper: InstanceWrapper<T>, resolutionContext?: ResolutionContext, keyOrIndex?: symbol | string | number): Promise<InstanceWrapper>;
@@ -106,6 +106,7 @@ export declare class Injector {
     private getEffectiveInquirerId;
     private getStaticTransientResolutionContext;
     private getEffectiveResolutionContext;
+    private hasDenseCtorMetadata;
     private resolveScopedComponentHost;
     private isInquirerRequest;
     private isInquirer;

package/injector/injector.js

@@ -75,6 +75,9 @@ class Injector {
                 settlementSignal.complete();
             };
             await this.resolveConstructorParams(wrapper, moduleRef, inject, callback, localResolutionContext, resolutionContext.inquirer);
+            if (!instanceHost.isResolved) {
+                settlementSignal.complete();
+            }
         }
         catch (err) {
             wrapper.removeInstanceByContextId(this.getContextId(resolutionContext.contextId, wrapper), inquirerId);
@@ -117,7 +120,8 @@ class Injector {
     }
     async resolveConstructorParams(wrapper, moduleRef, inject, callback, resolutionContext = { contextId: constants_2.STATIC_CONTEXT }, parentInquirer) {
         const metadata = wrapper.getCtorMetadata();
-        if (metadata && resolutionContext.contextId !== constants_2.STATIC_CONTEXT) {
+        if (resolutionContext.contextId !== constants_2.STATIC_CONTEXT &&
+            this.hasDenseCtorMetadata(wrapper, inject, metadata)) {
             const deps = await this.loadCtorMetadata(metadata, resolutionContext.contextId, resolutionContext.inquirer, parentInquirer);
             return callback(deps);
         }
@@ -553,6 +557,28 @@ class Injector {
     getEffectiveResolutionContext(dependency, resolutionContext, parentInquirer) {
         return this.createResolutionContext(resolutionContext.contextId, this.getEffectiveInquirer(dependency, resolutionContext, parentInquirer), this.getEffectiveInquirerId(dependency, resolutionContext, parentInquirer));
     }
+    hasDenseCtorMetadata(wrapper, inject, metadata) {
+        if (!metadata) {
+            return false;
+        }
+        // The fast path requires a fully populated metadata array.
+        // While another request is still registering dependency metadata,
+        // sparse entries here would feed request-scoped factories `undefined`.
+        const expectedDepsLength = !(0, shared_utils_1.isNil)(inject)
+            ? inject.length
+            : wrapper.metatype
+                ? this.reflectConstructorParams(wrapper.metatype).length
+                : 0;
+        if (metadata.length !== expectedDepsLength) {
+            return false;
+        }
+        for (let index = 0; index < expectedDepsLength; index++) {
+            if (metadata[index] === undefined) {
+                return false;
+            }
+        }
+        return true;
+    }
     resolveScopedComponentHost(item, contextId, inquirer, parentInquirer) {
         return this.isInquirerRequest(item, parentInquirer)
             ? parentInquirer

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nestjs/core",
-  "version": "11.1.20",
+  "version": "11.1.22",
   "description": "Nest - modern, fast, powerful node.js web framework (@core)",
   "author": "Kamil Mysliwiec",
   "license": "MIT",
@@ -39,7 +39,7 @@
     "uid": "2.0.2"
   },
   "devDependencies": {
-    "@nestjs/common": "11.1.20"
+    "@nestjs/common": "11.1.22"
   },
   "peerDependencies": {
     "@nestjs/common": "^11.0.0",
@@ -60,5 +60,5 @@
       "optional": true
     }
   },
-  "gitHead": "7caeb3fb70de81085c4c3e8502a2a0e62e4f8eda"
+  "gitHead": "801c46ffa19d2a549adc446d1f91e7484ae61edb"
 }

package/scanner.js

@@ -64,7 +64,7 @@ class DependenciesScanner {
                 throw new undefined_module_exception_1.UndefinedModuleException(moduleDefinition, index, scope);
             }
             if (!innerModule) {
-                throw new invalid_module_exception_1.InvalidModuleException(moduleDefinition, index, scope);
+                throw new invalid_module_exception_1.InvalidModuleException(moduleDefinition, index, scope, innerModule);
             }
             if (ctxRegistry.includes(innerModule)) {
                 continue;
@@ -90,10 +90,14 @@ class DependenciesScanner {
         const moduleToAdd = this.isForwardReference(moduleDefinition)
             ? moduleDefinition.forwardRef()
             : moduleDefinition;
-        if (this.isInjectable(moduleToAdd) ||
-            this.isController(moduleToAdd) ||
-            this.isExceptionFilter(moduleToAdd)) {
-            throw new invalid_class_module_exception_1.InvalidClassModuleException(moduleDefinition, scope);
+        if (this.isInjectable(moduleToAdd)) {
+            throw new invalid_class_module_exception_1.InvalidClassModuleException(moduleDefinition, scope, 'provider');
+        }
+        if (this.isController(moduleToAdd)) {
+            throw new invalid_class_module_exception_1.InvalidClassModuleException(moduleDefinition, scope, 'controller');
+        }
+        if (this.isExceptionFilter(moduleToAdd)) {
+            throw new invalid_class_module_exception_1.InvalidClassModuleException(moduleDefinition, scope, 'filter');
         }
         return this.container.addModule(moduleToAdd, scope);
     }