@nestjs/cli 8.1.2 → 8.1.6

package/.circleci/config.yml

@@ -21,7 +21,7 @@ jobs:
   build:
     working_directory: ~/nest
     docker:
-      - image: circleci/node:16
+      - image: circleci/node:17
     steps:
       - checkout
       - run:
@@ -43,7 +43,7 @@ jobs:
   unit_tests:
     working_directory: ~/nest
     docker:
-      - image: circleci/node:16
+      - image: circleci/node:17
     steps:
       - checkout
       - *restore-cache

package/.eslintrc.js

@@ -8,8 +8,7 @@ module.exports = {
   extends: [
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
-    'prettier',
-    'prettier/@typescript-eslint',
+    'prettier'
   ],
   root: true,
   env: {

package/.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -0,0 +1,106 @@
+name: "\U0001F41B Bug Report"
+description: "If something isn't working as expected \U0001F914"
+labels: ["needs triage", "bug"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ## :warning: We use GitHub Issues to track bug reports, feature requests and regressions
+ 
+        If you are not sure that your issue is a bug, you could:
+
+        - use our [Discord community](https://discord.gg/NestJS)
+        - use [StackOverflow using the tag `nestjs`](https://stackoverflow.com/questions/tagged/nestjs)
+        - If it's just a quick question you can ping [our Twitter](https://twitter.com/nestframework)
+
+        **NOTE:** You don't need to answer questions that you know that aren't relevant.
+
+        ---
+
+  - type: checkboxes
+    attributes:
+      label: "Is there an existing issue for this?"
+      description: "Please search [here](./?q=is%3Aissue) to see if an issue already exists for the bug you encountered"
+      options:
+      - label: "I have searched the existing issues"
+        required: true
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Current behavior"
+      description: "How the issue manifests?"
+
+  - type: input
+    validations:
+      required: true
+    attributes:
+      label: "Minimum reproduction code"
+      description: "An URL to some git repository or gist that reproduces this issue. [Wtf is a minimum reproduction?](https://jmcdo29.github.io/wtf-is-a-minimum-reproduction)"
+      placeholder: "https://github.com/..."
+
+  - type: textarea
+    attributes:
+      label: "Steps to reproduce"
+      description: |
+        How the issue manifests?
+        You could leave this blank if you alread write this in your reproduction code/repo
+      placeholder: |
+        1. `npm i`
+        2. `npm start:dev`
+        3. See error...
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Expected behavior"
+      description: "A clear and concise description of what you expected to happend (or code)"
+
+  - type: markdown
+    attributes:
+      value: |
+        ---
+
+  - type: input
+    validations:
+      required: true
+    attributes:
+      label: "Package version"
+      description: |
+        Which version of `@nestjs/cli` are you using?
+        **Tip**: Make sure that all of yours `@nestjs/*` dependencies are in sync!
+      placeholder: "8.1.3"
+
+  - type: input
+    attributes:
+      label: "NestJS version"
+      description: "Which version of `@nestjs/core` are you using?"
+      placeholder: "8.1.3"
+
+  - type: input
+    attributes:
+      label: "Node.js version"
+      description: "Which version of Node.js are you using?"
+      placeholder: "14.17.6"
+
+  - type: checkboxes
+    attributes:
+      label: "In which operating systems have you tested?"
+      options:
+        - label: macOS
+        - label: Windows
+        - label: Linux
+
+  - type: markdown
+    attributes:
+      value: |
+        ---
+
+  - type: textarea
+    attributes:
+      label: "Other"
+      description: |
+        Anything else relevant? eg: Logs, OS version, IDE, package manager, etc.
+        **Tip:** You can attach images, recordings or log files by clicking this area to highlight it and then dragging files in

package/.github/ISSUE_TEMPLATE/Feature_request.yml

@@ -0,0 +1,52 @@
+name: "\U0001F680 Feature Request"
+description: "I have a suggestion \U0001F63B!"
+labels: ["feature"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ## :warning: We use GitHub Issues to track bug reports, feature requests and regressions
+ 
+        If you are not sure that your issue is a bug, you could:
+
+        - use our [Discord community](https://discord.gg/NestJS)
+        - use [StackOverflow using the tag `nestjs`](https://stackoverflow.com/questions/tagged/nestjs)
+        - If it's just a quick question you can ping [our Twitter](https://twitter.com/nestframework)
+
+        ---
+
+  - type: checkboxes
+    attributes:
+      label: "Is there an existing issue that is already proposing this?"
+      description: "Please search [here](./?q=is%3Aissue) to see if an issue already exists for the feature you are requesting"
+      options:
+      - label: "I have searched the existing issues"
+        required: true
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Is your feature request related to a problem? Please describe it"
+      description: "A clear and concise description of what the problem is"
+      placeholder: |
+        I have an issue when ...
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Describe the solution you'd like"
+      description: "A clear and concise description of what you want to happen. Add any considered drawbacks"
+
+  - type: textarea
+    attributes:
+      label: "Teachability, documentation, adoption, migration strategy"
+      description: "If you can, explain how users will be able to use this and possibly write out a version the docs. Maybe a screenshot or design?"
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "What is the motivation / use case for changing the behavior?"
+      description: "Describe the motivation or the concrete use case"

package/.github/ISSUE_TEMPLATE/Regression.yml

@@ -0,0 +1,78 @@
+name: "\U0001F4A5 Regression"
+description: "Report an unexpected behavior while upgrading your Nest application!"
+labels: ["needs triage"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        ## :warning: We use GitHub Issues to track bug reports, feature requests and regressions
+ 
+        If you are not sure that your issue is a bug, you could:
+
+        - use our [Discord community](https://discord.gg/NestJS)
+        - use [StackOverflow using the tag `nestjs`](https://stackoverflow.com/questions/tagged/nestjs)
+        - If it's just a quick question you can ping [our Twitter](https://twitter.com/nestframework)
+
+        **NOTE:** You don't need to answer questions that you know that aren't relevant.
+
+        ---
+
+  - type: checkboxes
+    attributes:
+      label: "Did you read the migration guide?"
+      description: "Check out the [migration guide here](https://docs.nestjs.com/migration-guide)!"
+      options:
+      - label: "I have read the whole migration guide"
+        required: false
+
+  - type: checkboxes
+    attributes:
+      label: "Is there an existing issue that is already proposing this?"
+      description: "Please search [here](./?q=is%3Aissue) to see if an issue already exists for the feature you are requesting"
+      options:
+      - label: "I have searched the existing issues"
+        required: true
+
+  - type: input
+    attributes:
+      label: "Potential Commit/PR that introduced the regression"
+      description: "If you have time to investigate, what PR/date/version introduced this issue"
+      placeholder: "PR #123 or commit 5b3c4a4"
+
+  - type: input
+    attributes:
+      label: "Versions"
+      description: "From which version of `@nestjs/cli` to which version you are upgrading"
+      placeholder: "8.1.0 -> 8.1.3"
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Describe the regression"
+      description: "A clear and concise description of what the regression is"
+
+  - type: textarea
+    attributes:
+      label: "Minimum reproduction code"
+      description: |
+        Please share a git repo, a gist, or step-by-step instructions. [Wtf is a minimum reproduction?](https://jmcdo29.github.io/wtf-is-a-minimum-reproduction)
+        **Tip:** If you leave a minimum repository, we will understand your issue faster!
+      value: |
+        ```ts
+
+        ```
+
+  - type: textarea
+    validations:
+      required: true
+    attributes:
+      label: "Expected behavior"
+      description: "A clear and concise description of what you expected to happend (or code)"
+
+  - type: textarea
+    attributes:
+      label: "Other"
+      description: |
+        Anything else relevant? eg: Logs, OS version, IDE, package manager, etc.
+        **Tip:** You can attach images, recordings or log files by clicking this area to highlight it and then dragging files in

package/.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,7 @@
+## To encourage contributors to use issue templates, we don't allow blank issues
+blank_issues_enabled: false
+
+contact_links:
+  - name: "\u2753 Discord Community of NestJS"
+    url: "https://discord.gg/NestJS"
+    about: "Please ask support questions or discuss suggestions/enhancements here."

package/CONTRIBUTING.md

@@ -48,7 +48,7 @@ We want to fix all the issues as soon as possible, but before fixing a bug we ne
 - version of NestJS-CLI used (`nest info`)
 - and most importantly - a use-case that fails
 
-Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced.
+Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.
 
 You can file new issues by filling out our [new issue form](https://github.com/nestjs/nest/issues/new).
 
@@ -149,7 +149,7 @@ format that includes a **type**, a **scope** and a **subject**:
 
 The **header** is mandatory and the **scope** of the header is optional.
 
-Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
+Any line of the commit message cannot be longer than 100 characters! This allows the message to be easier
 to read on GitHub as well as in various git tools.
 
 Footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.

package/commands/generate.command.js

@@ -62,7 +62,7 @@ class GenerateCommand extends abstract_command_1.AbstractCommand {
     }
     buildDescription() {
         return ('Generate a Nest element.\n' +
-            '  Available schematics:\n' +
+            `  Schematics available on ${chalk.bold('@nestjs/schematics')} collection:\n` +
             this.buildSchematicsListAsTable());
     }
     buildSchematicsListAsTable() {

package/lib/compiler/assets-manager.d.ts

@@ -2,8 +2,12 @@ import { Configuration } from '../configuration';
 export declare class AssetsManager {
     private watchAssetsKeyValue;
     private watchers;
+    private actionInProgress;
     /**
      * Using on `nest build` to close file watch or the build process will not end
+     * Interval like process
+     * If no action has been taken recently close watchers
+     * If action has been taken recently flag and try again
      */
     closeWatchers(): void;
     copyAssets(configuration: Required<Configuration>, appName: string, outDir: string, watchAssetsMode: boolean): void;

package/lib/compiler/assets-manager.js

@@ -10,13 +10,26 @@ class AssetsManager {
     constructor() {
         this.watchAssetsKeyValue = {};
         this.watchers = [];
+        this.actionInProgress = false;
     }
     /**
      * Using on `nest build` to close file watch or the build process will not end
+     * Interval like process
+     * If no action has been taken recently close watchers
+     * If action has been taken recently flag and try again
      */
     closeWatchers() {
-        const timeoutMs = 300;
-        const closeFn = () => this.watchers.forEach((watcher) => watcher.close());
+        // Consider adjusting this for larger files
+        const timeoutMs = 500;
+        const closeFn = () => {
+            if (this.actionInProgress) {
+                this.actionInProgress = false;
+                setTimeout(closeFn, timeoutMs);
+            }
+            else {
+                this.watchers.forEach((watcher) => watcher.close());
+            }
+        };
         setTimeout(closeFn, timeoutMs);
     }
     copyAssets(configuration, appName, outDir, watchAssetsMode) {
@@ -73,6 +86,8 @@ class AssetsManager {
         }
         // Set path value to true for watching the first time
         this.watchAssetsKeyValue[path] = true;
+        // Set action to true to avoid watches getting cutoff
+        this.actionInProgress = true;
         const dest = copy_path_resolve_1.copyPathResolve(path, item.outDir, sourceRoot.split(path_1.sep).length);
         // Copy to output dir if file is changed or added
         if (action === 'change') {

package/lib/compiler/hooks/tsconfig-paths.hook.js

@@ -27,6 +27,7 @@ function tsconfigPathsBeforeHookFactory(compilerOptions) {
                         }
                         newNode.moduleSpecifier = tsBinary.createLiteral(result);
                         newNode.moduleSpecifier.parent = node.moduleSpecifier.parent;
+                        newNode.flags = node.flags;
                         return newNode;
                     }
                     catch (_a) {

package/lib/package-managers/abstract.package-manager.d.ts

@@ -10,13 +10,13 @@ export declare abstract class AbstractPackageManager {
     addDevelopment(dependencies: string[], tag: string): Promise<void>;
     private add;
     getProduction(): Promise<ProjectDependency[]>;
-    getDevelopement(): Promise<ProjectDependency[]>;
+    getDevelopment(): Promise<ProjectDependency[]>;
     private readPackageJson;
     updateProduction(dependencies: string[]): Promise<void>;
-    updateDevelopement(dependencies: string[]): Promise<void>;
+    updateDevelopment(dependencies: string[]): Promise<void>;
     private update;
     upgradeProduction(dependencies: string[], tag: string): Promise<void>;
-    upgradeDevelopement(dependencies: string[], tag: string): Promise<void>;
+    upgradeDevelopment(dependencies: string[], tag: string): Promise<void>;
     deleteProduction(dependencies: string[]): Promise<void>;
     deleteDevelopment(dependencies: string[]): Promise<void>;
     delete(commandArguments: string): Promise<void>;

package/lib/package-managers/abstract.package-manager.js

@@ -110,7 +110,7 @@ class AbstractPackageManager {
             return dependencies;
         });
     }
-    getDevelopement() {
+    getDevelopment() {
         return __awaiter(this, void 0, void 0, function* () {
             const packageJsonContent = yield this.readPackageJson();
             const packageJsonDevDependencies = packageJsonContent.devDependencies;
@@ -141,7 +141,7 @@ class AbstractPackageManager {
             yield this.update(commandArguments);
         });
     }
-    updateDevelopement(dependencies) {
+    updateDevelopment(dependencies) {
         return __awaiter(this, void 0, void 0, function* () {
             const commandArguments = `${this.cli.update} ${dependencies.join(' ')}`;
             yield this.update(commandArguments);
@@ -159,7 +159,7 @@ class AbstractPackageManager {
             yield this.addProduction(dependencies, tag);
         });
     }
-    upgradeDevelopement(dependencies, tag) {
+    upgradeDevelopment(dependencies, tag) {
         return __awaiter(this, void 0, void 0, function* () {
             yield this.deleteDevelopment(dependencies);
             yield this.addDevelopment(dependencies, tag);

package/lib/utils/project-utils.js

@@ -59,7 +59,7 @@ function askForProjectName(promptQuestion, projects) {
 }
 exports.askForProjectName = askForProjectName;
 function moveDefaultProjectToStart(configuration, defaultProjectName, defaultLabel) {
-    let projects = Object.keys(configuration.projects);
+    let projects = configuration.projects != null ? Object.keys(configuration.projects) : [];
     if (configuration.sourceRoot !== 'src') {
         projects = projects.filter((p) => p !== defaultProjectName.replace(defaultLabel, ''));
     }

package/lib/utils/tree-kill.js

@@ -23,7 +23,7 @@ function getAllPid() {
         .slice(1);
     return rows
         .map(function (row) {
-        var parts = row.match(/\s*(\d+)\s*(\d+)/);
+        const parts = row.match(/\s*(\d+)\s*(\d+)/);
         if (parts === null) {
             return null;
         }
@@ -38,8 +38,8 @@ function getAllPid() {
 }
 function getAllChilds(pid) {
     const allpid = getAllPid();
-    let ppidHash = {};
-    let result = [];
+    const ppidHash = {};
+    const result = [];
     allpid.forEach(function (item) {
         ppidHash[item.ppid] = ppidHash[item.ppid] || [];
         ppidHash[item.ppid].push(item.pid);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nestjs/cli",
-  "version": "8.1.2",
+  "version": "8.1.6",
   "description": "Nest - modern, fast, powerful node.js web framework (@cli)",
   "publishConfig": {
     "access": "public"
@@ -43,57 +43,57 @@
   },
   "homepage": "https://github.com/nestjs/nest-cli#readme",
   "dependencies": {
-    "@angular-devkit/core": "12.2.7",
-    "@angular-devkit/schematics": "12.2.7",
-    "@angular-devkit/schematics-cli": "12.2.7",
+    "@angular-devkit/core": "13.1.1",
+    "@angular-devkit/schematics": "13.1.1",
+    "@angular-devkit/schematics-cli": "13.1.1",
     "@nestjs/schematics": "^8.0.3",
     "chalk": "3.0.0",
     "chokidar": "3.5.2",
-    "cli-table3": "0.5.1",
+    "cli-table3": "0.6.0",
     "commander": "4.1.1",
-    "fork-ts-checker-webpack-plugin": "6.3.3",
+    "fork-ts-checker-webpack-plugin": "6.5.0",
     "inquirer": "7.3.3",
     "node-emoji": "1.11.0",
     "ora": "5.4.1",
     "os-name": "4.0.1",
     "rimraf": "3.0.2",
     "shelljs": "0.8.4",
-    "source-map-support": "0.5.20",
+    "source-map-support": "0.5.21",
     "tree-kill": "1.2.2",
-    "tsconfig-paths": "3.11.0",
-    "tsconfig-paths-webpack-plugin": "3.5.1",
+    "tsconfig-paths": "3.12.0",
+    "tsconfig-paths-webpack-plugin": "3.5.2",
     "typescript": "4.3.5",
-    "webpack": "5.45.1",
+    "webpack": "5.65.0",
     "webpack-node-externals": "3.0.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "13.2.0",
-    "@commitlint/config-angular": "13.2.0",
+    "@commitlint/cli": "15.0.0",
+    "@commitlint/config-angular": "15.0.0",
     "@types/copyfiles": "2.4.1",
     "@types/inquirer": "7.3.3",
-    "@types/jest": "27.0.2",
-    "@types/node": "14.17.19",
+    "@types/jest": "27.0.3",
+    "@types/node": "16.11.12",
     "@types/node-emoji": "1.8.1",
     "@types/ora": "3.2.0",
     "@types/os-name": "3.1.0",
     "@types/rimraf": "3.0.2",
     "@types/shelljs": "0.8.9",
-    "@types/webpack-node-externals": "2.5.2",
-    "@typescript-eslint/eslint-plugin": "4.32.0",
-    "@typescript-eslint/parser": "4.32.0",
+    "@types/webpack-node-externals": "2.5.3",
+    "@typescript-eslint/eslint-plugin": "5.6.0",
+    "@typescript-eslint/parser": "5.6.0",
     "delete-empty": "3.0.0",
-    "eslint": "7.32.0",
+    "eslint": "8.4.1",
     "eslint-config-prettier": "8.3.0",
-    "eslint-plugin-import": "2.24.2",
+    "eslint-plugin-import": "2.25.3",
     "gulp": "4.0.2",
     "gulp-clean": "0.4.0",
-    "husky": "7.0.2",
-    "jest": "27.2.3",
-    "prettier": "2.4.1",
-    "release-it": "14.11.6",
-    "ts-jest": "27.0.5",
+    "husky": "7.0.4",
+    "jest": "27.4.4",
+    "prettier": "2.5.1",
+    "release-it": "14.11.8",
+    "ts-jest": "27.1.1",
     "ts-loader": "9.2.6",
-    "ts-node": "10.2.1"
+    "ts-node": "10.4.0"
   },
   "husky": {
     "hooks": {

package/test/lib/compiler/hooks/__snapshots__/tsconfig-paths.hook.spec.ts.snap

@@ -0,0 +1,23 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`tsconfig paths hooks should remove unused imports 1`] = `
+Map {
+  "dist/foo.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+exports.Foo = void 0;
+class Foo {
+}
+exports.Foo = Foo;
+",
+  "dist/bar.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+exports.Bar = void 0;
+class Bar {
+}
+exports.Bar = Bar;
+",
+  "dist/main.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+",
+}
+`;

package/.github/ISSUE_TEMPLATE.md

@@ -1,38 +0,0 @@
-<!--
-PLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.
-
-ISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.
--->
-
-## I'm submitting a...
-<!-- 
-Please search GitHub for a similar issue or PR before submitting.
-Check one of the following options with "x" -->
-<pre><code>
-[ ] Regression <!--(a behavior that used to work and stopped working in a new release)-->
-[ ] Bug report
-[ ] Feature request
-[ ] Documentation issue or request
-[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
-</code></pre>
-
-## Current behavior
-<!-- Describe how the issue manifests. -->
-
-
-## Expected behavior
-<!-- Describe what the desired behavior would be. -->
-
-
-## Minimal reproduction of the problem with instructions
-<!-- Please share a repo, a gist, or step-by-step instructions. -->
-
-## What is the motivation / use case for changing the behavior?
-<!-- Describe the motivation or the concrete use case. -->
-
-
-## Environment
-<!--- Run `nest info` and paste it below -->
-```
-
-```