@nestia/core 13.0.1 → 13.0.2

package/lib/decorators/EncryptedBody.js

@@ -58,7 +58,7 @@ function EncryptedBody(validator) {
                 ? param({ headers: headers.get(), body, direction: "decode" })
                 : param;
             // PARSE AND VALIDATE DATA
-            const data = JSON.parse(decrypt(body, password.key, password.iv));
+            const data = decode(body, password.key, password.iv);
             const error = checker(data);
             if (error !== null)
                 throw error;
@@ -66,10 +66,28 @@ function EncryptedBody(validator) {
         });
     })();
 }
-/** @internal */
-const decrypt = (body, key, iv) => {
+/**
+ * Decrypt and JSON-parse the request body behind a single failure response.
+ *
+ * `AesPkcs5` is AES-CBC without an authentication tag, so a MITM attacker can
+ * forge ciphertexts. Splitting the two failure modes of a forged body — a bad
+ * PKCS#5 padding (decryption throws) versus valid padding whose plaintext is
+ * not JSON (`JSON.parse` throws) — into two different HTTP status codes turns
+ * this decorator into a padding oracle: one observable bit per request lets the
+ * attacker recover the plaintext byte by byte without the key
+ * (GHSA-pqj4-gvf7-6fq5).
+ *
+ * Both failure modes must therefore collapse into one indistinguishable
+ * `BadRequestException` (identical status, message, and body). Only the
+ * downstream type validation of an already-parsed body may report its own
+ * distinct error, because reaching it requires plaintext the attacker cannot
+ * forge without already knowing it.
+ *
+ * @internal
+ */
+const decode = (body, key, iv) => {
     try {
-        return AesPkcs5_1.AesPkcs5.decrypt(body, key, iv);
+        return JSON.parse(AesPkcs5_1.AesPkcs5.decrypt(body, key, iv));
     }
     catch (exp) {
         if (exp instanceof Error)

package/lib/decorators/EncryptedBody.js.map

@@ -1 +1 @@
-{"version":3,"file":"EncryptedBody.js","sourceRoot":"","sources":["../../src/decorators/EncryptedBody.ts"],"names":[],"mappings":";;;;;;;;;;;;AACA,2DAAwD;AACxD,2CAIwB;AAKxB,kDAA+C;AAC/C,oEAAuE;AACvE,4DAAyD;AACzD,oEAAiE;AACjE,4DAAyD;AACzD,4EAAyE;AAEzE;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,uBACE,SAAoC;IAEpC,MAAM,OAAO,GAAG,IAAA,6CAAqB,EAAC,eAAe,CAAC,CAAC,SAAS,CAAC,CAAC;IAClE,OAAO,IAAA,6BAAoB,EAAC,SAAe,aAAa,CACtD,QAAa,EACb,OAAyB;;YAEzB,MAAM,OAAO,GAAqC,OAAO;iBACtD,YAAY,EAAE;iBACd,UAAU,EAAE,CAAC;YAChB,IAAI,IAAA,6BAAa,EAAC,OAAO,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,YAAY,CAAC,KAAK,KAAK;gBACxE,MAAM,IAAI,4BAAmB,CAAC,wCAAwC,CAAC,CAAC;YAE1E,MAAM,KAAK,GACT,OAAO,CAAC,WAAW,CAAC,2CAAuB,EAAE,OAAO,CAAC,QAAQ,EAAE,CAAC,CAAC;YACnE,IAAI,CAAC,KAAK;gBACR,MAAM,IAAI,KAAK,CACb,wEAAwE,CACzE,CAAC;YAEJ,gBAAgB;YAChB,MAAM,OAAO,GAAsC,IAAI,qBAAS,CAAC,GAAG,EAAE,CACpE,IAAA,qCAAiB,EAAC,OAAO,CAAC,OAAO,CAAC,CACnC,CAAC;YACF,MAAM,IAAI,GAAW,MAAM,IAAA,6BAAa,EAAC,OAAO,CAAC,CAAC;YAClD,MAAM,QAAQ,GACZ,OAAO,KAAK,KAAK,UAAU;gBACzB,CAAC,CAAC,KAAK,CAAC,EAAE,OAAO,EAAE,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE,QAAQ,EAAE,CAAC;gBAC9D,CAAC,CAAC,KAAK,CAAC;YAEZ,0BAA0B;YAC1B,MAAM,IAAI,GAAQ,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,QAAQ,CAAC,GAAG,EAAE,QAAQ,CAAC,EAAE,CAAC,CAAC,CAAC;YACvE,MAAM,KAAK,GAAiB,OAAO,CAAC,IAAI,CAAC,CAAC;YAC1C,IAAI,KAAK,KAAK,IAAI;gBAAE,MAAM,KAAK,CAAC;YAChC,OAAO,IAAI,CAAC;QACd,CAAC;KAAA,CAAC,EAAE,CAAC;AACP,CAAC;AAED,gBAAgB;AAChB,MAAM,OAAO,GAAG,CAAC,IAAY,EAAE,GAAW,EAAE,EAAU,EAAU,EAAE;IAChE,IAAI,CAAC;QACH,OAAO,mBAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;IACzC,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,IAAI,GAAG,YAAY,KAAK;YACtB,MAAM,IAAI,4BAAmB,CAC3B,qFAAqF,CACtF,CAAC;;YACC,MAAM,GAAG,CAAC;IACjB,CAAC;AACH,CAAC,CAAC"}
+{"version":3,"file":"EncryptedBody.js","sourceRoot":"","sources":["../../src/decorators/EncryptedBody.ts"],"names":[],"mappings":";;;;;;;;;;;;AACA,2DAAwD;AACxD,2CAIwB;AAKxB,kDAA+C;AAC/C,oEAAuE;AACvE,4DAAyD;AACzD,oEAAiE;AACjE,4DAAyD;AACzD,4EAAyE;AAEzE;;;;;;;;;;;;;;;;;;;;GAoBG;AACH,uBACE,SAAoC;IAEpC,MAAM,OAAO,GAAG,IAAA,6CAAqB,EAAC,eAAe,CAAC,CAAC,SAAS,CAAC,CAAC;IAClE,OAAO,IAAA,6BAAoB,EAAC,SAAe,aAAa,CACtD,QAAa,EACb,OAAyB;;YAEzB,MAAM,OAAO,GAAqC,OAAO;iBACtD,YAAY,EAAE;iBACd,UAAU,EAAE,CAAC;YAChB,IAAI,IAAA,6BAAa,EAAC,OAAO,CAAC,OAAO,CAAC,cAAc,CAAC,EAAE,YAAY,CAAC,KAAK,KAAK;gBACxE,MAAM,IAAI,4BAAmB,CAAC,wCAAwC,CAAC,CAAC;YAE1E,MAAM,KAAK,GACT,OAAO,CAAC,WAAW,CAAC,2CAAuB,EAAE,OAAO,CAAC,QAAQ,EAAE,CAAC,CAAC;YACnE,IAAI,CAAC,KAAK;gBACR,MAAM,IAAI,KAAK,CACb,wEAAwE,CACzE,CAAC;YAEJ,gBAAgB;YAChB,MAAM,OAAO,GAAsC,IAAI,qBAAS,CAAC,GAAG,EAAE,CACpE,IAAA,qCAAiB,EAAC,OAAO,CAAC,OAAO,CAAC,CACnC,CAAC;YACF,MAAM,IAAI,GAAW,MAAM,IAAA,6BAAa,EAAC,OAAO,CAAC,CAAC;YAClD,MAAM,QAAQ,GACZ,OAAO,KAAK,KAAK,UAAU;gBACzB,CAAC,CAAC,KAAK,CAAC,EAAE,OAAO,EAAE,OAAO,CAAC,GAAG,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE,QAAQ,EAAE,CAAC;gBAC9D,CAAC,CAAC,KAAK,CAAC;YAEZ,0BAA0B;YAC1B,MAAM,IAAI,GAAQ,MAAM,CAAC,IAAI,EAAE,QAAQ,CAAC,GAAG,EAAE,QAAQ,CAAC,EAAE,CAAC,CAAC;YAC1D,MAAM,KAAK,GAAiB,OAAO,CAAC,IAAI,CAAC,CAAC;YAC1C,IAAI,KAAK,KAAK,IAAI;gBAAE,MAAM,KAAK,CAAC;YAChC,OAAO,IAAI,CAAC;QACd,CAAC;KAAA,CAAC,EAAE,CAAC;AACP,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,MAAM,MAAM,GAAG,CAAC,IAAY,EAAE,GAAW,EAAE,EAAU,EAAW,EAAE;IAChE,IAAI,CAAC;QACH,OAAO,IAAI,CAAC,KAAK,CAAC,mBAAQ,CAAC,OAAO,CAAC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC,CAAC;IACrD,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,IAAI,GAAG,YAAY,KAAK;YACtB,MAAM,IAAI,4BAAmB,CAC3B,qFAAqF,CACtF,CAAC;;YACC,MAAM,GAAG,CAAC;IACjB,CAAC;AACH,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nestia/core",
-  "version": "13.0.1",
+  "version": "13.0.2",
   "description": "Super-fast validation decorators of NestJS",
   "main": "lib/index.js",
   "exports": {
@@ -56,7 +56,7 @@
     "tgrid": "^1.1.0",
     "typia": "^14.0.2",
     "ws": "^7.5.3",
-    "@nestia/fetcher": "^13.0.1"
+    "@nestia/fetcher": "^13.0.2"
   },
   "peerDependencies": {
     "@modelcontextprotocol/sdk": "^1.18.0",
@@ -66,7 +66,7 @@
     "rxjs": ">=6.0.3",
     "ttsc": ">=0.19.2",
     "typia": "^14.0.2",
-    "@nestia/fetcher": "^13.0.1"
+    "@nestia/fetcher": "^13.0.2"
   },
   "peerDependenciesMeta": {
     "@modelcontextprotocol/sdk": {

package/src/decorators/EncryptedBody.ts

@@ -69,17 +69,35 @@ export function EncryptedBody<T>(
         : param;
 
     // PARSE AND VALIDATE DATA
-    const data: any = JSON.parse(decrypt(body, password.key, password.iv));
+    const data: any = decode(body, password.key, password.iv);
     const error: Error | null = checker(data);
     if (error !== null) throw error;
     return data;
   })();
 }
 
-/** @internal */
-const decrypt = (body: string, key: string, iv: string): string => {
+/**
+ * Decrypt and JSON-parse the request body behind a single failure response.
+ *
+ * `AesPkcs5` is AES-CBC without an authentication tag, so a MITM attacker can
+ * forge ciphertexts. Splitting the two failure modes of a forged body — a bad
+ * PKCS#5 padding (decryption throws) versus valid padding whose plaintext is
+ * not JSON (`JSON.parse` throws) — into two different HTTP status codes turns
+ * this decorator into a padding oracle: one observable bit per request lets the
+ * attacker recover the plaintext byte by byte without the key
+ * (GHSA-pqj4-gvf7-6fq5).
+ *
+ * Both failure modes must therefore collapse into one indistinguishable
+ * `BadRequestException` (identical status, message, and body). Only the
+ * downstream type validation of an already-parsed body may report its own
+ * distinct error, because reaching it requires plaintext the attacker cannot
+ * forge without already knowing it.
+ *
+ * @internal
+ */
+const decode = (body: string, key: string, iv: string): unknown => {
   try {
-    return AesPkcs5.decrypt(body, key, iv);
+    return JSON.parse(AesPkcs5.decrypt(body, key, iv));
   } catch (exp) {
     if (exp instanceof Error)
       throw new BadRequestException(