@neocompose/cli 0.89.3 → 0.89.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 0.89.4
+
+### Patch Changes
+
+- 6136cce: Fix missing compiled child initializer bodies during offline status and export.
+  Refresh lazy compiler indexes after replacing initializer bodies, and compile
+  historical and edited constructor arguments in their respective document contexts.
+  Report remaining initialization failures at the authored child location.
+
+  Allow constructor initializers to use newly added local images and audio files
+  before upload while retaining local binary validation.
+
 ## 0.89.3
 
 ### Patch Changes

package/dist/neo-runtime.mjs

@@ -19377,7 +19377,7 @@ var init_registry = __esm({
   "../packages/manifest/schema-contract/registry.mjs"() {
     "use strict";
     PROJECT_SCHEMA_CONTRACT = Object.freeze({
-      cliVersion: "0.89.3",
+      cliVersion: "0.89.4",
       projectFileUploadBatchSize: 32,
       documentRecords: {
         member: {
@@ -133886,6 +133886,10 @@ function documentInitializerCompiler(document, compilationProject) {
     );
   };
 }
+function invalidateDocumentInitializerCompilationSites(document) {
+  documentMemberCompilationIndexes.delete(document);
+  documentValueInitializerCompilationSites.delete(document);
+}
 function valueInitializerCompilationSites(document) {
   const cached = documentValueInitializerCompilationSites.get(document);
   if (cached !== void 0) return cached;
@@ -158927,6 +158931,7 @@ function compilePulledProjectDocumentForEvaluationV4(document, compilationProjec
       throw error;
     }
   }
+  invalidateDocumentInitializerCompilationSites(document);
   return compiled;
 }
 function withoutMaterializedInstanceFields(row) {
@@ -159341,6 +159346,20 @@ var init_source_base_cache = __esm({
   }
 });
 
+// src/local-project-file-storage.ts
+function localStagedProjectFileStorage(recordId) {
+  return {
+    status: "uploaded",
+    storageKey: `local-candidate/${recordId}`,
+    storageETag: "local-candidate"
+  };
+}
+var init_local_project_file_storage = __esm({
+  "src/local-project-file-storage.ts"() {
+    "use strict";
+  }
+});
+
 // src/project-source/listener-emission.ts
 function emitListenerPositions(args) {
   const root = args.rows.get(args.rootId);
@@ -171074,6 +171093,8 @@ var init_value_sources = __esm({
 
 // src/project-source/runtime-diagnostic.ts
 function initializerErrorValueId(error) {
+  if (error instanceof UncompiledInitializerRuntimeError)
+    return error.valueId ?? error.initializerValueId;
   if (error instanceof NSGetterRuntimeError) return error.initializerValueId;
   if (error instanceof StoredClosureCaptureError) return error.valueId;
   if (error instanceof NeoScriptBodyCompileError)
@@ -171081,6 +171102,8 @@ function initializerErrorValueId(error) {
   return void 0;
 }
 function initializerErrorOwnerId(error) {
+  if (error instanceof UncompiledInitializerRuntimeError)
+    return error.sourceOwnerId ?? error.memberId ?? void 0;
   if (error instanceof NSGetterRuntimeError) return error.sourceOwnerId;
   if (error instanceof NeoScriptBodyCompileError && error.valueId === null)
     return error.memberId;
@@ -171090,8 +171113,15 @@ function initializerErrorSiteIds(error, recordId = (id2) => id2) {
   const ownerId = initializerErrorOwnerId(error);
   const valueId = initializerErrorValueId(error);
   const ids = [];
+  if (error instanceof UncompiledInitializerRuntimeError && valueId !== void 0)
+    ids.push(recordId(valueId));
   if (ownerId !== void 0) ids.push(recordId(ownerId));
   if (valueId === void 0) return ids;
+  if (error instanceof UncompiledInitializerRuntimeError) {
+    if (error.initializerValueId !== void 0)
+      ids.push(recordId(error.initializerValueId));
+    return ids;
+  }
   if (error instanceof NeoScriptBodyCompileError && error.argument !== null)
     ids.push(constructorArgumentSiteId(recordId(valueId), error.argument.key));
   ids.push(recordId(valueId));
@@ -171978,6 +172008,87 @@ function reconcileMaterializedInitializersV4(args) {
         }
         replayRows.set(id2, row);
       }
+      assertPulledConstructorsCompiled(replayDocument, replayContext);
+      currentRows ??= new Map(
+        currentState().document.values.map((row) => [row.id, row])
+      );
+      if (compareConstruction === void 0) {
+        const storedDocument = currentState().document;
+        compilePulledUncompiledConstructorsV4(storedDocument);
+        assertPulledConstructorsCompiled(storedDocument);
+        compareConstruction = createConstructionReplayComparer(
+          new EffectiveValueReader({
+            ...storedDocument,
+            initializerCompiler: documentInitializerCompiler(storedDocument)
+          }),
+          (root, member) => {
+            return storedOwnedValues().collect({
+              rootIds: [root.id],
+              rootMembers: /* @__PURE__ */ new Map([[root.id, member]])
+            });
+          },
+          new EffectiveValueReader({
+            ...replayDocument,
+            initializerCompiler: documentInitializerCompiler(
+              replayDocument,
+              compilationProject
+            )
+          })
+        );
+      }
+      const replay = replayRows.get(reconciliation.valueId);
+      if (replay === void 0) {
+        throw new Error(
+          `Construction replay for value "${reconciliation.valueId}" produced no root row.`
+        );
+      }
+      const currentRoot = currentRows.get(reconciliation.valueId);
+      if (currentRoot === void 0) {
+        throw new Error(
+          `Cannot reconcile stored construction for value "${reconciliation.valueId}": its stored row is missing.`
+        );
+      }
+      if (replay.classId !== currentRoot.classId) {
+        const position = composeReferenceSitePosition(
+          reconciliation.site,
+          args.sourceTextByUri
+        );
+        failures.push(
+          new SchemaSourceError(
+            `construction-arguments-conflict: Value "${reconciliation.valueId}" is already materialized as another class. Delete and recreate the value to change its class.`,
+            position.file,
+            position.line,
+            position.column,
+            "construction-arguments-conflict"
+          )
+        );
+        continue;
+      }
+      if (reconciliation.kind === "storedArguments" && compareConstruction({
+        currentRoot,
+        currentArguments: reconciliation.storedConstructorArgs,
+        replayRoot: replay,
+        replayRows,
+        rootMember: owner
+      })) {
+        continue;
+      }
+      const stored = currentState().records.get(
+        `value:${reconciliation.valueId}`
+      )?.data;
+      if (!isObjectRecord(stored)) {
+        throw new Error(
+          `Cannot rebuild construction for value "${reconciliation.valueId}": its pulled row is missing.`
+        );
+      }
+      rebuilds.push({
+        valueId: reconciliation.valueId,
+        row: rebuiltConstructionRow(stored, reconciliation.code),
+        ownedValueIds: storedOwnedValues().collect({
+          rootIds: [reconciliation.valueId],
+          rootMembers: /* @__PURE__ */ new Map([[reconciliation.valueId, owner]])
+        })
+      });
     } catch (error) {
       if (error instanceof NSGetterRuntimeError && error.source === void 0 && args.forceRecompile !== true) {
         return reconcileMaterializedInitializersV4({
@@ -171990,85 +172101,13 @@ function reconcileMaterializedInitializersV4(args) {
       failures.push(
         initializerRuntimeDiagnostic(
           error,
-          /* @__PURE__ */ new Map([[reconciliation.valueId, reconciliation.site]]),
+          args.initializerSites ?? /* @__PURE__ */ new Map([[reconciliation.valueId, reconciliation.site]]),
           args.sourceTextByUri,
           args.analysis
         )
       );
       continue;
     }
-    assertPulledConstructorsCompiled(replayDocument, replayContext);
-    currentRows ??= new Map(
-      currentState().document.values.map((row) => [row.id, row])
-    );
-    if (compareConstruction === void 0) {
-      const storedDocument = currentState().document;
-      compilePulledUncompiledConstructorsV4(storedDocument);
-      assertPulledConstructorsCompiled(storedDocument);
-      compareConstruction = createConstructionReplayComparer(
-        new EffectiveValueReader(storedDocument),
-        (root, member) => {
-          return storedOwnedValues().collect({
-            rootIds: [root.id],
-            rootMembers: /* @__PURE__ */ new Map([[root.id, member]])
-          });
-        },
-        new EffectiveValueReader(replayDocument)
-      );
-    }
-    const replay = replayRows.get(reconciliation.valueId);
-    if (replay === void 0) {
-      throw new Error(
-        `Construction replay for value "${reconciliation.valueId}" produced no root row.`
-      );
-    }
-    const currentRoot = currentRows.get(reconciliation.valueId);
-    if (currentRoot === void 0) {
-      throw new Error(
-        `Cannot reconcile stored construction for value "${reconciliation.valueId}": its stored row is missing.`
-      );
-    }
-    if (replay.classId !== currentRoot.classId) {
-      const position = composeReferenceSitePosition(
-        reconciliation.site,
-        args.sourceTextByUri
-      );
-      failures.push(
-        new SchemaSourceError(
-          `construction-arguments-conflict: Value "${reconciliation.valueId}" is already materialized as another class. Delete and recreate the value to change its class.`,
-          position.file,
-          position.line,
-          position.column,
-          "construction-arguments-conflict"
-        )
-      );
-      continue;
-    }
-    if (reconciliation.kind === "storedArguments" && compareConstruction({
-      currentRoot,
-      currentArguments: reconciliation.storedConstructorArgs,
-      replayRoot: replay,
-      replayRows,
-      rootMember: owner
-    })) {
-      continue;
-    }
-    const stored = currentState().records.get(
-      `value:${reconciliation.valueId}`
-    )?.data;
-    if (!isObjectRecord(stored)) {
-      throw new Error(
-        `Cannot rebuild construction for value "${reconciliation.valueId}": its pulled row is missing.`
-      );
-    }
-    rebuilds.push({
-      valueId: reconciliation.valueId,
-      row: rebuiltConstructionRow(stored, reconciliation.code),
-      ownedValueIds: storedOwnedValues().collect({
-        rootIds: [reconciliation.valueId],
-        rootMembers: /* @__PURE__ */ new Map([[reconciliation.valueId, owner]])
-      })
-    });
   }
   return { failures, rebuilds };
 }
@@ -172541,6 +172580,7 @@ function prospectiveInitializerRecordsV4(args) {
       deleted: false,
       data: change.operation === "create" && isObjectRecord(change.nextData) ? {
         ...change.nextData,
+        ...change.recordKind === "project-file" && change.nextData.status === "pending-upload" ? localStagedProjectFileStorage(change.recordId) : {},
         projectId: args.workspace.config.projectId,
         createdAt: 0,
         updatedAt: 0
@@ -172644,6 +172684,7 @@ var cleanRetainedCode, pulledStateDocuments;
 var init_local_initializer_materialization = __esm({
   "src/project-source/local-initializer-materialization.ts"() {
     "use strict";
+    init_local_project_file_storage();
     init_immutable_json3();
     init_lexer();
     init_init_source();
@@ -180232,6 +180273,7 @@ function computeStatus(workspace, options, conflictedFiles, parseErrors, parseWa
         changes,
         authoredValueSeeds,
         reconciliations: valueLowerRegistry.initializerReconciliations,
+        initializerSites: valueLowerRegistry.initializerSites,
         canonicalConstructions: valueLowerRegistry.materializedConstructorExpressions,
         localizedTextDependencies,
         manifest,
@@ -180251,11 +180293,11 @@ function computeStatus(workspace, options, conflictedFiles, parseErrors, parseWa
       });
     } catch (error) {
       parseErrors.push(
-        error instanceof SchemaSourceError ? error : new SchemaSourceError(
-          error instanceof Error ? error.message : String(error),
-          "<initializer-materialization>",
-          1,
-          1
+        initializerRuntimeDiagnostic(
+          error,
+          valueLowerRegistry.initializerSites,
+          new Map(sourceEntries.map((entry) => [entry.relPath, entry.source])),
+          projectAnalysisV4
         )
       );
     }
@@ -221322,13 +221364,6 @@ function completeLocallyStagedProjectFileChanges(args) {
     return completed;
   });
 }
-function localStagedProjectFileStorage(recordId) {
-  return {
-    status: "uploaded",
-    storageKey: `local-candidate/${recordId}`,
-    storageETag: "local-candidate"
-  };
-}
 function transportChangesForStatus(status) {
   return status.changes.map((change) => ({
     recordKind: change.recordKind,
@@ -223178,6 +223213,7 @@ var compileNSVoidBody2, compileNSFunction2, compileNSGetter2, compileNSSetter2,
 var init_push = __esm({
   "src/commands/push.ts"() {
     "use strict";
+    init_local_project_file_storage();
     init_extension_source_preservation();
     init_workspace_lock();
     init_export_state();
@@ -238663,7 +238699,7 @@ var releaseWorkspaceLock = () => void 0;
 async function main() {
   const args = parseArgs(process.argv.slice(2));
   if (args.command === "--version") {
-    console.log("0.89.3");
+    console.log("0.89.4");
     return;
   }
   if (args.command === null || args.command === "help" || args.command === "--help" || args.command === "-h") {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@neocompose/cli",
-  "version": "0.89.3",
+  "version": "0.89.4",
   "description": "Neo Compose native project-source CLI with bidirectional sync.",
   "license": "MIT",
   "type": "module",

package/skills/neocompose-cli/SKILL.md

@@ -9,7 +9,7 @@ description: >-
   `@neocompose/cli` or `node cli/bin/neo.mjs` in the neo-compose repository.
 ---
 
-<!-- reviewed-through-cli: 0.89.3 -->
+<!-- reviewed-through-cli: 0.89.4 -->
 
 # Neo Compose CLI
 

package/skills/neocompose-cli/references/cli-development.md

@@ -109,7 +109,7 @@ The marker near the top of `SKILL.md` must exactly match the package version,
 and this quoted copy is checked too:
 
 ```html
-<!-- reviewed-through-cli: 0.89.3 -->
+<!-- reviewed-through-cli: 0.89.4 -->
 ```
 
 Keep this skill on current behavior. Upgrade steps, rollout prerequisites,

package/skills/neocompose-cli/references/declarations/initializers.md

@@ -20,6 +20,8 @@ Immutable construction, and edits to stored constructions.
 - Editing a header constructor recompiles dependent child initializers in the
   new scope, including unchanged children with explicit IDs. Keep those IDs
   when adding an optional parameter and updating the child expression.
+  Status and export compile these dependencies locally, including children
+  reached while comparing stored constructor arguments.
 - Omitted constructor fields use their defaults. Writable collection defaults
   belong to each instance. Fields without defaults stay absent, and `null`
   arguments to generated member-wise constructors mean omission.

package/skills/neocompose-cli/references/values/files.md

@@ -57,6 +57,8 @@ AudioClipRegistry AudioClips = new() {
   create a pending file with a provisional symbol. Status, diff, and dry-run
   don't rewrite the registry; a successful push creates the record, uploads
   verified bytes, and writes its declaration and ID.
+  Initializers may use these local files during status and offline export before
+  upload. Missing local bytes still block validation.
 - Remove the declaration to delete a file. A declaration whose binary is
   missing is an error.
 - Pull keeps unchanged entries, comments, and order; new remote entries