@neocompose/cli 0.24.8 → 0.24.9

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## [0.24.9] - 2026-08-08
+
+### Fixed
+
+- Build `neo test` execution documents from the server-prepared candidate and
+  compile every remaining authored initializer into evaluator-only IR. Tests
+  can now construct classes whose pending idless list rows capture lexical
+  selectors without requiring an earlier push.
+- Index constructor-initializer ownership by class and member instead of
+  repeatedly scanning the project document. This reduces Neowyn's
+  initializer-owner walk from 87.8 ms to 24.9 ms median.
+
 ## [0.24.8] - 2026-08-08
 
 ### Fixed

package/dist/neo.mjs

@@ -54910,6 +54910,14 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
   const resolved = /* @__PURE__ */ new Map();
   if (targetValueIds.size === 0) return resolved;
   const valuesById = new Map(document.values.map((value) => [value.id, value]));
+  const membersById = new Map(
+    document.members.map((member) => [member.id, member])
+  );
+  const classesById = new Map(
+    document.classes.map((schemaClass2) => [schemaClass2.id, schemaClass2])
+  );
+  const storedSchemaByClassId = /* @__PURE__ */ new Map();
+  const defaultInstanceEnvByClassId = /* @__PURE__ */ new Map();
   const rowsByContainerId = /* @__PURE__ */ new Map();
   for (const value of document.values) {
     if (typeof value.containerId !== "string") continue;
@@ -54933,7 +54941,25 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
     if (typeof memberId !== "string") return /* @__PURE__ */ new Map();
     const classId = declaringClassIdByMemberId.get(memberId);
     if (classId === void 0) return /* @__PURE__ */ new Map();
-    return resolveInstanceEnv(classId, void 0, document.classes);
+    return defaultInstanceEnv(classId);
+  }
+  function defaultInstanceEnv(classId) {
+    const cached = defaultInstanceEnvByClassId.get(classId);
+    if (cached !== void 0) return cached;
+    const created = resolveInstanceEnv(classId, void 0, document.classes);
+    defaultInstanceEnvByClassId.set(classId, created);
+    return created;
+  }
+  function storedSchema(classId) {
+    const cached = storedSchemaByClassId.get(classId);
+    if (cached !== void 0) return cached;
+    const created = mergeStoredInstanceSchema(
+      classId,
+      document.classes,
+      document.members
+    );
+    storedSchemaByClassId.set(classId, created);
+    return created;
   }
   function searchRow(member, valueId, rootOwner, env, rootKind) {
     if (targetValueIds.has(valueId) && !resolved.has(valueId)) {
@@ -54972,16 +54998,10 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
     if (isMemberClassBase(member)) {
       if (!isRecordValue(body.value)) return;
       const effectiveClassId = body.classId ?? member.classId;
-      const schemaClass2 = document.classes.find(
-        (candidate) => candidate.id === effectiveClassId
-      );
+      const schemaClass2 = classesById.get(effectiveClassId);
       if (schemaClass2 === void 0) return;
-      const merged = mergeStoredInstanceSchema(
-        effectiveClassId,
-        document.classes,
-        document.members
-      );
-      const env = resolveInstanceEnv(
+      const merged = storedSchema(effectiveClassId);
+      const env = member.classArguments === void 0 || member.classArguments === null ? defaultInstanceEnv(effectiveClassId) : resolveInstanceEnv(
         effectiveClassId,
         member.classArguments,
         document.classes
@@ -54990,9 +55010,7 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
         if (entry.memberId === null) continue;
         const childValueId = body.value[entry.schemaKey];
         if (childValueId === void 0) continue;
-        const childMember = document.members.find(
-          (candidate) => candidate.id === entry.memberId
-        );
+        const childMember = membersById.get(entry.memberId);
         if (childMember === void 0) continue;
         const substituted = trySubstituteMember(childMember, env);
         if (substituted === null) continue;
@@ -55002,9 +55020,7 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
     }
     if (isMemberDictionaryBase(member)) {
       if (!isRecordValue(body.value)) return;
-      const entryMemberRecord = document.members.find(
-        (candidate) => candidate.id === member.entryMemberId
-      );
+      const entryMemberRecord = membersById.get(member.entryMemberId);
       if (entryMemberRecord === void 0) return;
       const entryEnv = overlayStamp(ambientEnv, body.genericBindings);
       const entryMember = trySubstituteMember(entryMemberRecord, entryEnv);
@@ -55015,9 +55031,7 @@ function resolveOwnerMembersForValues(document, targetValueIds, additionalRoots,
       return;
     }
     if (isMemberListBase(member)) {
-      const entryMemberRecord = document.members.find(
-        (candidate) => candidate.id === member.entryMemberId
-      );
+      const entryMemberRecord = membersById.get(member.entryMemberId);
       if (entryMemberRecord === void 0) return;
       const entryEnv = overlayStamp(ambientEnv, body.genericBindings);
       const entryMember = trySubstituteMember(entryMemberRecord, entryEnv);
@@ -63462,21 +63476,17 @@ function initializerEvaluatorLookups(document) {
   });
   return lookups;
 }
-function buildInitializerRootValue(document) {
+function buildInitializerRootValue(document, lookups) {
   const rootValue = {};
-  const memberById = new Map(
-    document.members.map((member) => [member.id, member])
-  );
-  const valueById = new Map(document.values.map((row) => [row.id, row]));
   for (const { root, memberId } of projectRootMembersInDisplayOrder(
     document.project
   )) {
-    const member = memberById.get(memberId);
-    if (member === void 0 || typeof member.valueId !== "string") {
+    const member = lookups.memberById(memberId);
+    if (member === null || typeof member.valueId !== "string") {
       rootValue[root.key] = null;
       continue;
     }
-    rootValue[root.key] = valueById.get(member.valueId)?.value ?? null;
+    rootValue[root.key] = lookups.valueById(member.valueId)?.value ?? null;
   }
   return rootValue;
 }
@@ -63489,6 +63499,7 @@ function evaluateMemberInitializer(args) {
       args.init
     );
   }
+  const databaseVM = initializerEvaluatorLookups(args.document);
   const ctx = {
     vm: {
       project: args.document.project,
@@ -63502,10 +63513,10 @@ function evaluateMemberInitializer(args) {
       interfaces: args.document.interfaces,
       localizedTexts: args.document.localizedTexts,
       localizationConfig: args.document.localizationConfig,
-      databaseVM: initializerEvaluatorLookups(args.document)
+      databaseVM
     },
     thisValue: null,
-    rootValue: buildInitializerRootValue(args.document),
+    rootValue: buildInitializerRootValue(args.document, databaseVM),
     saveStaticBindings: args.saveStaticBindings,
     sessionStaticBindings: args.sessionStaticBindings,
     ...args.storedConstructionReplay === true ? {
@@ -84137,6 +84148,7 @@ function assertServerPreparationSucceeds(args) {
         prepared
       );
     }
+    return prepared;
   } catch (error) {
     throw locateBodyCompileFailure(error, args.sourceByRecord);
   }
@@ -84354,7 +84366,7 @@ function replayStoredConstructionV4(args) {
         "Construction replay cannot compile document bodies without a compiler project."
       );
     }
-    compilePulledProjectDocumentBodiesV4(document, compilationProject);
+    compilePulledProjectDocumentForEvaluationV4(document, compilationProject);
   }
   const root = document.values.find((value) => value.id === args.valueId);
   if (root === void 0) {
@@ -84550,7 +84562,16 @@ function compilePulledValueInitializerBodyV4(document, valueId, compilationProje
     ...compilationProject === void 0 ? {} : { compilationProject }
   });
 }
-function compilePulledProjectDocumentBodiesV4(document, compilationProject) {
+function compilePulledProjectDocumentForEvaluationV4(document, compilationProject) {
+  const sharedCompilationProject = compilationProject ?? createNeoScriptCompilationProject({
+    project: document.project,
+    projectFiles: document.projectFiles,
+    members: document.members,
+    classes: document.classes,
+    enums: document.enums,
+    interfaces: document.interfaces,
+    constructors: document.constructors ?? []
+  });
   const compileArgs = {
     project: document.project,
     projectFiles: document.projectFiles,
@@ -84559,7 +84580,7 @@ function compilePulledProjectDocumentBodiesV4(document, compilationProject) {
     enums: document.enums,
     interfaces: document.interfaces,
     constructors: document.constructors ?? [],
-    compilationProject
+    compilationProject: sharedCompilationProject
   };
   for (const constructor2 of compileArgs.constructors) {
     compileConstructorRecord({ ...compileArgs, constructor: constructor2 });
@@ -84579,6 +84600,20 @@ function compilePulledProjectDocumentBodiesV4(document, compilationProject) {
       thisClass: ownerClassByMemberId.get(member.id) ?? null
     });
   }
+  for (const site of valueInitializerCompilationSites(document).values()) {
+    if (isInitValueContent(site.row) && site.row.init.compiled !== void 0) {
+      continue;
+    }
+    compileValueRowInitializerBody({
+      ...compileArgs,
+      member: site.member,
+      valueRow: site.row,
+      valueId: String(Reflect.get(site.row, "id")),
+      initializerOwnerClass: site.ownerClass,
+      lexicalThisClass: site.lexicalThisClass,
+      storedConstructionReplay: true
+    });
+  }
 }
 function assertPulledConstructorsCompiled(document) {
   const uncompiled = (document.constructors ?? []).find(
@@ -100098,6 +100133,7 @@ async function prepareLocalPushArtifactsV4(workspace, status, onPhase = () => vo
     status.changes,
     localizedTextCreateEnvelopeConfig2(workspace, status.changes)
   );
+  let preparedChanges = null;
   if (options.fullValidation) {
     onPhase("Verifying the complete source round trip\u2026");
     verifyProjectSourceCommitAgainstStateV4({
@@ -100114,7 +100150,7 @@ async function prepareLocalPushArtifactsV4(workspace, status, onPhase = () => vo
     onPhase(
       `Rehearsing server validation for ${transportChanges.length.toLocaleString("en-US")} change(s)\u2026`
     );
-    assertServerPreparationSucceeds({
+    preparedChanges = assertServerPreparationSucceeds({
       workspace,
       changes: transportChanges,
       authoredValueSeeds: transportSeeds,
@@ -100129,7 +100165,8 @@ async function prepareLocalPushArtifactsV4(workspace, status, onPhase = () => vo
     transactionOperation,
     transportChanges,
     transportSeeds,
-    preparedFiles
+    preparedFiles,
+    preparedChanges
   };
 }
 async function prepareLocalCandidateV4(workspace, options = {}) {
@@ -100203,8 +100240,23 @@ async function prepareLocalCandidateV4(workspace, options = {}) {
     if (typeof baseId === "string") {
       records2.delete(`${change.recordKind}:${baseId}`);
     }
+  }
+  const candidateChanges = preparedLocal?.preparedChanges ?? documentStatus.changes.map((change) => ({
+    recordKind: change.recordKind,
+    recordId: change.recordId,
+    operation: change.kind,
+    nextData: change.nextData
+  }));
+  for (const change of candidateChanges) {
     records2.delete(`${change.recordKind}:${change.recordId}`);
-    if (change.nextData === void 0) continue;
+    if (change.operation === "delete" || change.nextData === void 0) {
+      continue;
+    }
+    if (!isObjectRecord2(change.nextData)) {
+      throw new Error(
+        `Prepared ${change.recordKind} record ${JSON.stringify(change.recordId)} has invalid data.`
+      );
+    }
     const nextId = typeof change.nextData.id === "string" ? change.nextData.id : change.recordId;
     records2.set(`${change.recordKind}:${nextId}`, {
       recordKind: change.recordKind,
@@ -100214,9 +100266,11 @@ async function prepareLocalCandidateV4(workspace, options = {}) {
       data: change.nextData
     });
   }
+  const document = readPulledProjectDocumentV4(records2);
+  compilePulledProjectDocumentForEvaluationV4(document);
   return {
     status,
-    document: readPulledProjectDocumentV4(records2),
+    document,
     sourceHash,
     preparedLocal
   };
@@ -101670,7 +101724,7 @@ var init_registry2 = __esm({
     PROJECT_SCHEMA_CONTRACT = Object.freeze({
       formatVersion: 3,
       contractVersion: "3.9",
-      cliVersion: "0.24.8",
+      cliVersion: "0.24.9",
       projectFileUploadBatchSize: 32,
       documentRecords: {
         member: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@neocompose/cli",
-  "version": "0.24.8",
+  "version": "0.24.9",
   "description": "Neo Compose native project-source CLI with bidirectional sync.",
   "license": "MIT",
   "type": "module",

package/skills/neocompose-cli/SKILL.md

@@ -9,7 +9,7 @@ description: >-
   `@neocompose/cli` or `node cli/bin/neo.mjs` in the neo-compose repository.
 ---
 
-<!-- reviewed-through-cli: 0.24.8 -->
+<!-- reviewed-through-cli: 0.24.9 -->
 
 # Neo Compose CLI
 
@@ -30,6 +30,9 @@ Those are not part of format 4.
    existed before the task began.
 4. Run `neo test` after NeoScript changes and `neo dialogue dryrun <ref>` after
    dialogue changes.
+   `neo test` compiles the complete pending candidate, including idless nested
+   construction rows, so tests must work before the first push; do not add IDs
+   or push merely to obtain compiled initializer bodies.
 5. Run `neo push --dry-run` before every real push. It performs the full local
    source emission, ID-assignment, transport-shape, hash, and repeat-verification path,
    then rehearses the server's preparation phase — schema-commit

package/skills/neocompose-cli/references/cli-development.md

@@ -82,7 +82,7 @@ wrappers.
 The marker near the top of `SKILL.md` must exactly match the package version:
 
 ```html
-<!-- reviewed-through-cli: 0.24.8 -->
+<!-- reviewed-through-cli: 0.24.9 -->
 ```
 
 The quoted version above is checked too, so this instruction cannot go stale