@neocompose/cli 0.24.2 → 0.24.4

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## [0.24.4] - 2026-08-07
+
+### Fixed
+
+- Preserve every operand and its grouping when compiling chained NeoScript
+  `&&` and `||` expressions. The previous lowering overwrote the left
+  expression's connective, so `a || b || c` evaluated as `a || c`.
+- Short-circuit logical expressions in the local evaluator instead of eagerly
+  evaluating an unused right-hand operand.
+
+## [0.24.3] - 2026-08-07
+
+### Fixed
+
+- Close generic classes constructed by normal member-default evaluation from
+  the concrete member slot, so local candidate preparation no longer rejects
+  values such as `NeoAnimationSegmentFrame<int>` as open generics before
+  `neo test` can discover or execute tests.
+- Key compiled spec artifacts by the prepared candidate document as well as
+  source, preventing stale pending class and enum IDs from leaking across
+  repeated `neo test` runs.
+
+### Changed
+
+- Require full-project `neo test` validation in the bundled CLI development
+  guidance when evaluator or candidate-materialization behavior changes.
+
 ## [0.24.2] - 2026-08-07
 
 ### Fixed

package/dist/neo.mjs

@@ -7323,7 +7323,7 @@ var NEOSCRIPT_COMPILER_REVISION;
 var init_strict_ir = __esm({
   "../packages/neoscript-language/src/strict-ir.ts"() {
     "use strict";
-    NEOSCRIPT_COMPILER_REVISION = 7;
+    NEOSCRIPT_COMPILER_REVISION = 8;
   }
 });
 
@@ -8157,6 +8157,9 @@ function pointerToBooleanExpression(pointer) {
   if (pointer.type === "operation" /* Operation */ && pointer.operation.type === "boolean" /* Boolean */) {
     return pointer.operation.expression;
   }
+  return pointerToBooleanOperandExpression(pointer);
+}
+function pointerToBooleanOperandExpression(pointer) {
   return {
     condition: {
       type: "equalTo" /* EqualTo */,
@@ -12701,7 +12704,7 @@ var init_strict_resolver = __esm({
               operation: {
                 type: "boolean" /* Boolean */,
                 expression: {
-                  ...pointerToBooleanExpression(l.pointer),
+                  ...pointerToBooleanOperandExpression(l.pointer),
                   connective: {
                     type: expression.op === "&&" ? "&&" /* And */ : "||" /* Or */,
                     to: pointerToBooleanExpression(r.pointer)
@@ -60276,12 +60279,11 @@ function stringifyForInterp(v) {
 function evalBooleanExpression(expression, scope, ctx) {
   const head = evalCondition(expression.condition, scope, ctx);
   if (!expression.connective) return head;
-  const tail = evalBooleanExpression(expression.connective.to, scope, ctx);
   switch (expression.connective.type) {
     case "&&" /* and */:
-      return head && tail;
+      return head ? evalBooleanExpression(expression.connective.to, scope, ctx) : false;
     case "||" /* or */:
-      return head || tail;
+      return head ? true : evalBooleanExpression(expression.connective.to, scope, ctx);
   }
 }
 function evalCondition(condition, scope, ctx) {
@@ -60764,8 +60766,8 @@ function validateClassConstructorDescriptor(info, ctx, requireEveryRequiredField
       `Cannot construct abstract Class '${schemaClass2.name}'.`
     );
   }
-  const replaySlot = ctx.__storedConstructionReplayNestedSlots?.toReversed().find((slot) => slot.classId === classId) ?? ctx.__storedConstructionReplaySlot;
-  const classArguments2 = replaySlot?.classId === classId ? replaySlot.classArguments : void 0;
+  const genericSlot = ctx.__constructionGenericSlots?.toReversed().find((slot) => slot.classId === classId) ?? ctx.__storedConstructionReplaySlot;
+  const classArguments2 = genericSlot?.classId === classId ? genericSlot.classArguments : void 0;
   const instanceEnv = resolveInstanceEnv(
     classId,
     classArguments2,
@@ -61621,7 +61623,7 @@ function constructionInitEvaluator(ctx, createdValues, argumentScopes, construct
   };
   return (member, init, sourceValueId) => {
     const evaluate = (argumentValues = []) => {
-      if (ctx.storedConstructionReplay !== true || !isMemberClassBase(member) || Object.keys(member.classArguments ?? {}).length === 0) {
+      if (!isMemberClassBase(member) || Object.keys(member.classArguments ?? {}).length === 0) {
         return evaluateInitializerInContext(
           init,
           member,
@@ -61631,8 +61633,8 @@ function constructionInitEvaluator(ctx, createdValues, argumentScopes, construct
           sourceValueId ?? null
         );
       }
-      const previousSlots = ctx.__storedConstructionReplayNestedSlots;
-      ctx.__storedConstructionReplayNestedSlots = [
+      const previousSlots = ctx.__constructionGenericSlots;
+      ctx.__constructionGenericSlots = [
         ...previousSlots ?? [],
         {
           classId: member.classId,
@@ -61649,7 +61651,7 @@ function constructionInitEvaluator(ctx, createdValues, argumentScopes, construct
           sourceValueId ?? null
         );
       } finally {
-        ctx.__storedConstructionReplayNestedSlots = previousSlots;
+        ctx.__constructionGenericSlots = previousSlots;
       }
     };
     if (init.compiled === void 0) {
@@ -101546,7 +101548,7 @@ var init_registry2 = __esm({
     PROJECT_SCHEMA_CONTRACT = Object.freeze({
       formatVersion: 3,
       contractVersion: "3.9",
-      cliVersion: "0.24.2",
+      cliVersion: "0.24.4",
       projectFileUploadBatchSize: 32,
       documentRecords: {
         member: {
@@ -103077,7 +103079,7 @@ function preparedHookCandidate(workspace) {
     );
   }
 }
-function compileSpec(workspace, document, absolutePath, projectSourceHash) {
+function compileSpec(workspace, document, absolutePath, projectCompilationHash2) {
   const scriptDocument = readDocumentArrays(document);
   const path = relative6(workspace.root, absolutePath).split(sep6).join("/");
   const source = readFileSync17(absolutePath, "utf8");
@@ -103087,12 +103089,12 @@ function compileSpec(workspace, document, absolutePath, projectSourceHash) {
     ".neo",
     "test-build",
     "v1",
-    projectSourceHash,
+    projectCompilationHash2,
     `${sourceHash}.json`
   );
   try {
     const cached = JSON.parse(readFileSync17(artifactPath, "utf8"));
-    if (isRecord10(cached) && cached.version === 1 && cached.compilerRevision === NEOSCRIPT_COMPILER_REVISION && cached.projectSourceHash === projectSourceHash && cached.sourceHash === sourceHash && isRecord10(cached.action) && typeof cached.artifactSha256 === "string" && createHash10("sha256").update(JSON.stringify(cached.action)).digest("hex") === cached.artifactSha256 && cached.action.compilerRevision === NEOSCRIPT_COMPILER_REVISION && Array.isArray(cached.action.parameters) && Array.isArray(cached.action.instructions) && isRecord10(cached.action.typeInfo)) {
+    if (isRecord10(cached) && cached.version === 1 && cached.compilerRevision === NEOSCRIPT_COMPILER_REVISION && cached.projectCompilationHash === projectCompilationHash2 && cached.sourceHash === sourceHash && isRecord10(cached.action) && typeof cached.artifactSha256 === "string" && createHash10("sha256").update(JSON.stringify(cached.action)).digest("hex") === cached.artifactSha256 && cached.action.compilerRevision === NEOSCRIPT_COMPILER_REVISION && Array.isArray(cached.action.parameters) && Array.isArray(cached.action.instructions) && isRecord10(cached.action.typeInfo)) {
       return {
         path,
         source,
@@ -103122,7 +103124,7 @@ function compileSpec(workspace, document, absolutePath, projectSourceHash) {
     `${JSON.stringify({
       version: 1,
       compilerRevision: NEOSCRIPT_COMPILER_REVISION,
-      projectSourceHash,
+      projectCompilationHash: projectCompilationHash2,
       sourceHash,
       artifactSha256: createHash10("sha256").update(JSON.stringify(compiled.action)).digest("hex"),
       action: compiled.action
@@ -103131,6 +103133,9 @@ function compileSpec(workspace, document, absolutePath, projectSourceHash) {
   );
   return compiled;
 }
+function projectCompilationHash(projectSourceHash, document) {
+  return createHash10("sha256").update(projectSourceHash).update("\0").update(JSON.stringify(document)).digest("hex");
+}
 function selectedSpecPaths(workspace, selectors) {
   const all = listProjectTestFilesV1(workspace.root);
   const relativePaths = new Map(
@@ -104006,6 +104011,10 @@ async function runTest(workspace, options, dependencies = {}) {
     }
     projectFingerprint = `sha256:${candidate.sourceHash}`;
     const rawDocument = documentRecord(candidate.document);
+    const compilationHash = projectCompilationHash(
+      candidate.sourceHash,
+      rawDocument
+    );
     phase = "select";
     let selectedPaths;
     try {
@@ -104023,7 +104032,7 @@ async function runTest(workspace, options, dependencies = {}) {
     }
     phase = "compile";
     specs = selectedPaths.map(
-      (path) => compileSpec(workspace, rawDocument, path, candidate.sourceHash)
+      (path) => compileSpec(workspace, rawDocument, path, compilationHash)
     );
     let pattern = null;
     if (options.testNamePattern !== null) {
@@ -104216,10 +104225,14 @@ async function inspectNeoTestCompilation(workspace, dependencies = {}) {
     };
   }
   const document = documentRecord(candidate.document);
+  const compilationHash = projectCompilationHash(
+    candidate.sourceHash,
+    document
+  );
   const errors = [];
   for (const path of selectedPaths) {
     try {
-      compileSpec(workspace, document, path, candidate.sourceHash);
+      compileSpec(workspace, document, path, compilationHash);
     } catch (error) {
       errors.push({
         file: relative6(workspace.root, path).split(sep6).join("/"),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@neocompose/cli",
-  "version": "0.24.2",
+  "version": "0.24.4",
   "description": "Neo Compose native project-source CLI with bidirectional sync.",
   "license": "MIT",
   "type": "module",

package/skills/neocompose-cli/SKILL.md

@@ -9,7 +9,7 @@ description: >-
   `@neocompose/cli` or `node cli/bin/neo.mjs` in the neo-compose repository.
 ---
 
-<!-- reviewed-through-cli: 0.24.2 -->
+<!-- reviewed-through-cli: 0.24.4 -->
 
 # Neo Compose CLI
 

package/skills/neocompose-cli/references/cli-development.md

@@ -82,7 +82,7 @@ wrappers.
 The marker near the top of `SKILL.md` must exactly match the package version:
 
 ```html
-<!-- reviewed-through-cli: 0.24.2 -->
+<!-- reviewed-through-cli: 0.24.4 -->
 ```
 
 The quoted version above is checked too, so this instruction cannot go stale
@@ -115,5 +115,7 @@ npm run doctor
 
 Also run contract/corpus checks, Monaco/browser parity, VSIX packaging, and
 interactive sample no-op verification when the corresponding implementation
-surface changes. Run `npm run doctor` last; do not rerun successful suites only
-because doctor formatted files.
+surface changes. Evaluator or candidate-materialization changes also require an
+actual `neo test` run against the affected full-project candidate; focused
+Vitest coverage does not replace that end-to-end command. Run `npm run doctor`
+last; do not rerun successful suites only because doctor formatted files.

package/skills/neocompose-cli/references/neoscript.md

@@ -7,6 +7,7 @@ runtime ownership, evaluation, and migrations.
 
 - Inline bodies and snippets
 - Nullability and ownership
+- Logical operators
 - Loops and transfer
 - Switch
 - Try/catch
@@ -53,6 +54,13 @@ Save, Session, Setter, or otherwise writable. A constructor writes only its
 `this` instance. A writable structured-leaf field still inherits the receiver's
 effective storage restrictions.
 
+## Logical operators
+
+Use `&&` and `||` with C# precedence: `&&` binds tighter than `||`, and
+parentheses preserve explicit grouping. Both operators short-circuit, so the
+right operand is evaluated only when it can change the result. Chained
+expressions retain every operand; `a || b || c` never skips `b`.
+
 ## Loops and transfer
 
 Use C#-shaped loops: