@neocompose/cli 0.19.2 → 0.19.3

package/dist/neo.mjs

@@ -21593,6 +21593,14 @@ var init_project_source_type_checker = __esm({
 });
 
 // ../packages/neoscript-language/src/project-source-analysis.ts
+function isSystemReservedRecordId(id2) {
+  if (id2 === null) return false;
+  if (id2.startsWith(SYSTEM_RECORD_ID_PREFIX)) return true;
+  if (QUARANTINED_LEGACY_SYSTEM_RECORD_IDS.has(id2)) return true;
+  return QUARANTINED_LEGACY_SYSTEM_ID_PREFIXES.some(
+    (prefix) => id2.startsWith(prefix)
+  );
+}
 function isEnumOptionId(id2) {
   if (isPendingId(id2)) return true;
   if (id2.startsWith(SYSTEM_RECORD_ID_PREFIX)) {
@@ -21637,6 +21645,7 @@ function analyzeNeoProjectSources(inputs) {
     }
   }
   validateSymbolUniqueness(symbols, diagnostics);
+  validateSystemAnnotationAuthoring(documents, diagnostics);
   validateTypeReferences(documents, symbols, diagnostics);
   diagnostics.push(...validateProjectSourceTypes(documents));
   diagnostics.push(...validateProjectSourceSettlement(documents));
@@ -21930,6 +21939,124 @@ function sourceId(uri, annotations, diagnostics) {
   }
   return id2;
 }
+function declaredIdValue(annotations) {
+  const annotation2 = annotations.find((entry) => entry.name === "id");
+  if (annotation2 === void 0) return null;
+  if (annotation2.arguments.length !== 1) return null;
+  const id2 = decodeStringLiteral(annotation2.arguments[0].text);
+  if (id2 === null || id2.length === 0) return null;
+  return id2;
+}
+function systemAnnotation(annotations) {
+  return annotations.find((entry) => entry.name === "system");
+}
+function validateSystemAnnotationAuthoring(documents, diagnostics) {
+  const owners = /* @__PURE__ */ new Map();
+  for (const [uri, document] of documents) {
+    for (const declaration of document.declarations) {
+      if (declaration.kind !== "class" && declaration.kind !== "interface") {
+        continue;
+      }
+      const key = declaration.name.toLowerCase();
+      if (!owners.has(key)) owners.set(key, { uri, declaration });
+    }
+  }
+  for (const [uri, document] of documents) {
+    for (const declaration of document.declarations) {
+      const declarationAnnotation = systemAnnotation(declaration.annotations);
+      const declarationId = declaredIdValue(declaration.annotations);
+      if (declarationAnnotation !== void 0 && !isSystemReservedRecordId(declarationId)) {
+        diagnostics.push(
+          authoredSystemDiagnostic(
+            uri,
+            declarationAnnotation,
+            declaration.name,
+            declarationId
+          )
+        );
+      }
+      if (declaration.kind !== "class" && declaration.kind !== "interface") {
+        continue;
+      }
+      for (const member of declaration.members) {
+        const annotation2 = systemAnnotation(member.annotations);
+        if (annotation2 === void 0) continue;
+        const memberId = declaredIdValue(member.annotations);
+        if (isSystemReservedRecordId(memberId)) continue;
+        const label = `${declaration.name}.${member.name}`;
+        const inherited = inheritedSystemMember(
+          declaration,
+          member.name,
+          owners
+        );
+        if (inherited === null) {
+          diagnostics.push(
+            authoredSystemDiagnostic(uri, annotation2, label, memberId)
+          );
+          continue;
+        }
+        diagnostics.push({
+          uri,
+          range: annotation2.range,
+          severity: "error",
+          source: "neo-project",
+          code: "authored-system-annotation-on-override",
+          message: `@system on '${label}' is platform protection metadata Neo Compose sets on its own records. '${inherited.site.declaration.name}.${inherited.member.name}' carries it because the platform owns that record; carrying it on your own override would lock you out of editing or deleting it. Remove @system from the override.`,
+          relatedInformation: [
+            {
+              location: {
+                uri: inherited.site.uri,
+                range: inherited.member.nameRange
+              },
+              message: "The protected base member is declared here."
+            }
+          ]
+        });
+      }
+    }
+  }
+}
+function authoredSystemDiagnostic(uri, annotation2, label, id2) {
+  return {
+    uri,
+    range: annotation2.range,
+    severity: "error",
+    source: "neo-project",
+    code: "authored-system-annotation",
+    message: `@system on '${label}' is platform protection metadata Neo Compose sets on its own records, and ${systemIdentityClause(label, id2)}. Remove @system.`
+  };
+}
+function systemIdentityClause(label, id2) {
+  if (id2 === null) {
+    return `'${label}' declares no @id, so it is a project record this push would create`;
+  }
+  return `@id '${id2}' is not in the reserved '${SYSTEM_RECORD_ID_PREFIX}' namespace`;
+}
+function inheritedSystemMember(declaration, memberName, owners) {
+  const target = memberName.toLowerCase();
+  const seen = /* @__PURE__ */ new Set([declaration.name.toLowerCase()]);
+  const queue = baseSites(declaration, owners);
+  while (queue.length > 0) {
+    const site = queue.shift();
+    const key = site.declaration.name.toLowerCase();
+    if (seen.has(key)) continue;
+    seen.add(key);
+    const member = site.declaration.members.find(
+      (entry) => entry.name.toLowerCase() === target && systemAnnotation(entry.annotations) !== void 0
+    );
+    if (member !== void 0) return { site, member };
+    queue.push(...baseSites(site.declaration, owners));
+  }
+  return null;
+}
+function baseSites(declaration, owners) {
+  const sites = [];
+  for (const base of declaration.baseTypes) {
+    const site = owners.get(base.name.toLowerCase());
+    if (site !== void 0) sites.push(site);
+  }
+  return sites;
+}
 function validateSymbolUniqueness(symbols, diagnostics) {
   const names = /* @__PURE__ */ new Map();
   const ids = /* @__PURE__ */ new Map();
@@ -22115,7 +22242,7 @@ function emptyRange2() {
     end: { line: 0, character: 0 }
   };
 }
-var BUILTIN_TYPE_NAMES, RESERVED_NAMES3, SYSTEM_RECORD_ID_PREFIX, RFC_4122_UUID;
+var BUILTIN_TYPE_NAMES, RESERVED_NAMES3, SYSTEM_RECORD_ID_PREFIX, RFC_4122_UUID, QUARANTINED_LEGACY_SYSTEM_ID_PREFIXES, QUARANTINED_LEGACY_SYSTEM_RECORD_IDS;
 var init_project_source_analysis = __esm({
   "../packages/neoscript-language/src/project-source-analysis.ts"() {
     "use strict";
@@ -22150,6 +22277,23 @@ var init_project_source_analysis = __esm({
     RESERVED_NAMES3 = new Set(NEOSCRIPT_KEYWORDS);
     SYSTEM_RECORD_ID_PREFIX = "system_";
     RFC_4122_UUID = /^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/u;
+    QUARANTINED_LEGACY_SYSTEM_ID_PREFIXES = [
+      "neo-tile-grid-record-relations-v1-member-"
+    ];
+    QUARANTINED_LEGACY_SYSTEM_RECORD_IDS = /* @__PURE__ */ new Set([
+      "430fca56-b45a-4896-9ab2-795a3faf57f6",
+      // VaultPlaqueObject.PlacementTiles
+      "47c21aa5-e852-41d2-882c-b4f555aee9dd",
+      // PlayerSpawnObject.PlacementTiles
+      "571a0e0b-b36c-45f3-ae9a-5fde39045c11",
+      // ExitPromptObject.PlacementTiles
+      "8e8c5ddf-6273-4440-869e-f1f9ca5dc51b",
+      // ExitPromptObject.Size
+      "94472662-a3a9-4c02-8abb-6229442e1e49",
+      // RecoveryCacheObject.Collider
+      "d8e9ad0e-157f-4709-96a7-8775efa3dd11"
+      // RecoveryCacheObject.PlacementTiles
+    ]);
   }
 });
 
@@ -45118,7 +45262,7 @@ ${namedArguments(
 function emitLocalizationStatus(status, identifier2, names) {
   const annotations = [
     id(status.id).trimEnd(),
-    ...status.system ? [systemAnnotation(status.system)] : []
+    ...status.system ? [systemAnnotation2(status.system)] : []
   ];
   const statusReference = (value) => value === null ? "null" : names.get(value) ?? `Reference<LocalizationStatus>(id: ${quote(value)})`;
   return `${annotations.join("\n")}
@@ -45162,7 +45306,7 @@ function emitClass(context, schemaClass2, memberIds) {
     ...schemaClass2.targetMemberId ? [
       `@settings(target: ${qualifiedMember(context, schemaClass2.targetMemberId)})`
     ] : [],
-    ...schemaClass2.system ? [systemAnnotation(schemaClass2.system)] : [],
+    ...schemaClass2.system ? [systemAnnotation2(schemaClass2.system)] : [],
     ...relationsAnnotations(context, schemaClass2)
   ];
   const modifier = schemaClass2.declarationModifier === "abstract" ? "abstract " : "";
@@ -45377,7 +45521,7 @@ function emitMember(context, member, enclosingClassId) {
     ] : [],
     ...memberSettings(context, member),
     ...listAnnotations(member),
-    ...member.system ? [systemAnnotation(member.system)] : []
+    ...member.system ? [systemAnnotation2(member.system)] : []
   ];
   const prefix = memberModifier3(member);
   if (member.kind === "computed") {
@@ -46177,7 +46321,7 @@ function genericName(context, idValue) {
   }
   throw new Error(`Unknown generic parameter ${quote(idValue)}.`);
 }
-function systemAnnotation(system) {
+function systemAnnotation2(system) {
   const args = [
     `kind: .${enumCase(system.kind)}`,
     ...system.worldKind ? [`worldKind: .${enumCase(system.worldKind)}`] : []

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@neocompose/cli",
-  "version": "0.19.2",
+  "version": "0.19.3",
   "description": "Neo Compose native project-source CLI with bidirectional sync.",
   "license": "MIT",
   "type": "module",