@neo4j-nvl/interaction-handlers 0.3.4-b33c5deb → 0.3.4-e379812f

package/lib/__tests__/click-interaction.test.js

@@ -10,7 +10,7 @@ describe('ClickInteraction', () => {
         myNVL = new NVL(document.createElement('div'), [
             { id: '0', x: 100, y: 100 },
             { id: '1', x: 200, y: 200 }
-        ], [{ id: '10', from: '0', to: '1' }], { disableWebGL: true, initialZoom: 1, layout: 'free' });
+        ], [{ id: '10', from: '0', to: '1' }], { disableWebGL: true, initialZoom: 1, layout: 'free', renderer: 'webgl' });
         clickInteraction = new ClickInteraction(myNVL, { selectOnClick: true });
     });
     afterEach(() => {

package/lib/__tests__/hover-interaction.test.js

@@ -11,7 +11,7 @@ describe('HoverInteraction', () => {
         myNVL = new NVL(document.createElement('div'), [
             { id: '0', x: 100, y: 100 },
             { id: '1', x: 200, y: 200 }
-        ], [{ id: '10', from: '0', to: '1' }], { disableWebGL: true, initialZoom: 1 });
+        ], [{ id: '10', from: '0', to: '1' }], { disableWebGL: true, initialZoom: 1, renderer: 'webgl' });
         hoverInteraction = new HoverInteraction(myNVL, { drawShadowOnHover: true });
         hoverInteraction.updateCallback('onHover', callbackMock);
     });

package/lib/__tests__/lasso-interaction.test.js

@@ -103,7 +103,14 @@ describe('LassoInteraction', () => {
             [390, 10],
             [500, 100]
         ]);
-        expect(res2).toBeFalsy();
+        expect(res2).toBeTruthy();
+        const res3 = checkIntersection([
+            [50, 10],
+            [10, 10],
+            [10, 50],
+            [50, 50]
+        ]);
+        expect(res3).toBeFalsy();
     });
     test('test for point inside polygon utility function', () => {
         const res1 = checkPointInside(10, 10, [

package/lib/interaction-handlers/lasso-interaction.js

@@ -24,11 +24,13 @@ export const checkLinesCrossing = (p1, p2, p3, p4) => {
  */
 export const checkIntersection = (polygon) => {
     for (let i = 0; i < polygon.length - 1; i++) {
-        for (let j = i + 2; j < polygon.length - 1; j++) {
+        for (let j = i + 2; j < polygon.length; j++) {
             const line1p1 = polygon[i] ?? [0, 0];
             const line1p2 = polygon[i + 1] ?? [0, 0];
             const line2p1 = polygon[j] ?? [0, 0];
-            const line2p2 = polygon[j + 1] ?? [0, 0];
+            // Handle segment from first to last point
+            const jNext = j < polygon.length - 1 ? j + 1 : 0;
+            const line2p2 = polygon[jNext] ?? [0, 0];
             if (checkLinesCrossing(line1p1, line1p2, line2p1, line2p2)) {
                 return true;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@neo4j-nvl/interaction-handlers",
-  "version": "0.3.4-b33c5deb",
+  "version": "0.3.4-e379812f",
   "license": "SEE LICENSE IN 'LICENSE.txt'",
   "homepage": "https://neo4j.com/docs/nvl/current/",
   "description": "Interaction handlers for the Neo4j Visualization Library",
@@ -19,15 +19,15 @@
     "lib"
   ],
   "scripts": {
-    "build": "tsc",
-    "watch": "tsc -w",
-    "test": "jest",
+    "build": "yarn global:tsc",
+    "watch": "yarn global:tsc -w",
+    "test": "yarn global:jest",
     "prepack": "cp ../../LICENSE.txt ./",
     "postpack": "rm LICENSE.txt",
-    "eslint": "eslint ./src/"
+    "eslint": "yarn global:eslint ./src/"
   },
   "dependencies": {
-    "@neo4j-nvl/base": "0.3.4-b33c5deb",
+    "@neo4j-nvl/base": "0.3.4-e379812f",
     "concaveman": "^1.2.1",
     "lodash": "4.17.21"
   },
@@ -35,15 +35,7 @@
     "@testing-library/jest-dom": "^5.16.5",
     "@testing-library/react": "^13.4.0",
     "@types/concaveman": "1.1.6",
-    "@types/lodash": "4.14.202",
-    "eslint": "8.38.0",
-    "jest": "^29.7.0",
-    "typescript": "^5.4.5"
-  },
-  "peerDependencies": {
-    "eslint": "*",
-    "jest": "*",
-    "typescript": "*"
+    "@types/lodash": "4.14.202"
   },
   "stableVersion": "0.3.4"
 }