@needle-tools/three 0.185.1 → 0.185.2-alpha.1

package/examples/jsm/exporters/GLTFExporter.js

@@ -1578,7 +1578,7 @@ class GLTFWriter {
 
 		const beforeWriteArgs = { keep: true, newTexture: null };
 	
-		this._invokeAll( function ( ext ) {
+		await this._invokeAllAsync( function ( ext ) {
 
 			ext.beforeWriteTexture && ext.beforeWriteTexture( map, beforeWriteArgs );
 
@@ -1848,7 +1848,7 @@ class GLTFWriter {
 
 		const beforeWriteArgs = { keep: true }
 
-		this._invokeAll( function ( ext ) {
+		await this._invokeAllAsync( function ( ext ) {
 
 			ext.beforeWriteMesh && ext.beforeWriteMesh( mesh, beforeWriteArgs );
 
@@ -2472,7 +2472,7 @@ class GLTFWriter {
 
 		const beforeWriteArgs = { keep: true }
 
-		this._invokeAll( function ( ext ) {
+		await this._invokeAllAsync( function ( ext ) {
 
 			ext.beforeWriteNode && ext.beforeWriteNode( object, beforeWriteArgs );
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/three",
-  "version": "0.185.1",
+  "version": "0.185.2-alpha.1",
   "description": "JavaScript 3D library",
   "type": "module",
   "main": "./build/three.cjs",

package/src/constants.js

@@ -1,4 +1,4 @@
-export const REVISION = '185.1';
+export const REVISION = '185.2-alpha';
 
 /**
  * Represents mouse buttons and interaction types in context of controls.

package/src/renderers/webgl/WebGLUniforms.js

@@ -806,12 +806,31 @@ function setValueV4uiArray( gl, v ) {
 
 // Array of textures (2D / 3D / Cube / 2DArray)
 
+const _warnedEmptySamplerArray = new Set();
+
 function setValueT1Array( gl, v, textures ) {
 
 	const cache = this.cache;
 
 	const n = v.length;
 
+	// An empty sampler array (`sampler2D x[0]`) has nothing to bind, and Chrome throws
+	// "WebGL: INVALID_VALUE: uniform1iv: no array" on `gl.uniform1iv([])` — every frame.
+	// Skip the upload (a genuine no-op) and warn once per uniform so the source of the
+	// empty array can be tracked down. Seen with empty shadow sampler arrays (ContactShadows).
+	if ( n === 0 ) {
+
+		if ( ! _warnedEmptySamplerArray.has( this.id ) ) {
+
+			_warnedEmptySamplerArray.add( this.id );
+			console.warn( `THREE.WebGLUniforms: skipping empty sampler array uniform '${ this.id }' (nothing to bind).` );
+
+		}
+
+		return;
+
+	}
+
 	const units = allocTexUnits( textures, n );
 
 	if ( ! arraysEqual( cache, units ) ) {