@needle-tools/three 0.146.2 → 0.146.4

package/build/three.module.js

@@ -44961,7 +44961,7 @@ class PropertyBinding {
 		this.path = path;
 		this.parsedPath = parsedPath || PropertyBinding.parseTrackName( path );
 
-		this.node = PropertyBinding.findNode( rootNode, this.parsedPath.nodeName ) || rootNode;
+		this.node = PropertyBinding.findNode( rootNode, this.parsedPath.nodeName );
 
 		this.rootNode = rootNode;
 
@@ -45277,7 +45277,7 @@ class PropertyBinding {
 
 		if ( ! targetObject ) {
 
-			targetObject = PropertyBinding.findNode( this.rootNode, parsedPath.nodeName ) || this.rootNode;
+			targetObject = PropertyBinding.findNode( this.rootNode, parsedPath.nodeName );
 
 			this.node = targetObject;
 

package/examples/jsm/controls/OrbitControls.js

@@ -836,7 +836,8 @@ class OrbitControls extends EventDispatcher {
 
 			if ( pointers.length === 0 ) {
 
-				scope.domElement.setPointerCapture( event.pointerId );
+				// this causes pointer events to be captured
+				// scope.domElement.setPointerCapture( event.pointerId );
 
 				scope.domElement.addEventListener( 'pointermove', onPointerMove );
 				scope.domElement.addEventListener( 'pointerup', onPointerUp );
@@ -881,7 +882,7 @@ class OrbitControls extends EventDispatcher {
 
 		    if ( pointers.length === 0 ) {
 
-		        scope.domElement.releasePointerCapture( event.pointerId );
+		        // scope.domElement.releasePointerCapture( event.pointerId );
 
 		        scope.domElement.removeEventListener( 'pointermove', onPointerMove );
 		        scope.domElement.removeEventListener( 'pointerup', onPointerUp );

package/examples/jsm/loaders/GLTFLoader.js

@@ -154,7 +154,7 @@ class GLTFLoader extends Loader {
 			return new GLTFMeshGpuInstancing( parser );
 
 		} );
-		
+
 		this.register( function ( parser ) {
 
 			return new GLTFAnimationPointerExtension( parser );
@@ -601,7 +601,7 @@ class GLTFLightsExtension {
 
 	}
 
-	getDependency( type, index ) {	
+	getDependency( type, index ) {
 
 		if ( type !== 'light' ) return;
 
@@ -904,16 +904,17 @@ class GLTFAnimationPointerExtension {
 						const foundNode = node.getObjectByName( val );
 						if ( foundNode )
 							currentTarget = foundNode;
+
 					}
 
 				}
 
 				if ( ! currentTarget ) {
 
-					const originalFindResult = find ( node, sections[ 2 ] );
+					const originalFindResult = find( node, sections[ 2 ] );
 
 					if ( ! originalFindResult )
-						console.error("not found", path, node, node.name, sections);
+						console.warn( EXTENSIONS.KHR_ANIMATION_POINTER + ': Property binding not found', path, node, node.name, sections );
 
 					return originalFindResult;
 
@@ -1268,7 +1269,7 @@ class GLTFAnimationPointerExtension {
 
 		// convert fov values from radians to degrees
 		if ( animationPointerPropertyPath.endsWith( '.fov' ) ) {
-			
+
 			outputArray = outputArray.map( value => value / Math.PI * 180 );
 
 		}
@@ -2869,7 +2870,7 @@ class GLTFParser {
 
 		// Use an ImageBitmapLoader if imageBitmaps are supported. Moves much of the
 		// expensive work of uploading a texture to the GPU off the main thread.
-		
+
 		let isSafari = false;
 		let isFirefox = false;
 		let firefoxVersion = - 1;
@@ -4248,8 +4249,9 @@ class GLTFParser {
 		const pendingOutputAccessors = [];
 		const pendingSamplers = [];
 		const pendingTargets = [];
-
-		for ( let i = 0, il = animationDef.channels.length; i < il; i ++ ) {
+		let i = 0;
+		let il = animationDef.channels.length;
+		for ( i = 0, il = animationDef.channels.length; i < il; i ++ ) {
 
 			const channel = animationDef.channels[ i ];
 			const sampler = animationDef.samplers[ channel.sampler ];
@@ -4289,7 +4291,7 @@ class GLTFParser {
 
 			const tracks = [];
 
-			for ( let i = 0, il = nodes.length; i < il; i ++ ) {
+			for ( i = 0, il = nodes.length; i < il; i ++ ) {
 
 				const node = nodes[ i ];
 				const inputAccessor = inputAccessors[ i ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/three",
-  "version": "0.146.2",
+  "version": "0.146.4",
   "description": "JavaScript 3D library",
   "type": "module",
   "main": "./build/three.js",

package/src/animation/PropertyBinding.js

@@ -107,7 +107,7 @@ class PropertyBinding {
 		this.path = path;
 		this.parsedPath = parsedPath || PropertyBinding.parseTrackName( path );
 
-		this.node = PropertyBinding.findNode( rootNode, this.parsedPath.nodeName ) || rootNode;
+		this.node = PropertyBinding.findNode( rootNode, this.parsedPath.nodeName );
 
 		this.rootNode = rootNode;
 
@@ -423,7 +423,7 @@ class PropertyBinding {
 
 		if ( ! targetObject ) {
 
-			targetObject = PropertyBinding.findNode( this.rootNode, parsedPath.nodeName ) || this.rootNode;
+			targetObject = PropertyBinding.findNode( this.rootNode, parsedPath.nodeName );
 
 			this.node = targetObject;