@needle-tools/materialx 1.3.1 → 1.3.3-next.dae2798

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.3.2] - 2025-08-12
+- Fix: Error when MaterialX extension is not present
+
 ## [1.3.0] - 2025-08-12
 - Change: Refactor extension to use a documents array instead of a single document, backwards compatibility is maintained
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/materialx",
-  "version": "1.3.1",
+  "version": "1.3.3-next.dae2798",
   "type": "module",
   "main": "index.js",
   "types": "index.d.ts",
@@ -56,4 +56,4 @@
     "mtlx",
     "rendering"
   ]
-}
+}

package/src/loader/loader.three.js

@@ -36,6 +36,9 @@ export class MaterialXLoader {
      */
     get materialX_root_data() {
         const ext = this.parser.json.extensions?.[this.name];
+        if (!ext) {
+            return null;
+        }
         let result = null;
         if ("documents" in ext && Array.isArray(ext.documents))
             result = ext.documents;
@@ -196,22 +199,22 @@ async function load(mtlx) {
 
 /**
  * @param {string} mtlx
- * @param {string} materialNodeName
+ * @param {string | number} materialNodeNameOrIndex
  * @param {import('../materialx.helper.js').Callbacks} loaders
  * @param {MaterialXLoaderOptions} [options]
  * @param {import('../materialx.js').MaterialXContext} [context]
  * @returns {Promise<Material>}
  */
-export async function createMaterialXMaterial(mtlx, materialNodeName, loaders, options, context) {
+export async function createMaterialXMaterial(mtlx, materialNodeNameOrIndex, loaders, options, context) {
     try {
-        if (debug) console.log(`Creating MaterialX material: ${materialNodeName}`);
+        if (debug) console.log(`Creating MaterialX material: ${materialNodeNameOrIndex}`);
 
         const doc = await load(mtlx);
 
         if (!state.materialXModule || !state.materialXGenerator || !state.materialXGenContext) {
             console.warn("[MaterialX] WASM module not ready, returning fallback material");
             const fallbackMaterial = new MeshStandardMaterial();
-            fallbackMaterial.name = `MaterialX_Fallback_${materialNodeName}`;
+            fallbackMaterial.name = `MaterialX_Fallback_${materialNodeNameOrIndex}`;
             return fallbackMaterial;
         }
 
@@ -233,8 +236,8 @@ export async function createMaterialXMaterial(mtlx, materialNodeName, loaders, o
                 if (debug) console.log(`[MaterialX] Scan material[${i}]: ${name}`);
 
                 // Find the matching material
-                if (materialNodes.length === 1 || name == materialNodeName) {
-                    materialNodeName = name;
+                if (materialNodes.length === 1 || name == materialNodeNameOrIndex || i === materialNodeNameOrIndex) {
+                    materialNodeNameOrIndex = name;
                     renderableElement = materialNode;
                     foundRenderable = true;
                     if (debug) console.log(`[MaterialX] Use material node: '${name}'`);
@@ -291,10 +294,17 @@ export async function createMaterialXMaterial(mtlx, materialNodeName, loaders, o
         */
 
         if (!renderableElement) {
-            console.warn(`[MaterialX] No renderable element found in MaterialX document (${materialNodeName})`);
+            console.warn(`[MaterialX] No renderable element found in MaterialX document (${materialNodeNameOrIndex}) → Please provide a name or index. Options: ${materialNodes.map(n => n.getNamePath()).join(", ")}`);
+            const fallbackMaterial = new MeshStandardMaterial();
+            fallbackMaterial.color.set(0xff00ff);
+            fallbackMaterial.name = `MaterialX_NoRenderable_${materialNodeNameOrIndex}`;
+            return fallbackMaterial;
+        }
+        else if(typeof materialNodeNameOrIndex === "number") {
+            console.warn(`[MaterialX] Material node not found by index (${materialNodeNameOrIndex}), using first renderable element: ${renderableElement.getNamePath()}`);
             const fallbackMaterial = new MeshStandardMaterial();
             fallbackMaterial.color.set(0xff00ff);
-            fallbackMaterial.name = `MaterialX_NoRenderable_${materialNodeName}`;
+            fallbackMaterial.name = `MaterialX_NodeNotFound_${materialNodeNameOrIndex}`;
             return fallbackMaterial;
         }
 
@@ -311,7 +321,7 @@ export async function createMaterialXMaterial(mtlx, materialNodeName, loaders, o
         const shader = state.materialXGenerator.generate(elementName, renderableElement, state.materialXGenContext);
 
         const shaderMaterial = new MaterialXMaterial({
-            name: materialNodeName,
+            name: materialNodeNameOrIndex,
             shaderName: null, //shaderInfo?.originalName || shaderInfo?.name || null,
             shader,
             context: context || {},
@@ -328,11 +338,11 @@ export async function createMaterialXMaterial(mtlx, materialNodeName, loaders, o
 
     } catch (error) {
         // This is a wasm error (an int) that we need to resolve
-        console.error(`[MaterialX] Error creating MaterialX material (${materialNodeName}):`, error);
+        console.error(`[MaterialX] Error creating MaterialX material (${materialNodeNameOrIndex}):`, error);
         // Return a fallback material with stored MaterialX data
         const fallbackMaterial = new MeshStandardMaterial();
         fallbackMaterial.color.set(0xff00ff);
-        fallbackMaterial.name = `MaterialX_Error_${materialNodeName}`;
+        fallbackMaterial.name = `MaterialX_Error_${materialNodeNameOrIndex}`;
         return fallbackMaterial;
     }
 }