@needle-tools/materialx 1.1.0 → 1.1.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/materialx",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "type": "module",
   "main": "index.ts",
   "exports": {

package/src/loader/loader.three.ts

@@ -239,13 +239,16 @@ export class MaterialXLoader implements GLTFLoaderPlugin {
             const elementName = (renderableElement as any).getNamePath ? (renderableElement as any).getNamePath() : (renderableElement as any).getName();
 
             const shader = state.materialXGenerator.generate(elementName, renderableElement, state.materialXGenContext);
+
             const shaderMaterial = new MaterialXMaterial({
                 name: material_extension.name,
                 shader,
-                transparent: isTransparent,
-                side: material_def.doubleSided ? DoubleSide : FrontSide,
                 context: this.context,
-                precision: this.options.parameters?.precision,
+                parameters: {
+                    transparent: isTransparent,
+                    side: material_def.doubleSided ? DoubleSide : FrontSide,
+                    ...this.options.parameters,
+                },
                 loaders: {
                     cacheKey: this.options.cacheKey || "",
                     getTexture: async url => {

package/src/materialx.helper.ts

@@ -466,12 +466,57 @@ export function getUniformValues(shaderStage: MaterialX.ShaderStage, loaders: Lo
             for (let i = 0; i < uniforms.size(); ++i) {
                 const variable = uniforms.get(i);
                 const value = variable.getValue()?.getData();
-                const name = variable.getVariable();
-                if (debug) console.log("Adding uniform", { path: variable.getPath(), name: name, value: value, type: variable.getType().getName() });
-                threeUniforms[name] = toThreeUniform(uniforms, variable.getType().getName(), value, name, loaders, searchPath);
+                const uniformName = variable.getVariable();
+                const type = variable.getType().getName();
+                if (debug) console.log("Adding uniform", { path: variable.getPath(), name: uniformName, value: value, type: type });
+                threeUniforms[uniformName] = toThreeUniform(uniforms, type, value, uniformName, loaders, searchPath);
             }
         }
     }
 
     return threeUniforms;
 }
+
+export function generateMaterialPropertiesForUniforms(material: THREE.ShaderMaterial, shaderStage: MaterialX.ShaderStage) {
+
+    const uniformBlocks = shaderStage.getUniformBlocks()
+    for (const [blockName, uniforms] of Object.entries(uniformBlocks)) {
+        // Seems struct uniforms (like in LightData) end up here as well, we should filter those out.
+        if (blockName === "LightData") continue;
+
+        if (!uniforms.empty()) {
+            for (let i = 0; i < uniforms.size(); ++i) {
+                const variable = uniforms.get(i);
+                const uniformName = variable.getVariable();
+                let key = variable.getPath().split('/').pop();
+                switch (key) {
+                    case "_Color":
+                        key = "color";
+                        break;
+                    case "_Roughness":
+                        key = "roughness";
+                        break;
+                    case "_Metallic":
+                        key = "metalness";
+                        break;
+                }
+                if (key) {
+                    Object.defineProperty(material, key, {
+                        get: function () {
+                            return this.uniforms?.[uniformName].value
+                        },
+                        set: function (v) {
+                            const uniforms = this.uniforms;
+                            if (!uniforms || !uniforms[uniformName]) {
+                                console.warn(`[MaterialX] Uniform ${uniformName} not found in ${this.name} uniforms`);
+                                return;
+                            }
+                            this.uniforms[uniformName].value = v;
+                            this.uniformsNeedUpdate = true;
+                        }
+                    });
+                }
+            }
+        }
+    }
+}

package/src/materialx.material.ts

@@ -1,7 +1,8 @@
 import { BufferGeometry, Camera, FrontSide, GLSL3, Group, IUniform, MaterialParameters, Matrix3, Matrix4, Object3D, Scene, ShaderMaterial, Texture, Vector3, WebGLRenderer } from "three";
 import { debug, getFrame, getTime } from "./utils.js";
 import { MaterialXContext, MaterialXEnvironment } from "./materialx.js";
-import { getUniformValues, Loaders } from "./materialx.helper.js";
+import { generateMaterialPropertiesForUniforms, getUniformValues, Loaders } from "./materialx.helper.js";
+import { cloneUniforms, cloneUniformsGroups } from "three/src/renderers/shaders/UniformsUtils.js";
 
 
 // Add helper matrices for uniform updates (similar to MaterialX example)
@@ -14,9 +15,7 @@ declare type MaterialXMaterialInitParameters = {
     loaders: Loaders,
     context: MaterialXContext,
     // Optional parameters
-    transparent?: boolean,
-    side?: MaterialParameters['side'],
-    precision?: MaterialParameters['precision'],
+    parameters?: MaterialParameters,
 }
 
 type Uniforms = Record<string, IUniform & { needsUpdate?: boolean }>;
@@ -27,10 +26,19 @@ export class MaterialXMaterial extends ShaderMaterial {
     copy(source: MaterialXMaterial): this {
         super.copy(source);
         this._context = source._context;
+        this._shader = source._shader;
+        this.uniforms = cloneUniforms(source.uniforms) as Uniforms;
+        this.uniformsGroups = cloneUniformsGroups(source.uniformsGroups);
+        this.envMapIntensity = source.envMapIntensity;
+        this.envMap = source.envMap;
+        generateMaterialPropertiesForUniforms(this, this._shader.getStage('pixel'));
+        generateMaterialPropertiesForUniforms(this, this._shader.getStage('vertex'));
+        this.needsUpdate = true;
         return this;
     }
 
     private _context: MaterialXContext | null = null;
+    private _shader: any;
 
     constructor(init?: MaterialXMaterialInitParameters) {
 
@@ -63,7 +71,7 @@ export class MaterialXMaterial extends ShaderMaterial {
         vertexShader = vertexShader.replace(/\bi_color_0\b/g, 'color');
 
         // Patch fragmentShader
-        const precision = init.precision || "highp" as Precision;
+        const precision = init.parameters?.precision || "highp" as Precision;
         fragmentShader = fragmentShader.replace(/precision mediump float;/g, `precision ${precision} float;`);
         fragmentShader = fragmentShader.replace(/#define M_FLOAT_EPS 1e-8/g, precision === "highp" ? `#define M_FLOAT_EPS 1e-8` : `#define M_FLOAT_EPS 1e-3`);
 
@@ -124,19 +132,20 @@ export class MaterialXMaterial extends ShaderMaterial {
         if (hasColor) defines['USE_COLOR'] = '';
 
         const searchPath = ""; // Could be derived from the asset path if needed
-        const isTransparent = init.transparent ?? false;
+        const isTransparent = init.parameters?.transparent ?? false;
         super({
             name: init.name,
             uniforms: {},
             vertexShader: vertexShader,
             fragmentShader: fragmentShader,
             glslVersion: GLSL3,
-            transparent: isTransparent,
-            side: init.side ? init.side : FrontSide,
             depthTest: true,
             depthWrite: !isTransparent,
             defines: defines,
+            ...init.parameters, // Spread any additional parameters passed to the material
         });
+        this._context = init.context;
+        this._shader = init.shader;
 
         Object.assign(this.uniforms, {
             ...getUniformValues(init.shader.getStage('vertex'), init.loaders, searchPath),
@@ -158,7 +167,9 @@ export class MaterialXMaterial extends ShaderMaterial {
             u_lightData: { value: [], needsUpdate: false }, // Array of light data. We need to set needsUpdate to false until we actually update it
         });
 
-        this._context = init.context;
+        generateMaterialPropertiesForUniforms(this, init.shader.getStage('pixel'));
+        generateMaterialPropertiesForUniforms(this, init.shader.getStage('vertex'));
+
 
         if (debug) {
             // Get lighting and environment data from MaterialX environment
@@ -216,7 +227,7 @@ export class MaterialXMaterial extends ShaderMaterial {
             if (frame === undefined) frame = getFrame();
             uniforms.u_frame.value = frame;
         }
-        
+
         // Update light uniforms
         this.updateEnvironmentUniforms(environment);