@needle-tools/gltf-build-pipeline 2.9.0 → 2.9.1

package/dist/transforms/needle_texture_transform.js

@@ -117,11 +117,10 @@ async function processTexture(texture, index, document, logger, context) {
     const canRunToktx = context.noToktx !== true;
     const originalUri = texture.getURI();
     if (compressionSettings && compressionSettings.mode !== "auto") {
-        let mode = compressionSettings.mode;
         // Handle highlevel modes
-        switch (mode) {
+        switch (compressionSettings.mode) {
             case "world":
-                mode = "ETC1S";
+                compressionSettings.mode = "ETC1S";
                 break;
             case "product":
                 switch (compressionSettings.slot) {
@@ -129,12 +128,13 @@ async function processTexture(texture, index, document, logger, context) {
                     case "normalTexture":
                     case "metallicRoughnessTexture":
                     case "lightmapTexture":
-                        mode = "webp";
+                        compressionSettings.mode = "webp";
+                        compressionSettings.quality = 0.95;
                         break;
                 }
                 break;
         }
-        switch (mode) {
+        switch (compressionSettings.mode) {
             case "webp":
                 if (cached) {
                     texture.setImage(cached).setMimeType("image/webp");
@@ -164,7 +164,6 @@ async function processTexture(texture, index, document, logger, context) {
     else {
         let mimeType = "image/ktx2";
         let ktx2Format = undefined;
-        let webpOptions = {};
         const slots = listTextureSlots(texture);
         const size = texture.getSize();
         const isVRM = context.file?.toLowerCase().endsWith(".vrm");
@@ -179,6 +178,7 @@ async function processTexture(texture, index, document, logger, context) {
         //         mimetype = "image/webp";
         //     }
         // }
+        const webpOptions = {};
         if (slots.includes("lightmapTexture") || isLightmap(texture)) {
             mimeType = "image/webp";
         }
@@ -189,6 +189,7 @@ async function processTexture(texture, index, document, logger, context) {
         }
         // For product compression we automatically select webP if the texture is used in a PBR material
         // https://linear.app/needle/issue/NE-6458
+        // TODO: this should probably moved to the top and we should create a compression settings object
         else if (context.config.usecase === "product") {
             const shouldUseWebp = slots.includes("normalTexture") || slots.includes("metallicRoughnessTexture");
             if (shouldUseWebp) {

package/dist/utils/version.gen.d.ts

@@ -1 +1 @@
-export declare const version = "2.9.0";
+export declare const version = "2.9.1";

package/dist/utils/version.gen.js

@@ -1 +1 @@
-export const version = "2.9.0";
+export const version = "2.9.1";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "2.9.0",
+  "version": "2.9.1",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "dist/index.js",
   "type": "module",