@needle-tools/gltf-build-pipeline 2.7.0-alpha → 2.7.0-alpha.1

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [2.7.0-alpha.1] - 2024-01-13
+- fix: handle LOD omitting and remove deleted files from progressive transform results list
+
 ## [2.7.0-alpha] - 2024-01-13
 - add: VRM mesh simplification support
 - fix: issue where the output directory was not created if it didn't exist yet 

package/dist/transforms/needle_progressive.js

@@ -29,6 +29,19 @@ export async function make_progressive(opts) {
         if (!res)
             success = false;
     });
+    if (success) {
+        // Make sure all results exist
+        // It's possible that files were deleted while omitting LODs - we want to remove them from the results list
+        const resultsCount = opts.results.length;
+        for (let i = opts.results.length - 1; i >= 0; i--) {
+            if (!existsSync(opts.results[i])) {
+                opts.results.splice(i, 1);
+            }
+        }
+        const resultsChanged = resultsCount !== opts.results.length;
+        if (opts.debug)
+            console.log(`Progressive Transform: ${opts.results.length} files processed. ${resultsChanged ? "Some results were removed" : ""}`);
+    }
     return success;
 }
 function registerExtensions(io) {
@@ -661,7 +674,7 @@ export function make_progressive_meshes(filePath, _options, opts) {
                     if (shouldOmitLevel) {
                         logger.debug(`[${NAME}] Omitting LOD ${level} for \"${mesh.getName()}\" at \"${lodInfo.path}\"`);
                         generatedLODInfos.splice(i, 1);
-                        rmSync(fullPath);
+                        deleteFile(fullPath, opts);
                         i--;
                     }
                     else {
@@ -699,7 +712,7 @@ export function make_progressive_meshes(filePath, _options, opts) {
                 logger.info(`[${NAME}]: Flag mesh LOD ${generatedLODInfos.length} (embedded): vertex count difference below threshold (removed ${difference} vertices, ${(-diff01 * 100).toFixed(2)} %) → will remove all LODs. \"${mesh.getName()}\"`);
                 try {
                     for (const lodInfo of generatedLODInfos) {
-                        rmSync(outputDirectory + "/" + lodInfo.path);
+                        deleteFile(outputDirectory + "/" + lodInfo.path, opts);
                     }
                 }
                 catch (err) {
@@ -744,6 +757,9 @@ export function make_progressive_meshes(filePath, _options, opts) {
         }
     });
 }
+function deleteFile(filePath, _context) {
+    rmSync(filePath);
+}
 function clonePrimitiveData(prim, logger) {
     const semantics = prim.listSemantics();
     if (semantics.some(s => s.includes("JOINTS"))) {

package/dist/utils/version.gen.d.ts

@@ -1 +1 @@
-export declare const version = "2.7.0-alpha";
+export declare const version = "2.7.0-alpha.1";

package/dist/utils/version.gen.js

@@ -1 +1 @@
-export const version = "2.7.0-alpha";
+export const version = "2.7.0-alpha.1";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "2.7.0-alpha",
+  "version": "2.7.0-alpha.1",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "dist/index.js",
   "type": "module",