@needle-tools/gltf-build-pipeline 2.4.0-alpha.1 → 2.4.0-alpha.3

package/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [2.4.0-alpha.3] - 2023-08-11
+- fix: issue where files would not correctly be overriden in subdirectories when no output directory was specified 
+
+## [2.4.0-alpha.2] - 2023-06-29
+- fix: prevent joining/flattening of progressive assets
+
 ## [2.4.0-alpha.1] - 2023-06-26
 - add: heuristic for choosing mesh compression if not explictly configured
 

package/dist/cli/index.js

@@ -91,15 +91,19 @@ Each version will be compressed and written to the output directory.
             config.usecase = options.usecase.toString();
         }
     }
-    let output = args.output?.toString() || input;
     const inputIsDirectory = isDirectory(input);
-    const outputIsDirectory = isDirectory(output);
-    if (inputIsDirectory && !outputIsDirectory) {
+    let output = args.output?.toString();
+    // If the input path is a filepath and no specific output is defined we set output to the input file
+    if (!inputIsDirectory && !output) {
+        output = input;
+    }
+    const outputIsDirectory = output && isDirectory(output);
+    if (inputIsDirectory && output && !outputIsDirectory) {
         logger.error("When <input> is a directory then <output> must also be a directory");
         process.exit(ERROR_CODES.INVALID_ARGS);
     }
     // Handle the output bath being relative to the input path
-    if (path.isAbsolute(output) === false) {
+    if (output && path.isAbsolute(output) === false) {
         const base = ensureIsDirectory(input);
         output = resolve(base, output);
     }

package/dist/scripts/pack-gltf.js

@@ -90,11 +90,12 @@ export async function packGLTF(inputFile, outputFile, options) {
                 propertyTypes: ['MESH', 'MATERIAL', 'TEXTURE']
             }));
         }
-        await document.transform(...transforms);
         const isVRM = inputFile.toLowerCase().endsWith(".vrm");
-        if (!isVRM && config?.usecase === "product") {
-            await document.transform(flatten(), join({ keepNamed: false }));
+        if (!isVRM && !isProgressiveAsset && config?.usecase === "product") {
+            transforms.push(flatten());
+            transforms.push(join({ keepNamed: false }));
         }
+        await document.transform(...transforms);
         if (!outputFile)
             outputFile = inputFile;
         else {

package/dist/utils/fileutils.js

@@ -153,6 +153,9 @@ export function replaceExtension(filepath, newExtension) {
     return parts.join(".") + "." + newExtension;
 }
 export function isDirectory(path) {
+    if (!path) {
+        return false;
+    }
     if (existsSync(path)) {
         return statSync(path).isDirectory();
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "2.4.0-alpha.1",
+  "version": "2.4.0-alpha.3",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "dist/index.js",
   "type": "module",