@needle-tools/gltf-build-pipeline 1.6.0-alpha.5 → 1.6.0-alpha.6

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.6.0-alpha.6] - 2023-05-30
+- fix: npx cli command return wrong error due to `packGLTF` not returning a booelan
+
 ## [1.6.0-alpha.5] - 2023-05-28
 - fix: determine build pipeline version
 - change: throw error and exit process if packing or transform fails

package/dist/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/gltf-build-pipeline",
-    "version": "1.6.0-alpha.5",
+    "version": "1.6.0-alpha.6",
     "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
     "main": "index.mjs",
     "type": "module",
@@ -51,7 +51,8 @@
     },
     "devDependencies": {
         "@types/node": "^18.7.23",
-        "npm-watch": "^0.11.0",
+        "nodemon": "^3.1.2",
+        "npm-watch": "^0.13.0",
         "typescript": "^4.9.5"
     },
     "author": {

package/dist/src/cli/index.js

@@ -87,7 +87,7 @@ Compress a single glTF file. The input file is compressed and written to the out
             logger: logger,
             file_stats: file_stats,
         });
-        if (!res) {
+        if (res === false) {
             process.exit(ERROR_CODES.PACKING_FAILED);
         }
     });
@@ -155,12 +155,12 @@ Each version will be compressed and written to the output directory.
         };
         for (const res of progressive_results) {
             logger.info("> Compress " + res);
-            if (!await packGLTF(res, res, opts)) {
+            if (await packGLTF(res, res, opts) === false) {
                 process.exit(ERROR_CODES.PACKING_FAILED);
             }
         }
         logger.info("> Compress " + file);
-        if (!await packGLTF(file, file, opts)) {
+        if (await packGLTF(file, file, opts) === false) {
             process.exit(ERROR_CODES.PACKING_FAILED);
         }
     });

package/dist/src/scripts/pack-gltf.js

@@ -22,7 +22,7 @@ export async function packGLTF(inputFile, outputFile, options) {
         return;
     }
     if (debug && inputFile.includes(".debug.")) {
-        return;
+        return true;
     }
     // check if it's in the cache. 
     // We only need to check mesh LOD files because image LODs are cache via our toktx transform
@@ -36,12 +36,12 @@ export async function packGLTF(inputFile, outputFile, options) {
         if (cached) {
             logger.info(`→ Loaded compressed file from cache: \"${path.basename(inputFile)}\"`);
             writeFileSync(inputFile, cached);
-            return;
+            return true;
         }
     }
     if (packedFiles) {
         if (packedFiles.has(inputFile))
-            return;
+            return true;
         packedFiles.add(inputFile);
     }
     try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.6.0-alpha.5",
+  "version": "1.6.0-alpha.6",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",
@@ -51,7 +51,8 @@
   },
   "devDependencies": {
     "@types/node": "^18.7.23",
-    "npm-watch": "^0.11.0",
+    "nodemon": "^3.1.2",
+    "npm-watch": "^0.13.0",
     "typescript": "^4.9.5"
   },
   "author": {
@@ -63,4 +64,4 @@
     "type": "git",
     "url": "git+https://github.com/needle-tools/needle-gltf-extensions.git"
   }
-}
+}