@needle-tools/gltf-build-pipeline 1.5.0-alpha.4 → 1.5.0-alpha.5

package/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.5.0-alpha.5] - 2023-05-04
+- fix: NEEDLE_opaque should handle if VRM texture index is negative
+- change: exit with code 1 if any file packing fails
+
 ## [1.5.0-alpha.4] - 2023-05-03
 - fix: issue in NEEDLE_opaque resolving of VRM textures, also resolve `meta.texture`
 - fix: VRMs now compress meshes with mesh-opt if nothing is specified

package/dist/extensions/NEEDLE_opaque/NEEDLE_opaque.js

@@ -622,7 +622,16 @@ class JsonPointerHandler {
                 // key texture is matching for example for VRM meta/texture (AvatarSample_A) and the regex is also for handling VRM material properties
                 else if (key === "texture" || fullPath.match(/materialProperties\/\d+?\/textureProperties/g)) {
                     const index = value;
+                    // e.g. in meta.texture for VRM avatars it seems like we can have negative values
+                    if (index < 0) {
+                        console.warn(`WARN: texture index is negative ${index} at ${fullPath}`);
+                        return;
+                    }
                     const definition = context.jsonDoc.json.textures[index];
+                    if (!definition) {
+                        console.warn(`WARN: texture definition with index ${index} not found or does not exist. Set in \"${fullPath}\"`);
+                        return;
+                    }
                     const imageIndex = findSource(definition);
                     if (this.debug)
                         console.log("Texture index", index, imageIndex, context.jsonDoc.json.textures.length, "Textures:" + context.textures.length);

package/pack-gltf.mjs

@@ -169,18 +169,20 @@ async function packFile(file) {
 
 let startTime = Date.now();
 const inputArgs = args.slice(2);
+let failed = false;
 foreachGLTF(inputArgs, async (file) => {
-    await packFile(file);
+    const res = await packFile(file);
+    if (!res) failed = true;
 }).then(async () => {
     const duration = Date.now() - startTime;
     const durationInMinutes = duration / 1000 / 60;
     if (allowCaching) {
-        // if the user's cache directory has more than 25GB free space, we allow a cache of 2 GB - otherwise 1 GB
-        // const freeSpaceInMB = (await getCacheAvailableSpaceOnDisc().catch(() => 0)) / 1024 / 1024;
-        // const maxCacheSize = freeSpaceInMB > 25000 ? 2000 : 1000;
         limitCacheSize();
     }
     console.log(`[Needle Build Pipeline] v${getVersion()} — Finished packing ${totalFilesProcessed} files in ${durationInMinutes.toFixed(1)} minutes; total size ${totalFileSizeInMBBefore.toFixed(1)} MB → ${totalFileSizeInMB.toFixed(1)} MB, total GPU memory: ${totalGPUMemoryInMB.toFixed(1)} MB`);
+    if (failed) {
+        process.exit(1);
+    }
 }).catch(err => {
     console.error("ERR: packing failed: " + err.message);
     if (debug) throw err;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.5.0-alpha.4",
+  "version": "1.5.0-alpha.5",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",