@needle-tools/gltf-build-pipeline 1.4.5 → 1.4.6

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.4.6] - 2023-04-10
+- fix: NEEDLE_progressive meshes do not revert primitive data for skinned meshes anymore. See NE-4596
+
 ## [1.4.5] - 2023-04-05
 - fix: generating mesh and texture LOD for glbs without `NEEDLE_` extension
 - fix: guid generation for progressive meshes when no `NEEDLE_` extension is present

package/dist/transforms/needle_progressive.js

@@ -474,11 +474,13 @@ export function make_progressive_meshes(filePath, _options, opts) {
             let maxDensity = 0;
             let primitiveIndex = 0;
             const lodLevelInFile = generatedLODInfos.length;
-            const clonedData = new Array();
+            const clonedData = { primitives: [], weights: [...mesh.getWeights()] };
             for (const prim of mesh.listPrimitives()) {
                 const data = clonePrimitiveData(prim);
-                clonedData.push(data);
-                console.log(`[${NAME}] Simplify mesh[${index}] primitive[${primitiveIndex}] with ${data.indices.length / 3} triangles`);
+                if (data != null) {
+                    clonedData.primitives.push(data);
+                }
+                console.log(`[${NAME}] Simplify mesh[${index}] primitive[${primitiveIndex}] (embedded)`);
                 const lastLod = LODS[lodLevelInFile];
                 // TODO: this should be run after simplification but then we need to change the runtime to use the LOD 0 density
                 const density = calculateMeshDensity(prim);
@@ -496,7 +498,7 @@ export function make_progressive_meshes(filePath, _options, opts) {
             }
             else if (difference < 32 || diff01 <= 0.05) {
                 // the lowest LOD has the same vertex count as the original mesh → we don't need to write the extension and can also delete previously generated LODs
-                console.log(`[${NAME}]: Flag mesh LOD ${generatedLODInfos.length}: vertex count difference below threshold (removed ${difference} vertices, ${(-diff01 * 100).toFixed(2)} %) → will remove LODs. \"${mesh.getName()}\"`);
+                console.log(`[${NAME}]: Flag mesh LOD ${generatedLODInfos.length} (embedded): vertex count difference below threshold (removed ${difference} vertices, ${(-diff01 * 100).toFixed(2)} %) → will remove LOD. \"${mesh.getName()}\"`);
                 try {
                     for (const lodInfo of generatedLODInfos) {
                         rmSync(outputDirectory + "/" + lodInfo.path);
@@ -507,9 +509,12 @@ export function make_progressive_meshes(filePath, _options, opts) {
                 }
                 // reset data (simplify might have changed the mesh data that we cloned before)
                 const primitives = mesh.listPrimitives();
-                if (clonedData.length == primitives.length) {
+                if (clonedData.primitives.length == primitives.length) {
+                    if (clonedData.weights?.length > 0) {
+                        mesh.setWeights(clonedData.weights);
+                    }
                     for (let i = 0; i < primitives.length; i++) {
-                        setPrimitiveData(primitives[i], clonedData[i]);
+                        setPrimitiveData(primitives[i], clonedData.primitives[i]);
                     }
                 }
                 return;
@@ -540,9 +545,14 @@ export function make_progressive_meshes(filePath, _options, opts) {
     });
 }
 function clonePrimitiveData(prim) {
+    const semantics = prim.listSemantics();
+    if (semantics.some(s => s.includes("JOINTS"))) {
+        return null;
+    }
     const indices = new Uint32Array(prim.getIndices().getArray());
     const attributes = {};
-    for (const attr of prim.listSemantics()) {
+    for (const attr of semantics) {
+        console.log(`[${NAME}] Clone attribute ${attr}`);
         const accessor = prim.getAttribute(attr);
         if (accessor) {
             attributes[attr] = new Float32Array(accessor.getArray());

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.4.5",
+  "version": "1.4.6",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",