@needle-tools/gltf-build-pipeline 1.4.1-beta → 1.4.1-beta.3

package/CHANGELOG.md

@@ -4,10 +4,15 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## [1.4.1-beta] - 2023-03-13
+## [1.4.1-beta.3] - 2023-03-14
+- fix: wait for mesh simplifier to be ready
+
+## [1.4.1-beta.2] - 2023-03-13
 - change: update gltf-transform to `^3.10.0`
 - change: progressive mesh transform does now set ratio for LODs (see [simplifier issue 661 on github](https://github.com/zeux/meshoptimizer/issues/661))
 - fix: issue where progressive meshes were not generated if a mesh was multiple times in the glTF
+- change: simplify to use ratio, fix issue where not all meshes were processed
+- change: auto LOD max error set to 0.1
 
 ## [1.4.0-beta] - 2023-03-12
 - add: progressive mesh transform to automatically generate mesh LOD levels (currently we only generate one low poly version)

package/dist/transforms/needle_mesh_transform.d.ts

@@ -1,4 +1,4 @@
 import { Transform, Document, Primitive, Mesh } from "@gltf-transform/core";
 import { SimplifyOptions, WeldOptions } from "@gltf-transform/functions";
 export declare const needle_mesh_transform: (_options: SimplifyOptions) => Transform;
-export declare function compressPrimitive(document: Document, mesh: Mesh, prim: Primitive, weldOptions: Required<WeldOptions>, meshOptions: Required<SimplifyOptions>): void;
+export declare function compressPrimitive(document: Document, mesh: Mesh, prim: Primitive, weldOptions: Required<WeldOptions>, meshOptions: Required<SimplifyOptions>): Promise<void>;

package/dist/transforms/needle_mesh_transform.js

@@ -88,10 +88,24 @@ async function simplifierTransform(document, _context, _options) {
     }
     return true;
 }
-export function compressPrimitive(document, mesh, prim, weldOptions, meshOptions) {
+export async function compressPrimitive(document, mesh, prim, weldOptions, meshOptions) {
     const logger = document.getLogger();
     logger.debug(`[${NAME}]: Welding primitive of mesh "${mesh.getName()}" → tolerance: ${weldOptions.tolerance}`);
     weldPrimitive(document, prim, weldOptions);
+    // make sure we wait for the mesh simplifier to be ready
+    if (meshOptions.simplifier && meshOptions.simplifier?.ready instanceof Promise) {
+        const res = await meshOptions.simplifier?.ready
+            .then(() => {
+            // ready!
+            return true;
+        })
+            .catch((err) => {
+            console.error(`[${NAME}]: Simplifier failed to load...\n${err}`);
+            return false;
+        });
+        if (!res)
+            return;
+    }
     logger.debug(`[${NAME}]: Simplifying primitive of mesh "${mesh.getName()}" → ratio: ${meshOptions.ratio}, error: ${meshOptions.error}, lockBorder: ${meshOptions.lockBorder}`);
     simplifyPrimitive(document, prim, meshOptions);
 }

package/dist/transforms/needle_progressive.js

@@ -305,8 +305,8 @@ export function make_progressive_meshes(filePath, _options, opts) {
         // the lowest LOD (last entry) will be saved in the original file
         const LODS = [
             { error: 0 },
-            { ratio: 0.5, error: 1 },
-            { ratio: 0.25, error: 1 },
+            { ratio: 0.5, error: .1 },
+            { ratio: 0.25, error: .1 },
         ];
         /** Map of visited GUID -> extension */
         const visited = new Map();
@@ -448,7 +448,7 @@ function createMeshLod(doc, basePath, level, mesh, guid, lodLevel) {
     newIo.write(outName, newDoc);
     return filename;
 }
-function simplifyMesh(doc, mesh, prim, lodinfo) {
+async function simplifyMesh(doc, mesh, prim, lodinfo) {
     const weldOptions = {
         ...WELD_DEFAULTS,
         overwrite: true,
@@ -460,7 +460,7 @@ function simplifyMesh(doc, mesh, prim, lodinfo) {
         simplifyOptions.error = lodinfo.error;
     if (lodinfo.ratio != undefined)
         simplifyOptions.ratio = lodinfo.ratio;
-    compressPrimitive(doc, mesh, prim, weldOptions, simplifyOptions);
+    return compressPrimitive(doc, mesh, prim, weldOptions, simplifyOptions);
 }
 function isMeshLOD(filepath) {
     return filepath.includes("mesh_lod_");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.4.1-beta",
+  "version": "1.4.1-beta.3",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",