@needle-tools/gltf-build-pipeline 1.4.1-beta.13 → 1.4.1-beta.14

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.4.1-beta.14] - 2023-04-02
+- fix: issue where discarding all LODs might result in broken mesh due to simplify having modified the original mesh
+
 ## [1.4.1-beta.13] - 2023-03-26
 - change: passthrough `NEEDLE_editor` & `NEEDLE_gltf_dependencies` extensions
 

package/dist/transforms/needle_progressive.js

@@ -331,8 +331,13 @@ export function make_progressive_meshes(filePath, _options, opts) {
         }
         /** Map of visited GUID -> extension */
         const visited = new Map();
-        const meshes = doc.getRoot().listMeshes();
+        const root = doc.getRoot();
+        const meshes = root.listMeshes();
         for (const mesh of meshes) {
+            await processMesh(mesh);
+        }
+        console.log(`[${NAME}]: Finished generating progressive meshes for \"${filename}\"`);
+        async function processMesh(mesh) {
             /** The size and vertex count of the original mesh */
             const originalMeshInformation = getMeshInformation(mesh);
             const { totalVertexCount: originalTotalVertexCount, maxVertexCount: originalMaxVertexCount } = originalMeshInformation;
@@ -340,7 +345,7 @@ export function make_progressive_meshes(filePath, _options, opts) {
             if (!settings) {
                 if (originalMaxVertexCount < 32) {
                     logger.debug(`[${NAME}] Skipping, no settings found and no primitive with more than 32 vertices. mesh[${index}] has ${originalTotalVertexCount} vertices (max: ${originalMaxVertexCount})`);
-                    continue;
+                    return;
                 }
                 else {
                     settings = {
@@ -352,12 +357,12 @@ export function make_progressive_meshes(filePath, _options, opts) {
             }
             else if (settings.generateLods === false) {
                 logger.debug(`[${NAME}] progressive mesh disabled for mesh at index ${index++}`);
-                continue;
+                return;
             }
             const progressiveExt = doc.createExtension(NEEDLE_progressive);
             if (!progressiveExt || !progressiveExt.createMesh) {
                 logger.debug(`[${NAME}] Skipping because progressive extension is not available. ${index++}`);
-                continue;
+                return;
             }
             // check if we have already produced LODs for this mesh
             let needsToGenerateLODs = true;
@@ -449,7 +454,11 @@ export function make_progressive_meshes(filePath, _options, opts) {
             let maxDensity = 0;
             let primitiveIndex = 0;
             const lodLevelInFile = generatedLODInfos.length;
+            const clonedData = new Array();
             for (const prim of mesh.listPrimitives()) {
+                const data = clonePrimitiveData(prim);
+                clonedData.push(data);
+                console.log(`[${NAME}] Simplify mesh[${index}] primitive[${primitiveIndex}] with ${data.indices.length / 3} triangles`);
                 const lastLod = LODS[lodLevelInFile];
                 // TODO: this should be run after simplification but then we need to change the runtime to use the LOD 0 density
                 const density = calculateMeshDensity(prim);
@@ -476,7 +485,14 @@ export function make_progressive_meshes(filePath, _options, opts) {
                 catch (err) {
                     logger.error(`ERR: [${NAME}] Failed to remove LOD files for \"${mesh.getName()}\"`);
                 }
-                continue;
+                // reset data (simplify might have changed the mesh data that we cloned before)
+                const primitives = mesh.listPrimitives();
+                if (clonedData.length == primitives.length) {
+                    for (let i = 0; i < primitives.length; i++) {
+                        setPrimitiveData(primitives[i], clonedData[i]);
+                    }
+                }
+                return;
             }
             if (generatedLODInfos.length > 0) {
                 const model = progressiveExt.createMesh({
@@ -501,9 +517,31 @@ export function make_progressive_meshes(filePath, _options, opts) {
                 }
             }
         }
-        console.log(`[${NAME}]: Finished generating progressive meshes for \"${filename}\"`);
     });
 }
+function clonePrimitiveData(prim) {
+    const indices = new Uint32Array(prim.getIndices().getArray());
+    const attributes = {};
+    for (const attr of prim.listSemantics()) {
+        const accessor = prim.getAttribute(attr);
+        if (accessor) {
+            attributes[attr] = new Float32Array(accessor.getArray());
+        }
+    }
+    return { indices, attributes };
+}
+function setPrimitiveData(prim, data) {
+    const indices = prim.getIndices();
+    if (indices) {
+        indices.setArray(data.indices);
+    }
+    for (const attr of prim.listSemantics()) {
+        const accessor = prim.getAttribute(attr);
+        if (accessor) {
+            accessor.setArray(data.attributes[attr]);
+        }
+    }
+}
 /**
  * @param basePath the base path to save the lod files
  * @param level: 0 = original, 1 = first lod, 2 = second lod, ...

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.4.1-beta.13",
+  "version": "1.4.1-beta.14",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",