@needle-tools/gltf-build-pipeline 1.2.2 → 1.2.3

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.2.3] - 2023-09-29
+- fix: bug in progressive texture transform where texture wasnt found
+
 ## [1.2.2] - 2023-08-14
 - remove: legacy squoosh dependency
 

package/dist/extensions/NEEDLE_compression_texture/NEEDLE_compression_texture.js

@@ -11,10 +11,10 @@ export class NEEDLE_compression_texture extends Extension {
         return ext;
     }
     read(context) {
-        if (!context.jsonDoc.json.textures)
-            return this;
         if (debugLog)
             console.log("READ " + EXTENSION_NAME);
+        if (!context.jsonDoc.json.textures)
+            return this;
         context.textures?.forEach((tex, _) => {
             const textureDefinition = getTextureDefinition(context, tex);
             if (textureDefinition?.extensions && textureDefinition.extensions[EXTENSION_NAME]) {

package/dist/extensions/NEEDLE_progressive_texture_settings/index.js

@@ -16,7 +16,12 @@ export class NEEDLE_progressive_texture_settings extends Extension {
                 const ext = texDef.extensions[EXTENSION_NAME];
                 const prop = new NEEDLE_progressive_texture_settings_property(this.document.getGraph(), "");
                 Object.assign(prop, ext);
-                textures[i].setExtension(EXTENSION_NAME, prop);
+                const tex = textures[i];
+                if (tex)
+                    tex.setExtension(EXTENSION_NAME, prop);
+                else {
+                    console.warn("Texture not found for texture index " + i);
+                }
             }
         }
         return this;

package/dist/transforms/needle_texture_transform.js

@@ -81,6 +81,10 @@ async function processTexture(texture, index, document, logger, context) {
         return;
     const ext = texture.getExtension(NEEDLE_compression_texture.EXTENSION_NAME);
     const compressionSettings = ext?.model;
+    // is a user has configured a texture explictly to NOT be compressed
+    // we should respect that
+    if (ext?.model?.mode === "none")
+        return;
     const key = context.useCache ? getKey(texture) : undefined;
     let cached = context.useCache && key ? tryGetFromCache(key) : undefined;
     if (cached) {

package/dist/utils/fileutils.js

@@ -37,6 +37,11 @@ export async function foreachGLTF(args, callback) {
                 }
             }
         }
+        else {
+            // if no file was found, we don't have a needle.config in the directory
+            // and we don't have any arguments, try to find it in the default dist directory
+            // await testEntry(context.baseDirectory + "/dist", callback, context);
+        }
     }
     if (context.filesFound <= 0) {
         console.log("WARN: No glTF files found. Make sure to invoke with a valid path to a glTF file or directory. This path may be relative to " + initDir);

package/pack-gltf.mjs

@@ -145,7 +145,8 @@ async function packFile(file) {
 
 
 let startTime = Date.now();
-foreachGLTF(process.argv, async (file) => {
+const inputArgs = args.slice(2);
+foreachGLTF(inputArgs, async (file) => {
     await packFile(file);
 }).then(() => {
     const duration = Date.now() - startTime;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",