@needle-tools/gltf-build-pipeline 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.2.1] - 2023-07-25
+- change: set reference to materials used by json pointers
+
 ## [1.2.0] - 2023-07-21
 - add: resolving of material json pointers
 

package/dist/extensions/NEEDLE_opaque/NEEDLE_opaque.js

@@ -561,12 +561,12 @@ class JsonPointerHandler {
                         const index = parseInt(value.substring("/materials/".length));
                         const mat = context.materials[index];
                         if (mat) {
-                            // UPDATE: I think the code below is not necessary anymore when we resolve the deduplicated material index
-                            // set a reference to the material to avoid dedup
+                            // set a reference to the material to avoid dedup or the material being removed because it MIGHT not be used by any node
+                            // BUT a component is referencing the material so we don't want it ever to be removed 
                             // see https://github.com/donmccurdy/glTF-Transform/issues/980#issuecomment-1585748202
-                            // if (ext) {
-                            //     ext.setReference(value, mat);
-                            // }
+                            if (ext) {
+                                ext.setReference(value, mat);
+                            }
                             let pointer = this.map.get(value);
                             if (!pointer) {
                                 const definition = context.jsonDoc.json.materials[index];

package/dist/extensions/NEEDLE_opaque/index.js

@@ -2,7 +2,7 @@ import { PropertyType } from "@gltf-transform/core";
 import { createOpaqueExtension } from "./NEEDLE_opaque.js";
 export * from "./NEEDLE_opaque.js";
 const opaqueOptions = {
-    debug: false,
+    debug: process.argv.includes("debug"),
 };
 export const ALL_EXTENSIONS = [
     createOpaqueExtension("KHR_animation_pointer", [PropertyType.ANIMATION, PropertyType.ANIMATION_CHANNEL], { ...opaqueOptions }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",