@needle-tools/gltf-build-pipeline 1.1.6 → 1.2.1

package/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.2.1] - 2023-07-25
+- change: set reference to materials used by json pointers
+
+## [1.2.0] - 2023-07-21
+- add: resolving of material json pointers
+
+## [1.1.6] - 2023-07-10
+- change: bump gltf-transform dependency to latest 3.4.6
+
 ## [1.1.5] - 2023-06-26
 - change: bump gltf-transform dependency to latest 3.4.3
 

package/dist/extensions/NEEDLE_opaque/NEEDLE_opaque.js

@@ -556,16 +556,27 @@ class JsonPointerHandler {
                             console.warn("WARN: failed registering pointer", fullPath, value);
                     }
                     if (value.startsWith("/materials/")) {
-                        // set a reference to the material to avoid dedup
-                        // see https://github.com/donmccurdy/glTF-Transform/issues/980#issuecomment-1585748202
                         if (this.debug)
                             console.log("Read pointer", value);
                         const index = parseInt(value.substring("/materials/".length));
                         const mat = context.materials[index];
                         if (mat) {
+                            // set a reference to the material to avoid dedup or the material being removed because it MIGHT not be used by any node
+                            // BUT a component is referencing the material so we don't want it ever to be removed 
+                            // see https://github.com/donmccurdy/glTF-Transform/issues/980#issuecomment-1585748202
                             if (ext) {
-                                ext.setReference(key, mat);
+                                ext.setReference(value, mat);
                             }
+                            let pointer = this.map.get(value);
+                            if (!pointer) {
+                                const definition = context.jsonDoc.json.materials[index];
+                                const res = new MaterialPointerResolver(this.document, mat, definition);
+                                res.init(context); // < init here otherwise the fields defined in the TexturePointer will be undefined (this caused e.g. finding the previous texture filter to fail)
+                                pointer = new JsonPointer("/materials/", res);
+                                pointer.debug = this.debug;
+                                this.map.set(value, pointer);
+                            }
+                            pointer?.register(obj, key);
                         }
                     }
                 }
@@ -715,3 +726,10 @@ function findSource(texDef) {
     }
     return undefined;
 }
+class MaterialPointerResolver extends PointerResolver {
+    init(context) {
+    }
+    resolve(context) {
+        return context.materialIndexMap.get(this.inputObject);
+    }
+}

package/dist/extensions/NEEDLE_opaque/index.js

@@ -2,7 +2,7 @@ import { PropertyType } from "@gltf-transform/core";
 import { createOpaqueExtension } from "./NEEDLE_opaque.js";
 export * from "./NEEDLE_opaque.js";
 const opaqueOptions = {
-    debug: false,
+    debug: process.argv.includes("debug"),
 };
 export const ALL_EXTENSIONS = [
     createOpaqueExtension("KHR_animation_pointer", [PropertyType.ANIMATION, PropertyType.ANIMATION_CHANNEL], { ...opaqueOptions }),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.1.6",
+  "version": "1.2.1",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",