@needle-tools/gltf-build-pipeline 1.0.5 → 1.0.6

package/CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [1.0.6] - 2023-05-06
+- fix: dont add textures to cache when toktx is not installed
+
 ## [1.0.5] - 2023-05-06
 - fix: catch exception in cases where toktx is not installed (e.g. in CI environment) and log warning instead
 

package/dist/transforms/needle_common.d.ts

@@ -6,7 +6,7 @@ export interface NeedleTransformContext {
     noToktx: boolean;
 }
 export interface INeedleTextureTransformContext {
-    prepare(document: Document): Promise<void>;
+    prepare(document: Document): Promise<void | boolean>;
     process(index: number, texture: Texture, settings: NEEDLE_compression_texture_schema): Promise<boolean>;
     finalize(document: Document): Promise<void>;
 }

package/dist/transforms/needle_texture_transform.js

@@ -131,8 +131,8 @@ async function processTexture(texture, index, document, logger, context) {
         if (canRunToktx) {
             // if no specific compression settings are provided we just use the toktx default settings
             // if we ever change what is used for default compression we need to teach the cache to save the mime type
-            await context.toktxContext.process(index, texture, null);
-            successFullyProcessed = true;
+            successFullyProcessed = await context.toktxContext.process(index, texture, null);
+            // don't add textures to the cache when toktx doesnt run
         }
         else {
             console.log("toktx is disallowed. Skipping texture compression.");

package/dist/transforms/needle_toktx.d.ts

@@ -19,7 +19,7 @@ export declare class NeedleToktxContext implements INeedleTextureTransformContex
     numTextures: number;
     private _prepareFailed;
     constructor(options: NeedleToktxOptions);
-    prepare(document: Document): Promise<void>;
+    prepare(document: Document): Promise<boolean>;
     process(index: number, texture: Texture, settings: NEEDLE_compression_texture_schema | null): Promise<boolean>;
     finalize(document: Document): Promise<void>;
 }

package/dist/transforms/needle_toktx.js

@@ -66,8 +66,9 @@ export class NeedleToktxContext {
             const logger = document.getLogger();
             this.version = await checkKTXSoftware(logger, this.env);
             if (this.version === null) {
+                console.log("Will not run toktx transform");
                 this._prepareFailed = true;
-                return;
+                return false;
             }
             this.basisuExtension = document.createExtension(KHRTextureBasisu).setRequired(true);
             const tmpDir = `${tmp.tmpdir}/gltf-transform`;
@@ -80,7 +81,9 @@ export class NeedleToktxContext {
             console.error(e);
             console.log("Error preparing toktx transform");
             this._prepareFailed = true;
+            return false;
         }
+        return true;
     }
     async process(index, texture, settings) {
         const task = async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@needle-tools/gltf-build-pipeline",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Pipeline and tools for optimizing gltf files using gltf-transform and compression settings within glTF extensions",
   "main": "index.mjs",
   "type": "module",