@needle-tools/engine 5.1.15 → 5.1.16

package/src/engine-components/export/usdz/USDZExporter.ts

@@ -3,7 +3,7 @@ import { Euler, Material, Matrix4, Mesh, Object3D, Quaternion, Vector3 } from "t
 
 import { isDevEnvironment, showBalloonMessage, showBalloonWarning } from "../../../engine/debug/index.js";
 import { findObjectOfType } from "../../../engine/engine_components.js";
-import { __iOMsPxgl } from "../../../engine/engine_license.js";
+import { _$RTXoT } from "../../../engine/engine_license.js";
 import { serializable } from "../../../engine/engine_serialization.js";
 import { getFormattedDate, Progress } from "../../../engine/engine_time_utils.js";
 import { DeviceUtilities, getParam } from "../../../engine/engine_utils.js";
@@ -277,7 +277,7 @@ export class USDZExporter extends Behaviour {
         let name = this.exportFileName ?? this.objectToExport?.name ?? this.name;
         name += "-" + getFormattedDate(); // seems iOS caches the file in some cases, this ensures we always have a fresh file
 
-        if (!__iOMsPxgl()) {
+        if (!_$RTXoT()) {
             if (name !== "") name += "-";
             name += "MadeWithNeedle";
         }
@@ -682,7 +682,7 @@ export class USDZExporter extends Behaviour {
                     if (debug)
                         showBalloonMessage("Quicklook url: " + callToActionURL);
                     if (callToActionURL) {
-                        if (!__iOMsPxgl()) {
+                        if (!_$RTXoT()) {
                             console.warn("Quicklook closed: custom redirects require a Needle Engine Pro license: https://needle.tools/pricing", callToActionURL)
                         }
                         else {
@@ -697,7 +697,7 @@ export class USDZExporter extends Behaviour {
     private buildQuicklookOverlay(): CustomBranding {
         const obj: CustomBranding = {};
         if (this.customBranding) Object.assign(obj, this.customBranding);
-        if (!__iOMsPxgl()) {
+        if (!_$RTXoT()) {
             console.log("Custom Quicklook banner text requires pro license: https://needle.tools/pricing");
             obj.callToAction = "Close";
             obj.checkoutTitle = "🌵 Made with Needle";

package/src/engine-components/web/Clickthrough.ts

@@ -5,15 +5,17 @@ import { onStart } from "../../engine/engine_lifecycle_api.js";
 import { addAttributeChangeCallback } from "../../engine/engine_utils.js";
 import { Behaviour } from "../Component.js";
 
+const attributeUnsubscribers = new WeakMap<ClickThrough, () => void>();
+
 // Automatically add ClickThrough component if "clickthrough" attribute is present on the needle-engine element
 onStart(ctx => {
     const attribute = ctx.domElement.getAttribute("clickthrough");
     if (clickthroughEnabled(attribute)) {
         const comp = ctx.scene.addComponent(ClickThrough);
-        addAttributeChangeCallback(ctx.domElement, "clickthrough", () => {
+        attributeUnsubscribers.set(comp, addAttributeChangeCallback(ctx.domElement, "clickthrough", () => {
             const attribute = ctx.domElement.getAttribute("clickthrough");
             comp.enabled = clickthroughEnabled(attribute);
-        });
+        }));
     }
 
     function clickthroughEnabled(val: string | null) {
@@ -167,6 +169,10 @@ export class ClickThrough extends Behaviour {
         window.removeEventListener("touchend", this.onTouchEnd);
         this.context.domElement.style.pointerEvents = this._previousPointerEvents;
     }
+    onDestroy() {
+        attributeUnsubscribers.get(this)?.();
+        attributeUnsubscribers.delete(this);
+    }
     onPointerEnter() {
         /** do nothing, necessary to raycast children */
     }

package/src/engine-components-experimental/networking/PlayerSync.ts

@@ -114,11 +114,8 @@ export class PlayerSync extends Behaviour {
         this.onPlayerSpawned = new EventList();
     }
 
-    awake(): void {
-        this.watchTabVisible();
-    }
-
     onEnable(): void {
+        document.addEventListener("visibilitychange", this.onVisibilityChange);
         this.context.connection.beginListen(RoomEvents.RoomStateSent, this.onJoinedRoom);
         this.context.connection.beginListen(RoomEvents.JoinedRoom, this.onJoinedRoom);
         this.context.connection.beginListen(RoomEvents.LeftRoom, this.destroyInstance);
@@ -141,6 +138,7 @@ export class PlayerSync extends Behaviour {
         }
     }
     onDisable(): void {
+        document.removeEventListener("visibilitychange", this.onVisibilityChange);
         this.context.connection.stopListen(RoomEvents.RoomStateSent, this.onJoinedRoom);
         this.context.connection.stopListen(RoomEvents.JoinedRoom, this.onJoinedRoom);
         this.context.connection.stopListen(RoomEvents.LeftRoom, this.destroyInstance);
@@ -207,18 +205,16 @@ export class PlayerSync extends Behaviour {
     /**
      * Sets up visibility change listeners to handle player cleanup when browser tab visibility changes
      */
-    private watchTabVisible() {
-        window.addEventListener("visibilitychange", _ => {
-            if (document.visibilityState === "visible") {
-                for (let i = PlayerState.all.length - 1; i >= 0; i--) {
-                    const pl = PlayerState.all[i];
-                    if (!pl.owner || !this.context.connection.userIsInRoom(pl.owner)) {
-                        pl.doDestroy();
-                    }
+    private onVisibilityChange = () => {
+        if (document.visibilityState === "visible") {
+            for (let i = PlayerState.all.length - 1; i >= 0; i--) {
+                const pl = PlayerState.all[i];
+                if (!pl.owner || !this.context.connection.userIsInRoom(pl.owner)) {
+                    pl.doDestroy();
                 }
             }
-        });
-    }
+        }
+    };
 }
 
 /**
@@ -454,4 +450,4 @@ export class PlayerState extends Behaviour {
             return;
         }
     }
-}
+}