@needle-tools/engine 5.1.0-experimental.3 → 5.1.0-experimental.4

package/src/engine/js-extensions/three.ts

@@ -0,0 +1,72 @@
+/**
+ * Type augmentations and utilities for three.js r183.
+ *
+ * Some properties exist at runtime but were removed or changed in @types/three r183.
+ * This module provides type-safe access without `as any` casts.
+ */
+
+import type { Interpolant, Texture, Source } from 'three';
+
+// #region Module augmentation for properties that exist at runtime but are missing from types
+
+declare module 'three' {
+    interface Material {
+        /** Unique ID for this material instance. Exists at runtime via Object.defineProperty. */
+        readonly id: number;
+    }
+
+    interface KeyframeTrack {
+        /** Creates an interpolant for sampling this track. Exists at runtime. */
+        createInterpolant(): Interpolant;
+    }
+}
+
+// #region Texture image type utilities
+// Texture<TImage = unknown> uses a generic for image data. At runtime this can be
+// ImageBitmap, HTMLImageElement, HTMLCanvasElement, HTMLVideoElement,
+// or a plain object with {width, height, data} (DataTexture/CompressedTexture).
+
+/** Checks if a texture image has width/height dimensions (ImageBitmap, HTMLImageElement, HTMLCanvasElement, etc.) */
+export function hasImageDimensions(image: unknown): image is { width: number; height: number } {
+    return image != null
+        && typeof image === 'object'
+        && typeof (image as any).width === 'number'
+        && typeof (image as any).height === 'number';
+}
+
+/** Get the width/height from a texture, checking image, source.data, and direct properties (e.g. render targets) */
+export function getTextureDimensions(texture: Texture): { width: number; height: number } {
+    if (hasImageDimensions(texture.image)) {
+        return { width: texture.image.width, height: texture.image.height };
+    }
+    const srcData = texture.source?.data;
+    if (hasImageDimensions(srcData)) {
+        return { width: srcData.width, height: srcData.height };
+    }
+    // RenderTarget textures may have dimensions on the texture itself
+    if (hasImageDimensions(texture)) {
+        return { width: texture.width, height: texture.height };
+    }
+    return { width: 0, height: 0 };
+}
+
+/** Checks if a texture image has pixel data (typed array from DataTexture) */
+export function hasPixelData(image: unknown): image is { data: ArrayBufferView; width: number; height: number } {
+    return hasImageDimensions(image) && (image as any).data != null;
+}
+
+/** Get the source data of a texture as a dimension-bearing object, or null */
+export function getSourceDimensions(texture: Texture): { width: number; height: number } | null {
+    const data = texture.source?.data;
+    if (hasImageDimensions(data)) return data;
+    return null;
+}
+
+/** Checks if a value is a renderable image (ImageBitmap, HTMLImageElement, HTMLCanvasElement, etc.) */
+export function isTextureImage(image: unknown): image is TexImageSource | OffscreenCanvas {
+    return image instanceof ImageBitmap
+        || image instanceof HTMLImageElement
+        || image instanceof HTMLCanvasElement
+        || image instanceof HTMLVideoElement
+        || (typeof OffscreenCanvas !== 'undefined' && image instanceof OffscreenCanvas);
+}

package/src/engine/physics/workers/mesh-bvh/GenerateMeshBVHWorker.js

@@ -7,18 +7,10 @@ import { WorkerBase } from "three-mesh-bvh/src/workers/utils/WorkerBase.js";
 export class GenerateMeshBVHWorker extends WorkerBase {
 
 	constructor() {
-		// Worker loading: resolve the worker URL via import.meta.resolve so that bare
-		// specifiers like 'three-mesh-bvh/...' are correctly resolved through the module
-		// system (node_modules) rather than relative to this file's location.
-		// Falls back to new URL() + import.meta.url for environments without import.meta.resolve.
 		// https://linear.app/needle/issue/NE-6572
-		let workerUrl;
-		try {
-			workerUrl = import.meta.resolve('three-mesh-bvh/src/workers/generateMeshBVH.worker.js');
-		} catch {
-			workerUrl = new URL('three-mesh-bvh/src/workers/generateMeshBVH.worker.js', import.meta.url);
-		}
-		super(new Worker(workerUrl, { type: 'module' }));
+		// The URL must start with "/" so the rollupFixWorkerImport plugin rewrites it
+		// for production builds. In dev, vite serves /node_modules/ paths directly.
+		super(new Worker(new URL("/node_modules/three-mesh-bvh/src/workers/generateMeshBVH.worker.js", import.meta.url), { type: 'module' }));
 		this.name = 'GenerateMeshBVHWorker';
 
 	}

package/src/engine/webcomponents/icons.ts

@@ -62,7 +62,7 @@ export async function getIconTexture(str: string): Promise<Texture | null> {
         const texture = new Texture();
         texture.name = str + " icon";
         const img = new Image();
-        (texture as any).image = img;
+        texture.image = img;
         img.src = data;
         texture.needsUpdate = true;
         textures.set(str, texture);

package/src/engine-components/export/usdz/ThreeUSDZExporter.ts

@@ -1516,7 +1516,7 @@ function getGeometryName(geometry: BufferGeometry, _fallbackName: string) {
 }
 
 function getMaterialName(material: Material) {
-	return makeNameSafe(material.name || 'Material') + "_" + (material as any).id;
+	return makeNameSafe(material.name || 'Material') + "_" + material.id;
 }
 
 function getPathToSkeleton(bone: Object3D, assumedRoot: Object3D) {

package/src/engine-components/export/usdz/extensions/Animation.ts

@@ -218,10 +218,9 @@ export class TransformData {
         const scale = new Vector3(1, 1, 1);
         const object = this.target;
 
-        // createInterpolant exists at runtime but was removed from types in r183
-        const positionInterpolant: Interpolant | undefined = generatePos ? (this.pos as any)?.createInterpolant() : undefined;
-        const rotationInterpolant: Interpolant | undefined = generateRot ? (this.rot as any)?.createInterpolant() : undefined;
-        const scaleInterpolant: Interpolant | undefined = generateScale ? (this.scale as any)?.createInterpolant() : undefined;
+        const positionInterpolant: Interpolant | undefined = generatePos ? this.pos?.createInterpolant() : undefined;
+        const rotationInterpolant: Interpolant | undefined = generateRot ? this.rot?.createInterpolant() : undefined;
+        const scaleInterpolant: Interpolant | undefined = generateScale ? this.scale?.createInterpolant() : undefined;
 
         if (!positionInterpolant) translation.set(object.position.x, object.position.y, object.position.z);
         if (!rotationInterpolant) rotation.set(object.quaternion.x, object.quaternion.y, object.quaternion.z, object.quaternion.w);

package/src/engine-components/export/usdz/extensions/behavior/BehaviourComponents.ts

@@ -388,7 +388,7 @@ export class ChangeMaterialOnClick extends Behaviour implements IPointerClickHan
     }
 
     private static getMaterialName(material: Material) {
-        return makeNameSafeForUSD(material.name || 'Material') + "_" + (material as any).id;
+        return makeNameSafeForUSD(material.name || 'Material') + "_" + material.id;
     }
 
     static variantSwitchIndex: number = 0;

package/src/engine-components/postprocessing/PostProcessingHandler.ts

@@ -577,7 +577,7 @@ export class PostProcessingHandler {
         // Assigning a new Source breaks the deduplication so they get separate GL textures.
         const composerDepthTexture = (composer as any).depthTexture as DepthTexture | null;
         if (composerDepthTexture) {
-            composerDepthTexture.source = new Source({ width: 0, height: 0 } as any);
+            composerDepthTexture.source = new Source({ width: 0, height: 0, depth: 1 });
             composerDepthTexture.needsUpdate = true;
         }
 

package/src/engine-components/timeline/TimelineTracks.ts

@@ -700,8 +700,8 @@ export class AudioTrackHandler extends TrackHandler {
             }
             if (AudioSource.userInteractionRegistered === false) continue;
             if (audio === null || !audio.buffer) continue;
-            (audio as any).playbackRate = this.director.context.time.timeScale * this.director.speed;
-            (audio as any).loop = asset.loop;
+            audio.setPlaybackRate(this.director.context.time.timeScale * this.director.speed);
+            audio.setLoop(asset.loop);
             if (time >= model.start && time <= model.end && time < this.director.duration) {
                 if (!audio.isPlaying || !this.director.isPlaying) {
                     // if the timeline is paused we trigger the audio clip once when the model is entered

package/src/engine-components/ui/Image.ts

@@ -1,4 +1,5 @@
 import { Color, Texture } from 'three';
+import { hasImageDimensions } from '../../engine/js-extensions/three.js';
 
 import { serializable } from '../../engine/engine_serialization_decorator.js';
 import { MaskableGraphic } from './Graphic.js';
@@ -77,7 +78,8 @@ export class Image extends MaskableGraphic {
         }
         // this is a hack/workaround for production builds where the name of the sprite is missing
         // need to remove this!!!!
-        if (!sprite?.texture?.name?.length && (sprite?.texture?.image as any)?.width === 32 && (sprite?.texture?.image as any)?.height === 32)
+        const img = sprite?.texture?.image;
+        if (!sprite?.texture?.name?.length && hasImageDimensions(img) && img.width === 32 && img.height === 32)
             return true;
         return false;
     }