@needle-tools/engine 4.8.6-next.7fdd4fa → 4.8.6-next.9f367ef

package/src/engine/extensions/extensions.ts

@@ -22,11 +22,11 @@ const debug = getParam("debugextensions");
 
 // lazily import the GLTFAnimationPointerExtension in case it doesnt exist (e.g. using vanilla three)
 let GLTFAnimationPointerExtension: any;
-const KHR_ANIMATIONPOINTER_IMPORT = import("three/examples/jsm/loaders/GLTFLoaderAnimationPointer.js").then(async mod => {
+const KHR_ANIMATIONPOINTER_IMPORT = import("@needle-tools/three-animation-pointer").then(async mod => {
     GLTFAnimationPointerExtension = mod.GLTFAnimationPointerExtension;
     return GLTFAnimationPointerExtension;
 }).catch(e => {
-    console.warn("Failed to import GLTFLoaderAnimationPointer. Please use @needle-tools/three for full KHR_animation support", e);
+    console.warn("Failed to import GLTFLoaderAnimationPointer. Please use @needle-tools/three-animationpointer for full KHR_animation support", e);
 });
 
 

package/src/engine/js-extensions/Object3D.ts

@@ -1,7 +1,7 @@
 import { Object3D, Quaternion, Vector3 } from "three";
 import { TransformControlsGizmo } from "three/examples/jsm/controls/TransformControls.js";
 
-import { addComponent, addNewComponent, getComponent, getComponentInChildren, getComponentInParent, getComponents, getComponentsInChildren, getComponentsInParent, getOrAddComponent, removeComponent } from "../../engine/engine_components.js";
+import { addComponent, getComponent, getComponentInChildren, getComponentInParent, getComponents, getComponentsInChildren, getComponentsInParent, getOrAddComponent, removeComponent } from "../../engine/engine_components.js";
 import { destroy, isActiveSelf, setActive } from "../../engine/engine_gameobject.js";
 import {
     getTempVector,
@@ -15,7 +15,9 @@ import {
     setWorldScale
 }
     from "../../engine/engine_three_utils.js";
-import type { ComponentInit, Constructor, ConstructorConcrete, HideFlags,IComponent as Component, IComponent } from "../../engine/engine_types.js";
+import type { ComponentInit, Constructor, ConstructorConcrete, HideFlags, IComponent as Component, IComponent } from "../../engine/engine_types.js";
+import { NEEDLE_ENGINE_FEATURE_FLAGS } from "../engine_feature_flags.js";
+import { markHierarchyDirty } from "../engine_mainloop_utils.js";
 import { applyPrototypeExtensions, registerPrototypeExtensions } from "./ExtensionUtils.js";
 
 
@@ -150,6 +152,27 @@ export function apply(object: Object3D) {
     }
 }
 
+if (NEEDLE_ENGINE_FEATURE_FLAGS.experimentalSmartHierarchyUpdate) {
+
+    const addFn = Object3D.prototype.add;
+    Object3D.prototype.add = function (...args: any) {
+        markHierarchyDirty();
+        return addFn.apply(this, args);
+    }
+
+    const attachFn = Object3D.prototype.attach;
+    Object3D.prototype.attach = function (...args: any) {
+        markHierarchyDirty();
+        return attachFn.apply(this, args);
+    }
+
+    const removeFn = Object3D.prototype.remove;
+    Object3D.prototype.remove = function (...args: any) {
+        markHierarchyDirty();
+        return removeFn.apply(this, args);
+    }
+}
+
 
 Object3D.prototype["SetActive"] = function (active: boolean) {
     this.visible = active;

package/src/engine-components/Skybox.ts

@@ -217,9 +217,9 @@ export class RemoteSkybox extends Behaviour {
             if (debug) console.warn("RemoteSkybox: Failed to load texture from url", url);
             return false;
         }
-        // Check if we're still enabled
-        if (!this.enabled) {
-            if (debug) console.warn("RemoteSkybox: Component is not enabled, aborting setSkybox");
+        // Check if we're not disabled or destroyed
+        if (!this.enabled || this.destroyed) {
+            if (debug) console.warn("RemoteSkybox: Component is disabled or destroyed");
             return false;
         }
         // Check if the url has changed while loading
@@ -239,7 +239,6 @@ export class RemoteSkybox extends Behaviour {
         const envMap = this._prevLoadedEnvironment;
         if (!envMap) return;
 
-
         if ((envMap instanceof CubeTexture || envMap instanceof CompressedCubeTexture) || envMap.mapping == CubeUVReflectionMapping) {
             // Nothing to do
         }
@@ -248,6 +247,11 @@ export class RemoteSkybox extends Behaviour {
             envMap.needsUpdate = true;
         }
 
+        if(this.destroyed) return;
+        if(!this.context) {
+            console.warn("RemoteSkybox: Context is not available - can not apply skybox.");
+            return;
+        }
 
         // capture state
         if (this.context.scene.background !== envMap)