@needle-tools/engine 4.8.2 → 4.8.3-next.106dc4b

package/src/engine/engine_networking_streams.ts

@@ -8,7 +8,7 @@ import { showBalloonMessage } from "./debug/index.js";
 import { Application } from "./engine_application.js";
 import { Context } from "./engine_context.js";
 import type { IModel } from "./engine_networking_types.js";
-import { type IComponent,isComponent } from "./engine_types.js";
+import { type IComponent, isComponent } from "./engine_types.js";
 import { getParam } from "./engine_utils.js";
 
 
@@ -113,8 +113,8 @@ class CallHandle extends EventDispatcher<any> {
     }
 }
 
-function applySdpTransform(sdp){
-    sdp = sdp.replace("a=fmtp:111 minptime=10;useinbandfec=1","a=fmtp:111 ptime=5;useinbandfec=1;stereo=1;maxplaybackrate=48000;maxaveragebitrat=128000;sprop-stereo=1");
+function applySdpTransform(sdp) {
+    sdp = sdp.replace("a=fmtp:111 minptime=10;useinbandfec=1", "a=fmtp:111 ptime=5;useinbandfec=1;stereo=1;maxplaybackrate=48000;maxaveragebitrat=128000;sprop-stereo=1");
     return sdp;
 }
 
@@ -237,10 +237,19 @@ export class PeerHandle extends EventDispatcher<any> {
         this.context = context;
         this.id = id;
         this.setupPeer();
-        navigator["getUserMedia"] = (
-            navigator["getUserMedia"] || navigator["webkitGetUserMedia"] ||
-            navigator["mozGetUserMedia"] || navigator["msGetUserMedia"]
-        );
+        const isGetUserMediaWriteable = Object.getOwnPropertyDescriptor(navigator, "getUserMedia")?.writable;
+        try {
+            if (isGetUserMediaWriteable) {
+                navigator["getUserMedia"] = (
+                    navigator["getUserMedia"] || navigator["webkitGetUserMedia"] ||
+                    navigator["mozGetUserMedia"] || navigator["msGetUserMedia"]
+                );
+            }
+            else if (debug) console.warn("[PeerJs] getUserMedia is not writable");
+        }
+        catch (err) {
+            if (debug) console.error("[PeerJs] Error setting getUserMedia", err);
+        }
     }
 
     private _enabled: boolean = false;
@@ -479,7 +488,7 @@ export class NetworkedStreams extends EventDispatcher<any> {
         }
 
         if (!context) throw new Error("Failed to create NetworkedStreams because context is undefined");
-        else if(!(context instanceof Context)) throw new Error("Failed to create NetworkedStreams because context is not an instance of Context");
+        else if (!(context instanceof Context)) throw new Error("Failed to create NetworkedStreams because context is not an instance of Context");
         if (!peer) throw new Error("Failed to create NetworkedStreams because peer is undefined");
 
         this.context = context;

package/src/engine/webcomponents/buttons.ts

@@ -218,7 +218,11 @@ export class ButtonsFactory {
             await generateAndInsertQRCode();
             // TODO: make sure it doesnt overflow the screen
             // we need to add the qrCodeContainer to the body to get the correct size
-            document.body.appendChild(qrCodeContainer);
+            // TODO: we would need to search for the right engine element to insert this into if there are more
+            // Insert the QR code overlay inside the needle-engine element
+            const engine_element = document.body.querySelector("needle-engine");
+            const parent = engine_element || document.body;
+            parent.appendChild(qrCodeContainer);
             const containerRect = qrCodeElement.getBoundingClientRect();
             const buttonRect = qrCodeButton.getBoundingClientRect();
             qrCodeContainer.style.left = (buttonRect.left + buttonRect.width * .5 - containerRect.width * .5) + "px";
@@ -245,7 +249,7 @@ export class ButtonsFactory {
                 document.fullscreenElement.appendChild(qrCodeContainer);
             }
             else
-                document.body.appendChild(qrCodeContainer);
+                parent.appendChild(qrCodeContainer);
         }
 
         /** hides to QRCode overlay and unsubscribes from events */

package/src/engine/webcomponents/needle menu/needle-menu.ts

@@ -287,6 +287,16 @@ export class NeedleMenuElement extends HTMLElement {
         // TODO: make host full size again and move the buttons to a wrapper so that we can later easily open e.g. foldouts/dropdowns / use the whole canvas space
         template.innerHTML = `<style>
 
+        /** Styling attributes that ensure the nested menu z-index does not cause it to overlay elements outside of <needle-engine> */
+        :host {
+            position: absolute;
+            width: 100%;
+            height: 100%;
+            z-index: 0;
+            top: 0;
+            pointer-events: none;
+        }
+
         #root {
             position: absolute;
             width: auto;

package/src/engine-components/OrbitControls.ts

@@ -565,6 +565,11 @@ export class OrbitControls extends Behaviour implements ICameraController {
         }
     }
 
+    onPausedChanged(isPaused: boolean): void {
+        if (!this._controls) return;
+        if (isPaused) this._controls.enabled = false;
+    }
+
 
     /** @internal */
     onBeforeRender() {