@needle-tools/engine 4.6.0 → 4.6.1-next.26cf56c

package/src/engine-components/postprocessing/Volume.ts

@@ -56,6 +56,9 @@ export class Volume extends Behaviour implements IEditorModificationReceiver, IP
         return this._activeEffects;
     }
 
+    get dirty() { return this._isDirty; }
+    set dirty(value: boolean) { this._isDirty = value; }
+
     @serializeable(VolumeProfile)
     sharedProfile?: VolumeProfile;
 
@@ -185,7 +188,17 @@ export class Volume extends Behaviour implements IEditorModificationReceiver, IP
                 this.context.composer.setMainScene(this.context.scene);
 
                 const composer = this.context.composer;
-                if (this.multisampling === "auto") {
+
+                // If the postprocessing handler is using depth+normals (e.g. with SMAA) we ALWAYS disable multisampling to avoid ugly edges
+                if (this._postprocessing && (this._postprocessing.hasSmaaEffect)) {
+                    if (composer.multisampling !== 0) {
+                        composer.multisampling = 0;
+                        if (debug || isDevEnvironment()) {
+                            console.warn(`[PostProcessing] Disabling multisampling because depth or normals are used. If you need anti-aliasing, consider adding an Antialiasing component or SMAA effect to the PostprocessingManager.`);
+                        }
+                    }
+                }
+                else if (this.multisampling === "auto") {
 
                     const timeSinceLastChange = this.context.time.realtimeSinceStartup - this._multisampleAutoChangeTime;
 

package/src/engine-components/postprocessing/utils.ts

@@ -11,6 +11,8 @@ export const debug = getParam("debugpost");
 
 export type IPostProcessingManager = IComponent & {
     get isPostProcessingManager(): boolean;
+    get dirty(): boolean;
+    set dirty(value: boolean);
     addEffect(effect: PostProcessingEffect): void;
     removeEffect(effect: PostProcessingEffect): void;
 }