@needle-tools/engine 4.4.0-beta.4 → 4.4.0-beta.6

package/src/engine/xr/NeedleXRController.ts

@@ -381,12 +381,11 @@ export class NeedleXRController implements IPointerHitEventReceiver {
     }
 
     onUpdate(frame: XRFrame) {
-        performance.mark('NeedleXRController onUpdate start');
         this.onUpdateFrame(frame);
         this.updateInputEvents();
         this.onUpdateMove();
-        performance.mark('NeedleXRController onUpdate end');
-        performance.measure('NeedleXRController onUpdate', 'NeedleXRController onUpdate start', 'NeedleXRController onUpdate end');
+        //performance.mark('NeedleXRController onUpdate end');
+        //performance.measure('NeedleXRController onUpdate', 'NeedleXRController onUpdate start', 'NeedleXRController onUpdate end');
     }
 
     onRenderDebug() {

package/src/engine/xr/NeedleXRSession.ts

@@ -444,7 +444,7 @@ export class NeedleXRSession implements INeedleXRSession {
         if (!context) context = ContextRegistry.All[0] as Context;
         if (!context) throw new Error("No Needle Engine Context found");
 
-        performance.mark('NeedleXRSession start');
+        //performance.mark('NeedleXRSession start');
 
         // setup session init args, make sure we have default values
         if (!init) init = {};
@@ -534,8 +534,8 @@ export class NeedleXRSession implements INeedleXRSession {
             return null;
         }
         const session = this.setSession(mode, newSession, init, context);
-        performance.mark('NeedleXRSession end');
-        performance.measure('NeedleXRSession Startup', 'NeedleXRSession start', 'NeedleXRSession end');
+        //performance.mark('NeedleXRSession end');
+        //performance.measure('NeedleXRSession Startup', 'NeedleXRSession start', 'NeedleXRSession end');
         return session;
     }
 
@@ -884,7 +884,7 @@ export class NeedleXRSession implements INeedleXRSession {
         /** the initialization arguments */
         init: XRSessionInit,
     }) {
-        performance.mark(measure_SessionStartedMarker);
+        //performance.mark(measure_SessionStartedMarker);
 
         saveSessionInfo(mode, extra.init);
         this.session = session;
@@ -1128,8 +1128,8 @@ export class NeedleXRSession implements INeedleXRSession {
 
         enableSpatialConsole(false);
 
-        performance.mark(measure_SessionEndedMarker);
-        performance.measure('NeedleXRSession', measure_SessionStartedMarker, measure_SessionEndedMarker);
+        //performance.mark(measure_SessionEndedMarker);
+        //performance.measure('NeedleXRSession', measure_SessionStartedMarker, measure_SessionEndedMarker);
     };
 
     private _didStart: boolean = false;
@@ -1139,7 +1139,7 @@ export class NeedleXRSession implements INeedleXRSession {
         const frame = context.xrFrame;
         if (!frame) return;
 
-        performance.mark('NeedleXRSession onBefore start');
+        //performance.mark('NeedleXRSession onBefore start');
 
         // ensure that XR is always set to a running session
         this.context.xr = this;
@@ -1291,7 +1291,7 @@ export class NeedleXRSession implements INeedleXRSession {
             console.error("XRControllers are not added but inputSources are present");
         }
 
-        performance.mark('NeedleXRSession update scripts start');
+        //performance.mark('NeedleXRSession update scripts start');
         // invoke update on all scripts
         for (const script of this._xr_update_scripts) {
             if (script.destroyed === true) {
@@ -1304,8 +1304,8 @@ export class NeedleXRSession implements INeedleXRSession {
             }
             if (script.onUpdateXR) script.onUpdateXR(args);
         }
-        performance.mark('NeedleXRSession update scripts end');
-        performance.measure('NeedleXRSession update scripts', 'NeedleXRSession update scripts start', 'NeedleXRSession update scripts end');
+        //performance.mark('NeedleXRSession update scripts end');
+        //performance.measure('NeedleXRSession update scripts', 'NeedleXRSession update scripts start', 'NeedleXRSession update scripts end');
 
         // handle inactive scripts
         this.handleInactiveScripts();
@@ -1326,8 +1326,8 @@ export class NeedleXRSession implements INeedleXRSession {
         this.sync?.onUpdate(this);
 
         this.onRenderDebug();
-        performance.mark('NeedleXRSession onBefore end');
-        performance.measure('NE XR frame', 'NeedleXRSession onBefore start', 'NeedleXRSession onBefore end');
+        //performance.mark('NeedleXRSession onBefore end');
+        //performance.measure('NE XR frame', 'NeedleXRSession onBefore start', 'NeedleXRSession onBefore end');
     }
 
     private onRenderDebug() {

package/src/engine-components/CameraUtils.ts

@@ -46,11 +46,14 @@ ContextRegistry.registerCallback(ContextEvent.MissingCamera, (evt) => {
     else {
         camInstance.clearFlags = ClearFlags.SolidColor;
 
-        let backgroundColor = "#efefef";
-        if (typeof window !== undefined && (window.matchMedia('(prefers-color-scheme: dark)').matches)) {
-            backgroundColor = "#1f1f1f";
+        // Don't set the background color if the user set a background color in the <needle-engine> element
+        if (!evt.context.domElement.getAttribute("background-color")) {
+            let backgroundColor = "#efefef";
+            if (typeof window !== undefined && (window.matchMedia('(prefers-color-scheme: dark)').matches)) {
+                backgroundColor = "#1f1f1f";
+            }
+            scene.background = new Color(backgroundColor); // dont set it on the camera because this might be controlled from "background-color" attribute which is set on the scene directly. If the camera has a background color, it will override the scene's background color
         }
-        scene.background = new Color(backgroundColor); // dont set it on the camera because this might be controlled from "background-color" attribute which is set on the scene directly. If the camera has a background color, it will override the scene's background color
 
         // Generate a default environment map if none is set
         if (!scene.environment) {

package/src/engine-components/ReflectionProbe.ts

@@ -1,4 +1,4 @@
-import { EquirectangularReflectionMapping, Material, MeshBasicMaterial, Object3D, SRGBColorSpace, Texture, Vector3 } from "three";
+import { EquirectangularReflectionMapping, LinearSRGBColorSpace, Material, MeshBasicMaterial, Object3D, SRGBColorSpace, Texture, Vector3 } from "three";
 
 import { serializable } from "../engine/engine_serialization.js";
 import { Context } from "../engine/engine_setup.js";
@@ -6,6 +6,7 @@ import type { IRenderer } from "../engine/engine_types.js";
 import { getParam } from "../engine/engine_utils.js";
 import { BoxHelperComponent } from "./BoxHelperComponent.js";
 import { Behaviour } from "./Component.js";
+import { isDevEnvironment, showBalloonWarning } from "../engine/debug/index.js";
 
 export const debug = getParam("debugreflectionprobe");
 const disable = getParam("noreflectionprobe");
@@ -35,13 +36,11 @@ export class ReflectionProbe extends Behaviour {
                             return probe;
                         }
                     }
-                    /*
                     // TODO not supported right now, as we'd have to pass the ReflectionProbe scale through as well.
                     else if (probe.isInBox(object)) {
                         if (debug) console.log("Found reflection probe", object.name, probe.name);
                         return probe;
                     }
-                    */
                 }
             }
         }
@@ -53,6 +52,8 @@ export class ReflectionProbe extends Behaviour {
 
 
     private _texture!: Texture;
+
+    // @serializable(Texture)
     set texture(tex: Texture) {
         if (tex && !(tex instanceof Texture)) {
             console.error("ReflectionProbe.texture must be a Texture", tex);
@@ -61,7 +62,7 @@ export class ReflectionProbe extends Behaviour {
         this._texture = tex;
         if (tex) {
             tex.mapping = EquirectangularReflectionMapping;
-            tex.colorSpace = SRGBColorSpace;
+            tex.colorSpace = LinearSRGBColorSpace;
             tex.needsUpdate = true;
         }
     }
@@ -94,10 +95,16 @@ export class ReflectionProbe extends Behaviour {
         if (debug)
             this._boxHelper.showHelper(0x555500, true);
 
-        if (this.texture) {
-            this.texture.mapping = EquirectangularReflectionMapping;
-            this.texture.colorSpace = SRGBColorSpace;
-            this.texture.needsUpdate = true;
+        if (this._texture) {
+            this._texture.mapping = EquirectangularReflectionMapping;
+            this._texture.colorSpace = LinearSRGBColorSpace;
+            this._texture.needsUpdate = true;
+        }
+    }
+    start(): void {
+        if (!this._texture && isDevEnvironment()) {
+            console.warn(`[ReflectionProbe] Missing texture. Please assign a custom cubemap texture. To use reflection probes assign them to your renderer's "anchor" property.`);
+            showBalloonWarning("ReflectionProbe configuration hint: See browser console for details")
         }
     }