@needle-tools/engine 4.3.2-beta.3 → 4.3.2-beta.4

package/src/engine/engine_context.ts

@@ -189,6 +189,10 @@ export class Context implements IContext {
 		ContextRegistry.Current = context;
 	}
 
+	static get All(): Context[] {
+		return ContextRegistry.All as Context[];
+	}
+
 	/** The name of the context */
 	name: string;
 	/** An alias for the context */

package/src/engine/engine_context_registry.ts

@@ -1,5 +1,7 @@
 import { type IComponent, type IContext, type LoadedModel } from "./engine_types.js";
 
+const debug = typeof window !== undefined ? window.location.search.includes("debugcontext") : false;
+
 /** The various events that can be dispatched by a Needle Engine {@link IContext} instance
  */
 export enum ContextEvent {
@@ -62,6 +64,8 @@ export class ContextRegistry {
 
     /** @internal Internal use only */
     static register(ctx: IContext) {
+        if (this.Registered.indexOf(ctx) !== -1) return;
+        if (debug) console.warn("Registering context");
         this.Registered.push(ctx);
         this.dispatchCallback(ContextEvent.ContextRegistered, ctx);
     }
@@ -70,6 +74,7 @@ export class ContextRegistry {
     static unregister(ctx: IContext) {
         const index = this.Registered.indexOf(ctx);
         if (index === -1) return;
+        if (debug) console.warn("Unregistering context");
         this.Registered.splice(index, 1);
     }
 

package/src/engine/engine_utils_format.ts

@@ -61,7 +61,11 @@ export async function tryDetermineFileTypeFromURL(url: string, useExtension: boo
 
     // If the URL doesnt contain a filetype we need to check the header
     // This is the case for example if we load a file from a data url
-    const header = await fetch(url, {
+    const newUrl = new URL(url);
+    // Adding a URL parameter to avoid the brower to bust the full cache
+    // If we don't do this the file that might already be disc cached will be deleted from the cache
+    newUrl.searchParams.append("range", "true");
+    const header = await fetch(newUrl, {
         method: "GET",
         headers: {
             "range": "bytes=0-32"

package/src/engine-components/Skybox.ts

@@ -5,7 +5,7 @@ import { KTX2Loader } from "three/examples/jsm/loaders/KTX2Loader.js";
 import { RGBELoader } from 'three/examples/jsm/loaders/RGBELoader.js';
 
 import { disposeObjectResources, setDisposable } from "../engine/engine_assetdatabase.js";
-import { ContextRegistry } from "../engine/engine_context_registry.js";
+import { ContextEvent, ContextRegistry } from "../engine/engine_context_registry.js";
 import { registerObservableAttribute } from "../engine/engine_element_extras.js";
 import { syncField } from "../engine/engine_networking_auto.js";
 import { serializable } from "../engine/engine_serialization_decorator.js";
@@ -39,11 +39,11 @@ function createRemoteSkyboxComponent(context: IContext, url: string, skybox: boo
     return remote.setSkybox(url);
 }
 
-ContextRegistry.addContextCreatedCallback((args) => {
+const promises = new Array<Promise<any>>();
+ContextRegistry.registerCallback(ContextEvent.ContextCreationStart, (args) => {
     const context = args.context;
     const skyboxImage = context.domElement.getAttribute("skybox-image") || context.domElement.getAttribute("background-image");
     const environmentImage = context.domElement.getAttribute("environment-image");
-    const promises = new Array<Promise<any>>();
     if (skyboxImage) {
         if (debug)
             console.log("Creating remote skybox to load " + skyboxImage);
@@ -60,10 +60,11 @@ ContextRegistry.addContextCreatedCallback((args) => {
         const promise = createRemoteSkyboxComponent(context, environmentImage, false, true, "environment-image");
         promises.push(promise);
     }
-    if (promises.length > 0) {
-        return PromiseAllWithErrors(promises);
-    }
-    return Promise.resolve();
+});
+ContextRegistry.registerCallback(ContextEvent.ContextCreationStart, () => {
+    return Promise.all(promises).finally(() => {
+        promises.length = 0;
+    })
 });
 
 declare type SkyboxCacheEntry = { src: string, texture: Promise<Texture> };