@needle-tools/engine 4.1.0-beta.3 → 4.1.0-beta.4

package/src/engine/engine_context.ts

@@ -1,7 +1,7 @@
 import type { EffectComposer } from "postprocessing";
 import {
 	BufferGeometry, Camera, Color, DepthTexture, Group,
-	Material, NearestFilter, NoToneMapping, Object3D, PCFSoftShadowMap,
+	Material, NearestFilter, NoToneMapping, Object3D, OrthographicCamera, PCFSoftShadowMap,
 	PerspectiveCamera, RGBAFormat, Scene, SRGBColorSpace,
 	Texture, WebGLRenderer, type WebGLRendererParameters, WebGLRenderTarget, type WebXRArrayCamera
 } from 'three';
@@ -485,7 +485,7 @@ export class Context implements IContext {
 		this.renderer.shadowMap.type = PCFSoftShadowMap;
 		this.renderer.setSize(this.domWidth, this.domHeight);
 		this.renderer.outputColorSpace = SRGBColorSpace;
-	
+
 		// Injecting the core nodes library here, like WebGPURenderer backends do
 		//@ts-ignore
 		this.renderer.nodes = {
@@ -545,16 +545,37 @@ export class Context implements IContext {
 		}
 	}
 
-	updateAspect(camera: PerspectiveCamera, width?: number, height?: number) {
+	updateAspect(camera: PerspectiveCamera | OrthographicCamera, width?: number, height?: number) {
 		if (!camera) return;
 		if (width === undefined)
 			width = this.domWidth;
 		if (height === undefined)
 			height = this.domHeight;
-		const pa = camera.aspect;
-		camera.aspect = width / height;
-		if (pa !== camera.aspect)
-			camera.updateProjectionMatrix();
+		const aspectRatio = width / height;
+		if ((camera as PerspectiveCamera).isPerspectiveCamera) {
+			const cam = camera as PerspectiveCamera;
+			const pa = cam.aspect;
+			cam.aspect = aspectRatio;
+			if (pa !== cam.aspect)
+				camera.updateProjectionMatrix();
+		}
+		else if ((camera as OrthographicCamera).isOrthographicCamera) {
+			const cam = camera as OrthographicCamera;
+			// Maintain the camera's current vertical size (top - bottom)
+			const verticalSize = cam.top - cam.bottom;
+			// Calculate new horizontal size based on aspect ratio
+			const horizontalSize = verticalSize * aspectRatio;
+			// Update camera bounds while maintaining center position
+			const halfWidth = horizontalSize / 2;
+			const halfHeight = verticalSize / 2;
+			if (cam.left != -halfWidth || cam.top != halfHeight) {
+				cam.left = -halfWidth;
+				cam.right = halfWidth;
+				cam.top = halfHeight;
+				cam.bottom = -halfHeight;
+				camera.updateProjectionMatrix();
+			}
+		}
 	}
 
 	/** This will recreate the whole needle engine context and dispose the whole scene content  
@@ -1078,7 +1099,7 @@ export class Context implements IContext {
 		// if the id was changed while still loading
 		// then we want to cleanup/destroy previously loaded files
 		if (createId !== this._createId || args.abortSignal?.aborted) {
-			if(debug) console.log("Aborting loading because create id changed or abort signal was set", createId, this._createId);
+			if (debug) console.log("Aborting loading because create id changed or abort signal was set", createId, this._createId);
 			for (const res of results) {
 				if (res && res.file) {
 					for (const scene of res.file.scenes)

package/src/engine-components/Camera.ts

@@ -51,7 +51,7 @@ export class Camera extends Behaviour implements ICamera {
             }
         }
     }
-    /** The camera's field of view in degrees if it is a perspective camera */
+    /** The camera's field of view in degrees if it is a perspective camera. Calls updateProjectionMatrix when set */
     get fieldOfView(): number | undefined {
         if (this._cam instanceof PerspectiveCamera) {
             return this._cam.fov;
@@ -74,7 +74,7 @@ export class Camera extends Behaviour implements ICamera {
         }
     }
 
-    /** The camera's near clipping plane */
+    /** The camera's near clipping plane. Calls updateProjectionMatrix when set */
     get nearClipPlane(): number { return this._nearClipPlane; }
     @serializable()
     set nearClipPlane(val) {
@@ -87,15 +87,7 @@ export class Camera extends Behaviour implements ICamera {
     }
     private _nearClipPlane: number = 0.1;
 
-    applyClippingPlane() {
-        if (this._cam) {
-            this._cam.near = this._nearClipPlane;
-            this._cam.far = this._farClipPlane;
-            this._cam.updateProjectionMatrix();
-        }
-    }
-
-    /** The camera's far clipping plane */
+    /** The camera's far clipping plane. Calls updateProjectionMatrix when set */
     get farClipPlane(): number { return this._farClipPlane; }
     @serializable()
     set farClipPlane(val) {
@@ -108,6 +100,17 @@ export class Camera extends Behaviour implements ICamera {
     }
     private _farClipPlane: number = 1000;
 
+    /**
+     * Applys both the camera's near and far plane and calls updateProjectionMatrix on the camera.
+     */
+    applyClippingPlane() {
+        if (this._cam) {
+            this._cam.near = this._nearClipPlane;
+            this._cam.far = this._farClipPlane;
+            this._cam.updateProjectionMatrix();
+        }
+    }
+
     /** The camera's clear flags - determines if the background is a skybox or a solid color or transparent */
     @serializable()
     public get clearFlags(): ClearFlags {

package/src/engine-components/OrbitControls.ts

@@ -287,7 +287,7 @@ export class OrbitControls extends Behaviour implements ICameraController {
             cam = this.gameObject;
         }
         if (cam) setCameraController(cam, this, true);
-        if (!this._controls && cam instanceof PerspectiveCamera) {
+        if (!this._controls && cam instanceof Object3D) {
             this._cameraObject = cam;
             // Using the parent if possible to make it possible to disable input on the canvas
             // for having HTML content behind it and still receive input