@needle-tools/engine 3.9.0-alpha → 3.9.0-alpha.1

package/CHANGELOG.md

@@ -4,8 +4,11 @@ All notable changes to this package will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [3.9.0-alpha.1] - 2023-07-12
+- Add: vite plugin to clamp version to `<= 4.3.9` since 4.4 and above currently cause issues with typescript decorators, [vite#13736](https://github.com/vitejs/vite/issues/13736)
+
 ## [3.9.0-alpha] - 2023-07-12
-- Add: `<needle-engine>` web component slot support, AR DOM overlay can now be added by simple adding HTML elements inside the `<needle-engine></needle-engine>` web component. Fixing [165](https://github.com/needle-tools/needle-engine-support/issues/164)
+- Add: `<needle-engine>` web component slot support, AR DOM overlay can now be added by simple adding HTML elements inside the `<needle-engine></needle-engine>` web component. Fixing [164](https://github.com/needle-tools/needle-engine-support/issues/164)
 - Add: Basic USDZ exporting of UI shadow hierarchies as mesh hierarchies for UI in Quicklook AR support
 - Fix: WebXR Rig not being rotated as expected when setting up in Unity [129](https://github.com/needle-tools/needle-engine-support/issues/129)
 - Fix: WebXR VR button click, hover is still not working

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "3.9.0-alpha",
+    "version": "3.9.0-alpha.1",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development with great integrations into editors like Unity or Blender - and can be deployed onto any device! It is flexible, extensible and networking and XR are built-in",
     "main": "dist/needle-engine.umd.cjs",
     "type": "module",

package/plugins/vite/vite-4.4-hack.js

@@ -7,33 +7,26 @@ import { execSync } from 'child_process';
  * @param {import('../types').userSettings} userSettings
  */
 export const vite_4_4_hack = (command, config, userSettings) => {
-    // if (userSettings.vite44Hack !== true) return;
+    if (userSettings.vite44Hack === false) return;
     return {
         name: "needle-vite-4.4-hack",
         async configureServer(server) {
-            // Check if this plugin should run
             const dir = process.cwd();
-            const needleEngineDirectory = path.join(dir, "node_modules", "@needle-tools", "engine");
-            const resolveSymlink = realpathSync(needleEngineDirectory);
-            // this issue only arises when the engine is installed locally
-            const isSymlink = resolveSymlink !== needleEngineDirectory;
-
-            if (userSettings.vite44Hack === true || isSymlink) {
-                const packageJsonPath = path.join(dir, "package.json");
-                const currentPackageJson = readFileSync(packageJsonPath, "utf8");
-                if (currentPackageJson.includes('"vite": "^4.3.4"')) {
-                    // see https://github.com/vitejs/vite/issues/13736
-                    console.log("Detected problematic vite version: Vite 4.4.x does currently have problems with typescript decorators. Switching to 4.3.9...")
-                    const newPackageJson = currentPackageJson.replace('"vite": "^4.3.4"', '"vite": "<= 4.3.9"');
-                    writeFileSync(packageJsonPath, newPackageJson, "utf8");
-                    // stop current server
-                    await server.close();
-                    // re-install with the limited package version
-                    execSync("npm install", { stdio: "inherit", cwd: dir });
-                    // start again
-                    execSync("npm start", { stdio: "inherit", cwd: dir });
-                }
+            const packageJsonPath = path.join(dir, "package.json");
+            const currentPackageJson = readFileSync(packageJsonPath, "utf8");
+            if (currentPackageJson.includes('"vite": "^4.3.4"')) {
+                // see https://github.com/vitejs/vite/issues/13736
+                console.log("Detected problematic vite version: Vite 4.4.x does currently have problems with typescript decorators. Switching to 4.3.9...")
+                const newPackageJson = currentPackageJson.replace('"vite": "^4.3.4"', '"vite": "<= 4.3.9"');
+                writeFileSync(packageJsonPath, newPackageJson, "utf8");
+                // stop current server
+                await server.close();
+                // re-install with the limited package version
+                execSync("npm install", { stdio: "inherit", cwd: dir });
+                // start again
+                execSync("npm start", { stdio: "inherit", cwd: dir });
             }
+
         },
     }
 }