@needle-tools/engine 3.7.3-alpha.2 → 3.7.5-alpha

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "3.7.3-alpha.2",
+    "version": "3.7.5-alpha",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development with great integrations into editors like Unity or Blender - and can be deployed onto any device! It is flexible, extensible and networking and XR are built-in",
     "main": "dist/needle-engine.umd.cjs",
     "type": "module",

package/src/engine/engine_context.ts

@@ -783,16 +783,19 @@ export class Context implements IContext {
 		}
 	}
 
-	private internalRender(_, frame: XRFrame | null) {
+	private _lastTimestamp = 0;
+	private internalRender(timestamp : DOMHighResTimeStamp, frame: XRFrame | null) {
 		this._xrFrame = frame;
 
 		this._currentFrameEvent = FrameEvent.Undefined;
-
+		
 		if (this.isInXR === false && this.targetFrameRate !== undefined) {
-			this._accumulatedTime += this._framerateClock.getDelta();
-			let targetFrameRate = this.targetFrameRate as any;
-			if (typeof targetFrameRate === "object") targetFrameRate = targetFrameRate.value;
-			// if(debug) console.log(targetFrameRate)
+			if(this._lastTimestamp === 0) this._lastTimestamp = timestamp;
+			this._accumulatedTime += (timestamp - this._lastTimestamp) /1000;
+			this._lastTimestamp = timestamp;
+			let targetFrameRate = this.targetFrameRate;
+			if (typeof targetFrameRate === "object") targetFrameRate = targetFrameRate.value!;
+			// if(debug) console.log(this._accumulatedTime, (1 / (targetFrameRate)))
 			if (this._accumulatedTime < (1 / (targetFrameRate + 1))) {
 				return;
 			}

package/src/engine-components/AudioSource.ts

@@ -309,6 +309,9 @@ export class AudioSource extends Behaviour {
     }
 
     play(clip: string | undefined = undefined) {
+        // Make sure this is always just a string
+        if (typeof clip !== "string") clip = undefined;
+
         if (!this.audioLoader || !this.sound || (clip && clip !== this.clip)) {
             this.loadAndPlay(clip);
             return;

package/src/engine-components/Component.ts

@@ -328,8 +328,10 @@ export class Component implements IComponent, EventTarget {
         return this.gameObject?.userData.tag;
     }
     set tag(str: string) {
-        if (this.gameObject)
+        if (this.gameObject) {
+            if (!this.gameObject.userData) this.gameObject.userData = {}
             this.gameObject.userData.tag = str;
+        }
     }
     get static() {
         return this.gameObject?.userData.static;

package/src/engine-components/SpatialTrigger.ts

@@ -63,17 +63,17 @@ export class SpatialTriggerReceiver extends Behaviour {
     onEnterTrigger(trigger: SpatialTrigger): void {
         if(debug) console.log("ENTER TRIGGER", this.name, trigger.name, this, trigger);
         trigger.raiseOnEnterEvent(this);
-        this.onEnter?.invoke(this, trigger);
+        this.onEnter?.invoke();
     }
     onExitTrigger(trigger: SpatialTrigger): void {
         if(debug) console.log("EXIT TRIGGER", this.name, trigger.name, this, trigger);
         trigger.raiseOnExitEvent(this);
-        this.onExit?.invoke(this, trigger);
+        this.onExit?.invoke();
     }
 
     onStayTrigger(trigger: SpatialTrigger): void {
         trigger.raiseOnStayEvent(this);
-        this.onStay?.invoke(this, trigger);
+        this.onStay?.invoke();
     }
 }
 

package/src/engine-components/timeline/SignalAsset.ts

@@ -1,9 +1,9 @@
 import { EventList } from "../EventList";
 import { Behaviour } from "../Component";
-import { ISerializable, SerializationContext, TypeSerializer } from "../../engine/engine_serialization_core";
-import { eventListSerializer } from "../../engine/engine_serialization_builtin_serializer";
 import { serializable } from "../../engine/engine_serialization_decorator";
+import { getParam } from "../../engine/engine_utils";
 
+const debug = getParam("debugsignals")
 
 
 export class SignalAsset {
@@ -36,6 +36,10 @@ export class SignalReceiver extends Behaviour {
     @serializable(SignalReceiverEvent)
     events?: SignalReceiverEvent[];
 
+    awake(): void {
+        if(debug) console.log("SignalReceiver awake", this);
+    }
+
     onEnable(): void {
         if (this.events) {
             for (const evt of this.events) {

package/src/engine-components/timeline/TimelineTracks.ts

@@ -723,6 +723,8 @@ export class SignalTrackHandler extends TrackHandler {
         // if (lastTime === -1) lastTime = time;
         // this._lastTime = time;
 
+        const estimatedFrameLengthWithPadding = this.director.context.time.deltaTime * 1.5;
+
         for (let i = 0; i < this.models.length; i++) {
             const model = this.models[i];
             const wasTriggered = this.didTrigger[i];
@@ -738,7 +740,7 @@ export class SignalTrackHandler extends TrackHandler {
             // }
             else {
                 const abs = Math.abs(td);
-                if (abs >= .00001 && abs < .1) {
+                if (abs >= .00001 && abs < estimatedFrameLengthWithPadding) {
                     isActive = true;
                 }
             }